[Django] #20739: Remove django.test.testcases dependency on django.contrib.staticfiles
Django
------------------------------------------------+------------------------
Reporter: ramiro | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Testing framework | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
As outlined in #8713 (more precisely on comment:13:ticket:8713). This is
action item 3.
The !LiveserverTestCase support class !LiveServerThread uses the
django.contrib.staticfiles.handlers.StaticFilesHandler.
--
Ticket URL: <https://code.djangoproject.com/ticket/20739>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: ramiro | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Testing framework | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by ramiro):
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/20739#comment:1>
Django
Reporter: ramiro | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Testing framework | Version: master
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by ramiro):
Pull request: https://github.com/django/django/pull/1354/files
Still not ready for merge.
--
Ticket URL: <https://code.djangoproject.com/ticket/20739#comment:2>
Django
Reporter: ramiro | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Testing framework | Version: master
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by jezdez):
* cc: jezdez (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/20739#comment:3>
Django
Reporter: ramiro | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Testing framework | Version: master
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by ramiro):
PR updated. Now it's ready for review and possible merging pending
feedback. Includes tests and doc changes.
--
Ticket URL: <https://code.djangoproject.com/ticket/20739#comment:4>
Django
Reporter: ramiro | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: Testing framework | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Ramiro Morales <cramm0@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"e909ceae9b3e72b72e0a2baaa92bba9714f18cd2"]:
{{{
#!CommitTicketReference repository=""
revision="e909ceae9b3e72b72e0a2baaa92bba9714f18cd2"
Made django.test.testcases not depend on staticfiles contrib app.
Do this by introducing a
django.contrib.staticfiles.testing.StaticLiveServerCase
unittest TestCase subclass.
Fixes #20739.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/20739#comment:5>
Django
Reporter: ramiro | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: Testing framework | Version: master
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Ramiro Morales <cramm0@…>):
In [changeset:"783620ccc827057d1d0f2c6f4808350be9193bf9"]:
{{{
#!CommitTicketReference repository=""
revision="783620ccc827057d1d0f2c6f4808350be9193bf9"
Fixed #21162 -- Better emulation of staticfiles middleware.
Code had been added in e909ceae9b. Solves test suite failures observed
on Windows.
Thanks Michael Manfre for the report. Refs #20739.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/20739#comment:6>
Django
Reporter: ramiro | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: Testing framework | Version: master
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Claude Paroz <claude@…>):
In [changeset:"3a44e20005e654affea89af49d82532d4d55e4a7"]:
{{{
#!CommitTicketReference repository=""
revision="3a44e20005e654affea89af49d82532d4d55e4a7"
Fixed #23374 -- Renamed StaticLiveServerCase to StaticLiveServerTestCase
Refs #20739. Thanks Raphaël Hertzog for the report and the initial
patch.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/20739#comment:7>
Django
Reporter: ramiro | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: Testing framework | Version: master
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Claude Paroz <claude@…>):
In [changeset:"9ac713645bb870c45d7aaf16b003e392f62d4ea3"]:
{{{
#!CommitTicketReference repository=""
revision="9ac713645bb870c45d7aaf16b003e392f62d4ea3"
[1.7.x] Fixed #23374 -- Renamed StaticLiveServerCase to
StaticLiveServerTestCase
Refs #20739. Thanks Raphaël Hertzog for the report and the initial
patch.
Backport of 3a44e2000 from master.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/20739#comment:8>