Re: [Django] #5789: Django LocaleMiddleware django_language should be _language
Django
-------------------------------------+-------------------------------------
Reporter: jdunck | Owner: stugots
Type: | Status: assigned
Cleanup/optimization | Component:
Milestone: | Internationalization
Version: SVN | Severity: Normal
Resolution: | Keywords: session i18n
Triage Stage: Accepted | backwards-incompatible
Needs documentation: 0 | Has patch: 1
Patch needs improvement: 1 | Needs tests: 0
| Easy pickings: 0
-------------------------------------+-------------------------------------
Changes (by patchhammer):
* needs_better_patch: 0 => 1
* easy: => 0
Comment:
5789.patch fails to apply cleanly on to trunk
--
Ticket URL: <http://code.djangoproject.com/ticket/5789#comment:12>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Type: | Status: assigned
Cleanup/optimization | Version: master
Component: | Resolution:
Internationalization | Triage Stage: Accepted
Severity: Normal | Needs documentation: 0
Keywords: session i18n | Patch needs improvement: 1
backwards-incompatible | UI/UX: 0
Has patch: 1 |
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* owner: stugots => bouke
Comment:
I've updated the patch and created a PR:
https://github.com/django/django/pull/1771
How should the migration be carried out? It could be done using a one-time
management command, but is it desirable to add it?
--
Ticket URL: <https://code.djangoproject.com/ticket/5789#comment:14>
Django
-------------------------------------+-------------------------------------
Reporter: jdunck | Owner: bouke
Cleanup/optimization | Version: master
Component: | Resolution: fixed
Internationalization | Triage Stage: Accepted
Severity: Normal | Needs documentation: 0
Keywords: session i18n | Patch needs improvement: 1
backwards-incompatible | UI/UX: 0
Has patch: 1 |
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"0d0f4f020afe516f23fd2305f13ff0a6a539b344"]:
{{{
#!CommitTicketReference repository=""
revision="0d0f4f020afe516f23fd2305f13ff0a6a539b344"
Fixed #5789 -- Changed LocaleMiddleware session variable to '_language'.
The old 'django_language' variable will still be read from in order
to migrate users. The backwards-compatability shim will be removed in
Django 1.8.
Thanks to jdunck for the report and stugots for the initial patch.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/5789#comment:15>
Django
-------------------------------------+-------------------------------------
Reporter: jdunck | Owner: bouke
Type: | Status: closed
Cleanup/optimization | Version: master
Component: | Resolution: fixed
Internationalization | Triage Stage: Accepted
Severity: Normal | Needs documentation: 0
Keywords: session i18n | Patch needs improvement: 1
backwards-incompatible | UI/UX: 0
Has patch: 1 |
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"6d1ae5e27c3fe612209023bacd8a201fffedc375"]:
{{{
#!CommitTicketReference repository=""
revision="6d1ae5e27c3fe612209023bacd8a201fffedc375"
Removed reading of old 'django_language' session variable per deprecation
timeline.
refs #5789.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/5789#comment:16>