Re: [Django] #14760: Admin inlines with file/image field fails to save_as

[Django]

#14760: Admin inlines with file/image field fails to save_as
-------------------------------------+-------------------------------------
Reporter: paulos | Owner: nobody
Type: Bug | Status: reopened
Component: contrib.admin | Version: 1.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Design
Has patch: 0 | decision needed
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by bmihelac):

* cc: bmihelac@… (added)

--
Ticket URL: <https://code.djangoproject.com/ticket/14760#comment:15>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#14760: Admin inlines with file/image field fails to save_as
-------------------------------------+-------------------------------------
Reporter: paulos | Owner: nobody
Type: Bug | Status: reopened
Component: contrib.admin | Version: 1.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Design
Has patch: 0 | decision needed
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by bmihelac):

This pull request addresses assigning initial values for FileFields and
its subclasses:

https://github.com/django/django/pull/697

What do you think?

--
Ticket URL: <https://code.djangoproject.com/ticket/14760#comment:16>

[Django]

#14760: Admin inlines with file/image field fails to save_as

-------------------------------+------------------------------------
Reporter: paulos | Owner: nobody
Type: Bug | Status: new

Component: contrib.admin | Version: 1.2
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------
Changes (by apollo13):

* stage: Design decision needed => Accepted

Comment:

Moving out of DDN since it is a valid issue, the safer solution would be
to copy the file if the storage backends would allow this.

--
Ticket URL: <https://code.djangoproject.com/ticket/14760#comment:18>

[Django]

#14760: Admin inlines with file/image field fails to save_as
-------------------------------+------------------------------------
Reporter: paulos | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------

Changes (by timo):

* needs_better_patch: 0 => 1
* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/14760#comment:19>

[Django]

#14760: Admin inlines with file/image field fails to save_as
-------------------------------+------------------------------------
Reporter: paulos | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------

Comment (by bmihelac):

timo, I can rework PR for master if it is acceptable to not copy files.

--
Ticket URL: <https://code.djangoproject.com/ticket/14760#comment:20>

[Django]

#14760: Admin inlines with file/image field fails to save_as
-------------------------------+------------------------------------
Reporter: paulos | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------

Comment (by carljm):

I don't see any need to copy files here. Since we made the decision to
remove file-deletion from `FileField` entirely I think the design approach
is that a `FileField` does not "own" the file, it just references it, so
IMO there is no problem having `FileField` on multiple model instances
referencing the same file. Unless someone is doing something unusual, any
updates to any of those models will involve uploading a new file anyway,
not changing the existing one in-place.

--
Ticket URL: <https://code.djangoproject.com/ticket/14760#comment:21>

[Django]

#14760: Admin inlines with file/image field fails to save_as
-------------------------------+------------------------------------
Reporter: paulos | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------

Comment (by bmihelac):

Good, I can make new PR based on this ASAP.

--
Ticket URL: <https://code.djangoproject.com/ticket/14760#comment:22>

[Django]

#14760: Admin inlines with file/image field fails to save_as
-------------------------------+------------------------------------
Reporter: paulos | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------

Comment (by bmihelac):

Reworked pull request in:

https://github.com/django/django/pull/2246

--
Ticket URL: <https://code.djangoproject.com/ticket/14760#comment:23>