Re: [Django] #13147: auth.UserCreationForm : unicity check on username not necessary
Django
-------------------------------------+-------------------------------------
Reporter: peyman | Owner: nobody
Type: | Status: closed
Cleanup/optimization | Version: 1.1
Component: contrib.auth | Resolution: wontfix
Severity: Normal | Triage Stage: Design
Keywords: | decision needed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by aaugustin):
* status: new => closed
* ui_ux: => 0
* resolution: => wontfix
* easy: => 0
Comment:
I agree with Luke.
--
Ticket URL: <https://code.djangoproject.com/ticket/13147#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: peyman | Owner: nobody
Type: | Status: closed
Cleanup/optimization | Version: 1.1
Component: contrib.auth | Resolution: wontfix
Severity: Normal | Triage Stage: Design
Keywords: | decision needed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by aaugustin):
In [17225]:
{{{
#!CommitTicketReference repository="" revision="17225"
Explained why UserCreationForm performs custom validation of usernames.
Refs #13147.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/13147#comment:7>
Django
-------------------------------------+-------------------------------------
Reporter: peyman | Owner: nobody
Type: | Status: closed
Cleanup/optimization | Version: 1.1
Component: contrib.auth | Resolution: wontfix
Severity: Normal | Triage Stage: Design
Keywords: | decision needed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by flisky):
A real fix comes from https://github.com/django/django/pull/2521 with some
cleanup.
--
Ticket URL: <https://code.djangoproject.com/ticket/13147#comment:8>
Django
Reporter: peyman | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timo):
* status: closed => new
* version: 1.1 => master
* resolution: wontfix =>
* stage: Design decision needed => Accepted
Comment:
The PR looks good to me. I'm going to add a release note to indicate that
`UserCreationForm.errors_messages['duplicate_username']` is no longer used
just in case someone is customizing that.
--
Ticket URL: <https://code.djangoproject.com/ticket/13147#comment:9>
Django
--------------------------------------+------------------------------------
Reporter: peyman | Owner: nobody
Component: contrib.auth | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"849538d03df21b69f0754a38ee4ec5f48fa02c52"]:
{{{
#!CommitTicketReference repository=""
revision="849538d03df21b69f0754a38ee4ec5f48fa02c52"
Fixed #13147 -- Moved User validation logic from form to model.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/13147#comment:10>
Django
--------------------------------------+------------------------------------
Reporter: peyman | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: contrib.auth | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"d5e1a2d5eb269df40979cda3eff3ed92c6d06d9c"]:
{{{
#!CommitTicketReference repository=""
revision="d5e1a2d5eb269df40979cda3eff3ed92c6d06d9c"
Added contrib.auth migration for refs #13147.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/13147#comment:11>
Django
--------------------------------------+------------------------------------
Reporter: peyman | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: contrib.auth | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"7affb4ad58e7ee93e4cca0c350315c63035ed648"]:
{{{
#!CommitTicketReference repository=""
revision="7affb4ad58e7ee93e4cca0c350315c63035ed648"
Fixed/improved release note for refs #13147; thanks Loic.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/13147#comment:12>
Django
--------------------------------------+------------------------------------
Reporter: peyman | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: contrib.auth | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by Loic Bistuer <loic.bistuer@…>):
In [changeset:"671e0c937c112b1908048b4d8deb14c0116b8946"]:
{{{
#!CommitTicketReference repository=""
revision="671e0c937c112b1908048b4d8deb14c0116b8946"
Further fix the release notes for refs #13147.
Mention of custom user models has been removed since UserCreationForm
didn't support custom user models anyway. Refs #19353.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/13147#comment:13>
Django
--------------------------------------+------------------------------------
Reporter: peyman | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: contrib.auth | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"8047e3666b0b50bb04e6f16c2a4fb21ddfd5713f" 8047e366]:
{{{
#!CommitTicketReference repository=""
revision="8047e3666b0b50bb04e6f16c2a4fb21ddfd5713f"
Added contrib.auth migration for refs #13147.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/13147#comment:14>