Re: [Django] #32136: Period inside of quoting in the deletion message
Django
-------------------------------+--------------------------------------
Reporter: Vlada Macek | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------+--------------------------------------
Description changed by Vlada Macek:
Old description:
> The sentence should end after the quoting ends in Admin. Not like this:
> {{{
> 'Deleted “%(object)s.”'
> }}}
> but like this
> {{{
> 'Deleted “%(object)s”.'
> }}}
>
> Including patch against master with all the POs files to. Please
> regenerate the MOs.
New description:
The sentence should end after the quoting ends in Admin. Not like this:
{{{
'Deleted “%(object)s.”'
}}}
but like this
{{{
'Deleted “%(object)s”.'
}}}
Including patch against master with all the PO files too. Please
regenerate the MOs.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/32136#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------+------------------------------------
Component: contrib.admin | Version: master
Severity: Normal | Resolution: invalid
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------+------------------------------------
* status: new => closed
* has_patch: 1 => 0
* resolution: => invalid
Comment:
Thanks for this ticket, however in American English, the punctuation
usually goes inside the quote, see
[https://github.com/django/django/pull/11281#discussion_r278580862
discussion].
--
Ticket URL: <https://code.djangoproject.com/ticket/32136#comment:3>
Django
-------------------------------+------------------------------------
Reporter: Vlada Macek | Owner: nobody
Type: Bug | Status: closed
Component: contrib.admin | Version: master
Severity: Normal | Resolution: invalid
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------+------------------------------------
Comment (by Vlada Macek):
Incredible. This looks so strange...
So the line `Added “%(object)s”.` is probably incorrect and
inconsistent...
--
Ticket URL: <https://code.djangoproject.com/ticket/32136#comment:4>
Django
-------------------------------+------------------------------------
Reporter: Vlada Macek | Owner: nobody
Type: Bug | Status: closed
Component: contrib.admin | Version: master
Severity: Normal | Resolution: invalid
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------+------------------------------------
Comment (by Mariusz Felisiak):
Yes, there is another
[https://github.com/django/django/pull/11859#issue-323203991 discussion]
(in which you were mentioned) to change other messages for consistency.
Feel-free to send PR via GitHub.
--
Ticket URL: <https://code.djangoproject.com/ticket/32136#comment:5>
Django
-------------------------------+------------------------------------
Reporter: Vlada Macek | Owner: nobody
Type: Bug | Status: closed
Component: contrib.admin | Version: master
Severity: Normal | Resolution: invalid
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------+------------------------------------
Comment (by Vlada Macek):
Oh, thank you. They mistyped my nickname in the mention, so I was unaware.
Yesterday I wanted to bring some clarity and less confusion to stuff. But
I think I leave PR putting the punctuation inside quoting to someone who
does not mind to follow the nonsensical American inertia-based rules from
the long-gone ages of metallic typing.
Having period looking to be a part of the object representation distorts
the object name. In my language (Czech) there is a sub-rule for inserted
texts having no connection with the sentence, then we put period after the
closing quotation.
Peace :-)
--
Ticket URL: <https://code.djangoproject.com/ticket/32136#comment:6>