[Django] #20844: AdminEmailHandler does not utilze the 'formatter' setting.
Django
-------------------------------+--------------------
Reporter: danols | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 1.5
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------
Emailed log messages through the `AdminEmailHandler` only include the
message as returned by the do `record.getMessage()` method and omit
utilizing the `formatter` string setting. A patch that will include the
formatted log entry in the body of the email will follow shortly.
--
Ticket URL: <https://code.djangoproject.com/ticket/20844>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: danols | Owner: danols
Type: Bug | Status: assigned
Component: Utilities | Version: 1.5
Severity: Normal | Resolution:
Keywords: AdminEmailHandler, | Triage Stage:
Logging | Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by danols):
* status: new => assigned
* needs_better_patch: => 0
* component: Uncategorized => Utilities
* needs_tests: => 0
* keywords: => AdminEmailHandler, Logging
* easy: 0 => 1
* owner: nobody => danols
* needs_docs: => 0
* has_patch: 0 => 1
* type: Uncategorized => Bug
Comment:
Patch in Git pull request: https://github.com/django/django/pull/1423
Sample generated email subject:
{{{
`[Some Site][Development] ERROR: Refactor this to use QuerySet level
solution as per ticket - https://code.djangoproject.com/ticket/20625 -
Offer.objects.filter(...).active() != Offer.objects.active.filter(...)`
}}}
Sample generated email message:
{{{
ERROR django.db.models.manager 2013-08-01 11:58:03,897 manager 6516
-1244890304 /srv/www/django/development.yupi.ca/src/github-
danielsokolowski-django-
ticket_20625-tailored/django/db/models/manager.py@139: Refactor this to
use QuerySet level solution as per ticket -
https://code.djangoproject.com/ticket/20625 -
Offer.objects.filter(...).active() != Offer.objects.active.filter(...)
No stack trace available
Request repr() unavailable.}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/20844#comment:1>
Django
Reporter: danols | Owner: danols
Type: Bug | Status: assigned
Component: Utilities | Version: 1.5
Severity: Normal | Resolution:
Logging | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 1
Needs tests: 0 | UI/UX: 0
Easy pickings: 1 |
-------------------------------------+-------------------------------------
Changes (by polmuz):
* cc: polmuz (added)
* needs_better_patch: 0 => 1
* stage: Unreviewed => Accepted
Comment:
There's something weird with the pull request, I'm seeing 14 extra commits
that are not related to this issue.
--
Ticket URL: <https://code.djangoproject.com/ticket/20844#comment:2>
Django
Reporter: danols | Owner: danols
Type: Bug | Status: assigned
Component: Utilities | Version: 1.5
Severity: Normal | Resolution:
Keywords: AdminEmailHandler, | Triage Stage: Accepted
Logging | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 1
Needs tests: 0 | UI/UX: 0
Easy pickings: 1 |
-------------------------------------+-------------------------------------
Comment (by danols):
You are right - I don't understand why. Regardless here is the original
ticket branch: https://github.com/danielsokolowski/django/tree/master-
ticket-20844
And new pull request here --- well something very odd indeed I can not
create a new pull request; I will look into this when I find more time,
thanks for pointing out the issue.
--
Ticket URL: <https://code.djangoproject.com/ticket/20844#comment:3>
Django
Reporter: danols | Owner: danols
Type: Bug | Status: assigned
Component: Utilities | Version: 1.5
Severity: Normal | Resolution:
Keywords: AdminEmailHandler, | Triage Stage: Accepted
Logging | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 1
Needs tests: 0 | UI/UX: 0
Easy pickings: 1 |
-------------------------------------+-------------------------------------
Comment (by timo):
I'm not sure about this change as it stands right now. With it, tracebacks
are included twice in each email.
--
Ticket URL: <https://code.djangoproject.com/ticket/20844#comment:4>
Django
Reporter: danols | Owner: danols
Type: Bug | Status: assigned
Component: Utilities | Version: 1.5
Severity: Normal | Resolution:
Keywords: AdminEmailHandler, | Triage Stage: Accepted
Logging | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 1
Needs tests: 0 | UI/UX: 0
Easy pickings: 1 |
-------------------------------------+-------------------------------------
Comment (by danols):
I wanted to keep changes to minimum but for sure agree with you - here is
the updated code https://github.com/danielsokolowski/django/tree/master-
ticket-20844 which does not duplicate the stack trace.
Sample email:
{{{
Subject: [Yupi][Development] ERROR (EXTERNAL IP): Internal Server Error:
/offers/negotiate/1/1/
WARNING django.db.models.manager 2013-09-12 09:38:02,049 manager 6626
-1244792000 /srv/www/django/development.yupi.ca/src/github-
danielsokolowski-django-
ticket_20625-tailored/django/db/models/manager.py@139: Refactor this to
use QuerySet level solution as per ticket -
https://code.djangoproject.com/ticket/20625 -
Offer.objects.filter(...).active() != Offer.objects.active.filter(...)
Request repr(): unavailable
}}}
Now does anyone is having issue creating git pull requests? I am unable to
create a pull request - it just cycles me back to the creation page -
tried three different browsers so it does not appear to be a front end
issue.
--
Ticket URL: <https://code.djangoproject.com/ticket/20844#comment:5>
Django
Reporter: danols | Owner: danols
Component: Utilities | Version: 1.5
Severity: Normal | Resolution: fixed
Keywords: AdminEmailHandler, | Triage Stage: Accepted
Logging | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 1
Needs tests: 0 | UI/UX: 0
Easy pickings: 1 |
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"ad6fcdb8d24d84a130f847f45b51d7e892ccca08"]:
{{{
#!CommitTicketReference repository=""
revision="ad6fcdb8d24d84a130f847f45b51d7e892ccca08"
Fixed #20844 -- Made AdminEmailHandler respect LOGGING 'formatter'
setting.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/20844#comment:6>