[Django] #25870: Wrong position of Action button in admin when using filters

1 view
Skip to first unread message

Django

unread,
Dec 5, 2015, 1:49:44 PM12/5/15
to django-...@googlegroups.com
#25870: Wrong position of Action button in admin when using filters
-------------------------------+---------------------------
Reporter: igorcc | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.9
Severity: Normal | Keywords: action button
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 1 | UI/UX: 1
-------------------------------+---------------------------
While using filters, the Action button is beind placed over the select
field.
See screenshot, please.
To avoid this misbehavior I'd suggest to change the line 320 in the file
django/contrib/admin/static/admin/css/changelists.css by commenting it.
"inline-block" in this case seems works badly.


{{{
319 #changelist .actions label {
320 /* display: inline-block; */
321 vertical-align: middle;
322 font-size: 13px;
323 }
}}}


Thank you!

--
Ticket URL: <https://code.djangoproject.com/ticket/25870>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Dec 5, 2015, 1:50:02 PM12/5/15
to django-...@googlegroups.com
#25870: Wrong position of Action button in admin when using filters
---------------------------+----------------------------

Reporter: igorcc | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.9
Severity: Normal | Resolution:

Keywords: action button | Triage Stage: Unreviewed
Has patch: 1 | Easy pickings: 1
UI/UX: 1 |
---------------------------+----------------------------
Changes (by igorcc):

* Attachment "Screen Shot 2015-12-05 at 21.44.29.png" added.

Django

unread,
Dec 5, 2015, 1:51:08 PM12/5/15
to django-...@googlegroups.com
#25870: Wrong position of Action button in admin when using filters
---------------------------+----------------------------

Reporter: igorcc | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.9
Severity: Normal | Resolution:

Keywords: action button | Triage Stage: Unreviewed
Has patch: 1 | Easy pickings: 1
UI/UX: 1 |
---------------------------+----------------------------
Changes (by igorcc):

* Attachment "after_commenting.png" added.

Django

unread,
Dec 5, 2015, 5:30:46 PM12/5/15
to django-...@googlegroups.com
#25870: Wrong position of Action button in admin when using filters
-------------------------------+------------------------------------

Reporter: igorcc | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.9
Severity: Normal | Resolution:
Keywords: action button | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 1
-------------------------------+------------------------------------
Changes (by timgraham):

* cc: elky (added)
* needs_better_patch: => 0
* needs_docs: => 0
* needs_tests: => 0
* stage: Unreviewed => Accepted


Comment:

elky, can you check it? That line seems to from django-flat-theme.

--
Ticket URL: <https://code.djangoproject.com/ticket/25870#comment:1>

Django

unread,
Dec 5, 2015, 5:39:16 PM12/5/15
to django-...@googlegroups.com
#25870: Wrong position of Action button in admin when using filters
-------------------------------+------------------------------------

Reporter: igorcc | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.9
Severity: Normal | Resolution:
Keywords: action button | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by elky):

Replying to [ticket:25870 igorcc]:
Can you provide more info please? Browser and OS.
Are you 100% sure that any 3rd party app doesn't override this styles?

--
Ticket URL: <https://code.djangoproject.com/ticket/25870#comment:2>

Django

unread,
Dec 6, 2015, 2:57:05 AM12/6/15
to django-...@googlegroups.com
#25870: Wrong position of Action button in admin when using filters
-------------------------------+------------------------------------

Reporter: igorcc | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.9
Severity: Normal | Resolution:
Keywords: action button | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by igorcc):

Replying to [comment:2 elky]:


> Replying to [ticket:25870 igorcc]:
> Can you provide more info please? Browser and OS.
> Are you 100% sure that any 3rd party app doesn't override this styles?

I'm using Firefox 42.0 along with iOS 10.9.5.
Before I submitted a bug a tested it in Safari 9.0.1 and last Chrome.
The misbehaviour was the same in every browser.
I suppose it's because that the length of an action button with Russian
word is quite long.
Anyway, commenting the line "display: inline-block;" out works fine for
me.

Hope that helps.
Thank you!

--
Ticket URL: <https://code.djangoproject.com/ticket/25870#comment:3>

Django

unread,
Dec 6, 2015, 7:00:54 AM12/6/15
to django-...@googlegroups.com
#25870: Wrong position of Action button in admin when using filters
-------------------------------+------------------------------------

Reporter: igorcc | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.9
Severity: Normal | Resolution:
Keywords: action button | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by elky):

Can't reproduce it.

Could you try to test it on fully clean Django project? (without any other
apps)

--
Ticket URL: <https://code.djangoproject.com/ticket/25870#comment:4>

Django

unread,
Dec 6, 2015, 1:19:01 PM12/6/15
to django-...@googlegroups.com
#25870: Wrong position of Action button in admin when using filters
-------------------------------+------------------------------------

Reporter: igorcc | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.9
Severity: Normal | Resolution:
Keywords: action button | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by igorcc):

Clean app works fine.
I rummaged over the html code and found that an old bootstrap 2 css file
flows in there.
When I remove it from code everything works fine. Except our custom
widgets. ;-)
That's our fault.
Thank you!

--
Ticket URL: <https://code.djangoproject.com/ticket/25870#comment:5>

Django

unread,
Dec 6, 2015, 2:17:03 PM12/6/15
to django-...@googlegroups.com
#25870: Wrong position of Action button in admin when using filters
-------------------------------+--------------------------------------
Reporter: igorcc | Owner: nobody
Type: Bug | Status: closed
Component: contrib.admin | Version: 1.9
Severity: Normal | Resolution: worksforme

Keywords: action button | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------+--------------------------------------
Changes (by claudep):

* status: new => closed
* resolution: => worksforme


--
Ticket URL: <https://code.djangoproject.com/ticket/25870#comment:6>

Reply all
Reply to author
Forward
0 new messages