[Django] #20780: collectstatic --link causes IOError when dangling symlink exists
Django
-------------------------------------+--------------------
Reporter: vdboor | Owner: nobody
Type: Bug | Status: new
Component: contrib.staticfiles | Version: 1.5
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+--------------------
When a symlink file already exists, but it's source was moved/renamed,
`collectstatic` ends with an `IOError`.
Here is a trackback example:
{{{
Linking '/srv/www/virtualenvs/demo.example.org/src/django-filebrowser-no-
grappelli-django14/filebrowser/static/filebrowser/js/FB_TinyMCE.js'
Traceback (most recent call last):
File "manage.py", line 10, in <module>
execute_from_command_line(sys.argv)
File "/srv/www/virtualenvs/demo.example.org/lib/python2.6/site-
packages/django/core/management/__init__.py", line 443, in
execute_from_command_line
utility.execute()
File "/srv/www/virtualenvs/demo.example.org/lib/python2.6/site-
packages/django/core/management/__init__.py", line 382, in execute
self.fetch_command(subcommand).run_from_argv(self.argv)
File "/srv/www/virtualenvs/demo.example.org/lib/python2.6/site-
packages/django/core/management/base.py", line 196, in run_from_argv
self.execute(*args, **options.__dict__)
File "/srv/www/virtualenvs/demo.example.org/lib/python2.6/site-
packages/django/core/management/base.py", line 232, in execute
output = self.handle(*args, **options)
File "/srv/www/virtualenvs/demo.example.org/lib/python2.6/site-
packages/django/core/management/base.py", line 371, in handle
return self.handle_noargs(**options)
File "/srv/www/virtualenvs/demo.example.org/lib/python2.6/site-
packages/django/contrib/staticfiles/management/commands/collectstatic.py",
line 163, in handle_noargs
collected = self.collect()
File "/srv/www/virtualenvs/demo.example.org/lib/python2.6/site-
packages/django/contrib/staticfiles/management/commands/collectstatic.py",
line 113, in collect
handler(path, prefixed_path, storage)
File "/srv/www/virtualenvs/demo.example.org/lib/python2.6/site-
packages/django/contrib/staticfiles/management/commands/collectstatic.py",
line 275, in link_file
os.symlink(source_path, full_path)
OSError: [Errno 17] File exists
}}}
I switched moduled here, hence the symlinks of the previous "filebrowser"
were still there, but no longer pointed to an existing file.
The same also happens when one reorganized the project layout, while.
How to reproduce:
* Have a project with 1 app.
* run `./manage.py collectstatic --link`
* Rename that app, or move it to a sub package.
* run `./manage.py collectstatic --link` again.
--
Ticket URL: <https://code.djangoproject.com/ticket/20780>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: vdboor | Owner: johngian
Type: Bug | Status: assigned
Component: contrib.staticfiles | Version: 1.5
Severity: Normal | Resolution:
Keywords: | Triage Stage:
Has patch: 0 | Unreviewed
Needs tests: 0 | Needs documentation: 0
Easy pickings: 1 | Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by johngian):
* status: new => assigned
* cc: johngian (added)
* needs_better_patch: => 0
* needs_tests: => 0
* owner: nobody => johngian
* needs_docs: => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/20780#comment:1>
Django
Reporter: vdboor | Owner: johngian
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage:
Needs tests: 0 | Needs documentation: 0
Easy pickings: 1 | Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by johngian):
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/20780#comment:2>
Django
Reporter: vdboor | Owner: johngian
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by wim@…):
* stage: Unreviewed => Accepted
Comment:
Hehe I ran into the same issue not too long ago, when I too was dealing
with a filebrowser.
--
Ticket URL: <https://code.djangoproject.com/ticket/20780#comment:3>
Django
Reporter: vdboor | Owner: johngian
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Comment (by wim@…):
Hi John, does your patch not leave the broken link, in stead of replacing
it by the new one?
--
Ticket URL: <https://code.djangoproject.com/ticket/20780#comment:4>
Django
Reporter: vdboor | Owner: johngian
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+------------------------------------
Changes (by timo):
* easy: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/20780#comment:5>
Django
Reporter: vdboor | Owner: johngian
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+------------------------------------
Comment (by johngian):
Hi, sorry for not showing a sign of process after that long time.
Yes, the patch I had sent left the broken link instead of replacing it.
I am attaching an updated patch that removes the dangling symlink first.
--
Ticket URL: <https://code.djangoproject.com/ticket/20780#comment:6>
Django
Reporter: vdboor | Owner: johngian
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+------------------------------------
* needs_tests: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/20780#comment:7>
Django
Reporter: vdboor | Owner: johngian
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+------------------------------------
* needs_tests: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/20780#comment:8>
Django
Reporter: vdboor | Owner: johngian
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+------------------------------------
Comment (by johngian):
Updated patch with tests.
--
Ticket URL: <https://code.djangoproject.com/ticket/20780#comment:9>
Django
Reporter: vdboor | Owner: johngian
Component: contrib.staticfiles | Version: 1.5
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"f90be002d9d3c10b87c74741986e2cbf9f2b858e"]:
{{{
#!CommitTicketReference repository=""
revision="f90be002d9d3c10b87c74741986e2cbf9f2b858e"
Fixed #20780 -- Get rid of stale symlinks when using collectstatic.
Thanks to John Giannelos for the initial patch.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/20780#comment:10>