[Django] #32866: urlize does not handle html escaped string correctly

9 views
Skip to first unread message

Django

unread,
Jun 19, 2021, 7:19:58 AM6/19/21
to django-...@googlegroups.com
#32866: urlize does not handle html escaped string correctly
----------------------------------------+------------------------
Reporter: Shipeng Feng | Owner: nobody
Type: Bug | Status: new
Component: Utilities | Version: dev
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
----------------------------------------+------------------------
Example:

{{{
#!python
urlize('Search for google.com/?q=1&lt! and see.')

# expected output
'Search for <a href="http://google.com/?q=1%3C">google.com/?q=1&lt</a>!
and see.'

# actual output
'Search for <a href="http://google.com/?q=1%3C">google.com/?q=1&lt</a>lt!
and see.'
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/32866>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jun 19, 2021, 7:20:19 AM6/19/21
to django-...@googlegroups.com
#32866: urlize does not handle html escaped string correctly
------------------------------+----------------------------------------
Reporter: Shipeng Feng | Owner: Shipeng Feng
Type: Bug | Status: assigned
Component: Utilities | Version: dev
Severity: Normal | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
------------------------------+----------------------------------------
Changes (by Shipeng Feng):

* owner: nobody => Shipeng Feng
* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/32866#comment:1>

Django

unread,
Jun 19, 2021, 7:33:00 AM6/19/21
to django-...@googlegroups.com
#32866: urlize does not handle html escaped string correctly
------------------------------+----------------------------------------
Reporter: Shipeng Feng | Owner: Shipeng Feng
Type: Bug | Status: assigned
Component: Utilities | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
------------------------------+----------------------------------------
Changes (by Shipeng Feng):

* has_patch: 0 => 1


Comment:

https://github.com/django/django/pull/14539/

--
Ticket URL: <https://code.djangoproject.com/ticket/32866#comment:2>

Django

unread,
Jun 19, 2021, 7:34:35 AM6/19/21
to django-...@googlegroups.com
#32866: urlize() does not handle html escaped string and trailing punctuation

correctly
------------------------------+----------------------------------------
Reporter: Shipeng Feng | Owner: Shipeng Feng
Type: Bug | Status: assigned
Component: Utilities | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
------------------------------+----------------------------------------

--
Ticket URL: <https://code.djangoproject.com/ticket/32866#comment:3>

Django

unread,
Jun 22, 2021, 2:57:48 AM6/22/21
to django-...@googlegroups.com
#32866: urlize() does not handle html escaped string and trailing punctuation
correctly
------------------------------+----------------------------------------
Reporter: Shipeng Feng | Owner: Shipeng Feng
Type: Bug | Status: assigned
Component: Utilities | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
------------------------------+----------------------------------------
Changes (by Carlton Gibson):

* stage: Unreviewed => Accepted


Comment:

OK, thanks, the example looks right. It's always delicate but let's take
this for review.

Related to #26193.

--
Ticket URL: <https://code.djangoproject.com/ticket/32866#comment:4>

Django

unread,
Jul 7, 2021, 5:19:45 AM7/7/21
to django-...@googlegroups.com
#32866: urlize() does not handle html escaped string and trailing punctuation
correctly
------------------------------+----------------------------------------
Reporter: Shipeng Feng | Owner: Shipeng Feng
Type: Bug | Status: closed
Component: Utilities | Version: dev
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
------------------------------+----------------------------------------
Changes (by GitHub <noreply@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"68cc04887b3c5b7ce8f28eaae5de266db99ca9a6" 68cc0488]:
{{{
#!CommitTicketReference repository=""
revision="68cc04887b3c5b7ce8f28eaae5de266db99ca9a6"
Fixed #32866 -- Fixed trimming trailing punctuation from escaped string in
urlize().
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/32866#comment:5>

Reply all
Reply to author
Forward
0 new messages