[Django] #30421: Allow ManyToMany using a intermediary table to be defined as symmetrical
Django
-------------------------------------+-------------------------------------
Reporter: Nadege | Owner: Nadege
Type: New | Status: assigned
feature |
Component: Database | Version: 2.2
layer (models, ORM) | Keywords: many2many, through,
Severity: Normal | symmetrical, through
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Thanks to the work made by Collin Anderson in #9475 I think we can remove
the check
"fields.E332 Many-to-many fields with intermediate tables must not be
symmetrical." with a little adjustment.
This change was discussed in the django-dev mailing list
[https://groups.google.com/forum/#!topic/django-developers/BuT0-Uq8pyc].
This would let have
{{{
class Person(models.Model):
name = models.CharField(max_length=20)
friends = models.ManyToManyField('self', through='Friendship')
class Friendship(models.Model):
first = models.ForeignKey(Person, models.CASCADE, related_name="+")
second = models.ForeignKey(Person, models.CASCADE)
friendship_date = models.DateTimeField()
}}}
and just do something like
{{{
joe.friends.add(anna, through_defaults={'friendship_date':
date.datetime(...)})
}}}
where currently we would have to do
{{{
joe.friends.add(anna, through_defaults={'friendship_date':
date.datetime(...)})
anna.friends.add(joe, through_defaults={'friendship_date':
date.datetime(...)})
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/30421>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: Nadege | Owner: Nadege
Component: Database layer | Version: 2.2
(models, ORM) |
Severity: Normal | Resolution:
Keywords: many2many, through, | Triage Stage:
symmetrical, through | Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/30421#comment:1>
Django
-------------------------------------+-------------------------------------
Reporter: Nadege | Owner: Nadege
Component: Database layer | Version: 2.2
(models, ORM) |
Severity: Normal | Resolution:
Keywords: many2many, through, | Triage Stage:
symmetrical, through | Unreviewed
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Nadege):
Pull request: https://github.com/django/django/pull/11298
--
Ticket URL: <https://code.djangoproject.com/ticket/30421#comment:2>
Django
symmetrical.
-------------------------------------+-------------------------------------
Reporter: Nadege | Owner: Nadege
(models, ORM) |
Severity: Normal | Resolution:
symmetrical, through |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* version: 2.2 => master
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/30421#comment:3>
Django
symmetrical.
-------------------------------------+-------------------------------------
Reporter: Nadege | Owner: Nadege
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: many2many, through, | Triage Stage: Accepted
symmetrical, through |
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/30421#comment:4>
Django
symmetrical.
-------------------------------------+-------------------------------------
Reporter: Nadege | Owner: Nadege
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
symmetrical, through | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 1 => 0
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/30421#comment:5>
Django
symmetrical.
-------------------------------------+-------------------------------------
Reporter: Nadege | Owner: Nadege
Component: Database layer | Version: master
(models, ORM) |
Keywords: many2many, through, | Triage Stage: Ready for
symmetrical, through | checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"87b1ad6e7351464c60e751b483d9dfce3a2d3382" 87b1ad6e]:
{{{
#!CommitTicketReference repository=""
revision="87b1ad6e7351464c60e751b483d9dfce3a2d3382"
Fixed #30421 -- Allowed symmetrical intermediate table for self-
referential ManyToManyField.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/30421#comment:6>