[Django] #21090: inspectdb shouldn't include 'models.' prefix if field_type is a dotted path

7 views
Skip to first unread message

Django

unread,
Sep 11, 2013, 10:55:37 AM9/11/13
to django-...@googlegroups.com
#21090: inspectdb shouldn't include 'models.' prefix if field_type is a dotted path
--------------------------------------------+-----------------------
Reporter: manfre | Owner: nobody
Type: New feature | Status: new
Component: Core (Management commands) | Version: 1.5
Severity: Normal | Keywords: inspectdb
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------------+-----------------------
To allow backends to better provide custom field types to inspectdb, it
should not include the 'models.' prefix if the field_type contains a dot.

This would allow for:
{{{
id = sqlserver_ado.fields.BigAutoField()
}}}

instead of:
{{{
id = models.sqlserver_ado.fields.BigAutoField()
}}}

This ticket intentionally does not address the lack of import for
`sqlserver_ado.fields`

--
Ticket URL: <https://code.djangoproject.com/ticket/21090>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Sep 11, 2013, 11:16:28 AM9/11/13
to django-...@googlegroups.com
#21090: inspectdb shouldn't include 'models.' prefix if field_type is a dotted path
-------------------------------------+-------------------------------------

Reporter: manfre | Owner: nobody
Type: New feature | Status: new
Component: Core (Management | Version: 1.5
commands) | Resolution:
Severity: Normal | Triage Stage:
Keywords: inspectdb | Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by manfre):

* needs_better_patch: => 0
* has_patch: 0 => 1
* needs_tests: => 0
* needs_docs: => 0


Comment:

https://github.com/django/django/pull/1617

--
Ticket URL: <https://code.djangoproject.com/ticket/21090#comment:1>

Django

unread,
Sep 11, 2013, 12:26:15 PM9/11/13
to django-...@googlegroups.com
#21090: inspectdb shouldn't include 'models.' prefix if field_type is a dotted path
-------------------------------------+-------------------------------------

Reporter: manfre | Owner: nobody
Type: New feature | Status: new
Component: Core (Management | Version: master
commands) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: inspectdb | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 1 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by timo):

* version: 1.5 => master
* easy: 1 => 0
* needs_tests: 0 => 1
* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/21090#comment:2>

Django

unread,
Sep 11, 2013, 1:55:58 PM9/11/13
to django-...@googlegroups.com
#21090: inspectdb shouldn't include 'models.' prefix if field_type is a dotted path
-------------------------------------+-------------------------------------
Reporter: manfre | Owner: nobody
Type: New feature | Status: closed

Component: Core (Management | Version: master
commands) | Resolution: fixed

Severity: Normal | Triage Stage: Accepted
Keywords: inspectdb | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 1 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"e61cc87129727c66120b67c376feda3533544db1"]:
{{{
#!CommitTicketReference repository=""
revision="e61cc87129727c66120b67c376feda3533544db1"
Fixed #21090 -- Allowed backends to provide dotted field path to
inspectdb.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/21090#comment:3>

Reply all
Reply to author
Forward
0 new messages