[Django] #21489: Expose FormSet on the django.forms package.
Django
--------------------------------------+--------------------
Reporter: loic84 | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Forms | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 0 | UI/UX: 0
--------------------------------------+--------------------
Currently formsets are not importable directly from `django.forms`, this
is especially inconvenient as they are scattered between
`django.forms.models` and `django.forms.formsets` and I somehow always
fail to locate them.
I propose we add the relevant entries in `__all__`.
PR https://github.com/django/django/pull/1961.
--
Ticket URL: <https://code.djangoproject.com/ticket/21489>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: loic84 | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: master
Component: Forms | Resolution:
Severity: Normal | Triage Stage:
Keywords: | Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timo):
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Comment:
I believe there was some discussion on IRC about this ticket, could you
summarize?
Personally, I have found the fact that these have to be imported
differently a bit puzzling and am happy to merge it absent strong
objections.
--
Ticket URL: <https://code.djangoproject.com/ticket/21489#comment:1>
Django
Reporter: loic84 | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: master
Component: Forms | Resolution:
Severity: Normal | Triage Stage:
Keywords: | Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Comment (by loic84):
If I remember well, Baptiste wasn't totally convinced at first, fearing
to add more bloat to an already bloated package. Anssi welcomed the
change, arguing that having almost everything in `django.forms` but
leaving just a couple of things out was confusing. Then I believe
consensus was reached and the discussion shifted to whether or not we
should update the docs.
The issue with updating the docs now is that it would lead to broken
imports for people who follow dev docs despite using an earlier version of
Django.
The consensus was to update the docs in a couple of versions and open a
ticket in the meantime so it doesn't get lost (triage stage of Someday /
Maybe?).
FWIW I already have a branch for the docs update
https://github.com/loic/django/compare/formset_docs.
--
Ticket URL: <https://code.djangoproject.com/ticket/21489#comment:2>
Django
Reporter: loic84 | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: master
Component: Forms | Resolution:
Severity: Normal | Triage Stage:
Keywords: | Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Comment (by timo):
I'm fine updating the import examples as a someday/maybe item, but I think
I would prefer not to make the module changes as done in your branch since
it will make backporting doc changes more painful and the synopsis
annotations would no longer work.
--
Ticket URL: <https://code.djangoproject.com/ticket/21489#comment:3>
Django
Reporter: loic84 | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: master
Component: Forms | Resolution:
Severity: Normal | Triage Stage:
Keywords: | Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Comment (by loic84):
That's a valid concern, no objections from me.
--
Ticket URL: <https://code.djangoproject.com/ticket/21489#comment:4>
Django
Reporter: loic84 | Owner: nobody
Type: | Status: closed
Cleanup/optimization | Version: master
Component: Forms | Resolution: fixed
Severity: Normal | Triage Stage:
Keywords: | Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Changes (by bmispelon):
* status: new => closed
* resolution: => fixed
Comment:
Fixed in 1c7a83ee8e3da431d9d21dae42da8f1f89973f7c.
--
Ticket URL: <https://code.djangoproject.com/ticket/21489#comment:5>
Django
Reporter: loic84 | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Forms | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"455034d4df048010de4ae0a9a2392b70d1463c61" 455034d4]:
{{{
#!CommitTicketReference repository=""
revision="455034d4df048010de4ae0a9a2392b70d1463c61"
Fixed #21516 -- Updated imports paths for some formset functions/classes.
Since refs #21489, FormSet classes and factories are exposed on the
django.forms package.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/21489#comment:6>
Django
Reporter: loic84 | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Forms | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"44f177b5cdab82ffefa81abd3e9c2a13aaab256f" 44f177b5]:
{{{
#!CommitTicketReference repository=""
revision="44f177b5cdab82ffefa81abd3e9c2a13aaab256f"
[1.9.x] Fixed #21516 -- Updated imports paths for some formset
functions/classes.
Since refs #21489, FormSet classes and factories are exposed on the
django.forms package.
Backport of 455034d4df048010de4ae0a9a2392b70d1463c61 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/21489#comment:7>
Django
Reporter: loic84 | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Forms | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"42f254674243928a563364389906a00303cc9a56" 42f25467]:
{{{
#!CommitTicketReference repository=""
revision="42f254674243928a563364389906a00303cc9a56"
[1.8.x] Fixed #21516 -- Updated imports paths for some formset
functions/classes.
Since refs #21489, FormSet classes and factories are exposed on the
django.forms package.
Backport of 455034d4df048010de4ae0a9a2392b70d1463c61 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/21489#comment:8>