Re: [Django] #10935: forms.ImageField.clean should annotate the object returned by FileField.clean

[Django]

#10935: forms.ImageField.clean should annotate the object returned by
FileField.clean
--------------------------------------+------------------------------------
Reporter: jdunck | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by jacob):

* stage: Design decision needed => Accepted

--
Ticket URL: <https://code.djangoproject.com/ticket/10935#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#10935: forms.ImageField.clean should annotate the object returned by
FileField.clean
--------------------------------------+------------------------------------

Reporter: jdunck | Owner: petraszd
Type: Cleanup/optimization | Status: assigned

Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------

Changes (by petraszd):

* status: new => assigned
* owner: nobody => petraszd

--
Ticket URL: <https://code.djangoproject.com/ticket/10935#comment:9>

[Django]

#10935: forms.ImageField.clean should annotate the object returned by
FileField.clean
--------------------------------------+------------------------------------
Reporter: jdunck | Owner: petraszd
Type: Cleanup/optimization | Status: assigned
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 1

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by petraszd):

* has_patch: 0 => 1

Comment:

Pull request: https://github.com/django/django/pull/2972

--
Ticket URL: <https://code.djangoproject.com/ticket/10935#comment:10>

[Django]

#10935: forms.ImageField.clean should annotate the object returned by
FileField.clean
--------------------------------------+------------------------------------
Reporter: jdunck | Owner: petraszd
Type: Cleanup/optimization | Status: assigned
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by petraszd):

* needs_docs: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/10935#comment:11>

[Django]

#10935: forms.ImageField.clean should annotate the object returned by
FileField.clean
--------------------------------------+------------------------------------
Reporter: jdunck | Owner: petraszd
Type: Cleanup/optimization | Status: assigned
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------

Changes (by slurms):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/10935#comment:12>

[Django]

#10935: forms.ImageField.clean should annotate the object returned by
FileField.clean
--------------------------------------+------------------------------------
Reporter: jdunck | Owner: petraszd
Type: Cleanup/optimization | Status: assigned
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------

Changes (by petraszd):

* needs_better_patch: 1 => 0

Comment:

Updated pull request according to comments in github. And now it also
included setting content_type by using information Pillow provides.

https://github.com/django/django/pull/2972

--
Ticket URL: <https://code.djangoproject.com/ticket/10935#comment:13>

[Django]

#10935: forms.ImageField.clean should annotate the object returned by
FileField.clean
--------------------------------------+------------------------------------
Reporter: jdunck | Owner: petraszd

Type: Cleanup/optimization | Status: closed
Component: Forms | Version: master
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------

Changes (by timo):

* status: assigned => closed
* resolution: => fixed

Comment:

In 8b7347220f3d86b46f5f87270c6cdcb9960895fd:

Fixed #10935 -- Annotated ImageField file with image and content_type
attributes.

Thanks Jeremy Dunck for the suggestion and Nick Sanford for review.

--
Ticket URL: <https://code.djangoproject.com/ticket/10935#comment:14>