Re: [Django] #15220: replace SelectFilter2.js with a jQuery plugin
Django
-------------------------------------+-------------------------------------
Reporter: slurms | Owner: dbunskoek
Type: | Status: new
Cleanup/optimization | Component: contrib.admin
Milestone: | Severity: Normal
Version: SVN | Keywords:
Resolution: | Has patch: 1
Triage Stage: Accepted | Needs tests: 0
Needs documentation: 0 | Easy pickings: 0
Patch needs improvement: 1 |
UI/UX: 1 |
-------------------------------------+-------------------------------------
Changes (by dbunskoek):
* owner: slurms => dbunskoek
* easy: => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/15220#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: slurms | Owner: dbunskoek
Type: | Status: new
Cleanup/optimization | Component: contrib.admin
Milestone: | Severity: Normal
Version: SVN | Keywords:
Resolution: | Has patch: 1
Triage Stage: Accepted | Needs tests: 0
Needs documentation: 0 | Easy pickings: 0
-------------------------------------+-------------------------------------
Changes (by dbunskoek):
* needs_better_patch: 1 => 0
Comment:
I updated the original patch so it will apply cleanly to trunk, and also
made some improvements:
Improved coding-style
* moved from leading spaces to tabs
* removed trailing comma's (fixes IE support)
Usability improvements
* removed inconsistent 'wrap-around' functionality in selects
* also allow moving back from 'selected' to 'choices'
* only allow moving with right or left key when the layout is horizontal
(it doesn't make sense when layout is vertical)
* fixed keyboard shortcuts (didn't work at all in the trunk version)
I tested it all in IE7, IE8, FF4, Safari, Chrome, and it works like a
charm.
--
Ticket URL: <https://code.djangoproject.com/ticket/15220#comment:8>
Django
-------------------------------------+-------------------------------------
Reporter: slurms | Owner: dbunskoek
Type: | Status: new
Cleanup/optimization | Component: contrib.admin
Milestone: | Severity: Normal
Version: SVN | Keywords:
Resolution: | Has patch: 1
Triage Stage: Accepted | Needs tests: 0
Needs documentation: 0 | Easy pickings: 0
Patch needs improvement: 0 |
UI/UX: 1 |
-------------------------------------+-------------------------------------
Comment (by idangazit):
This looks good to me, but I also lack the JS-foo to vet every line of the
JS.
This would be an excellent candidate for figuring out a more standardized
means of testing. Could be QUnit, could be Selenium, could be both. I'd
feel more comfortable with JS changes like these if I had a test suite to
run on them.
--
Ticket URL: <https://code.djangoproject.com/ticket/15220#comment:9>
Django
-------------------------------------+-------------------------------------
Reporter: slurms | Owner: dbunskoek
Type: | Status: new
Component: contrib.admin | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 1
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by jezdez):
FWIW, selenium tests have now landed in the admin, so this should be much
easier to test.
--
Ticket URL: <https://code.djangoproject.com/ticket/15220#comment:10>
Django
-------------------------------------+-------------------------------------
Reporter: slurms | Owner: dbunskoek
Type: | Status: new
Cleanup/optimization | Version: SVN
Component: contrib.admin | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 1
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by julien):
Quick note: some tests were added in r17579.
--
Ticket URL: <https://code.djangoproject.com/ticket/15220#comment:11>
Django
-------------------------------------+-------------------------------------
Reporter: slurms | Owner: dbunskoek
Type: | Status: new
Cleanup/optimization | Version: SVN
Component: contrib.admin | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 1
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by julien):
FYI, while working on #13614, I've used the latest patch from here and
brought it up to date with current trunk.
--
Ticket URL: <https://code.djangoproject.com/ticket/15220#comment:12>
Django
-------------------------------------+-------------------------------------
Reporter: slurms | Owner: dbunskoek
Type: | Status: new
Cleanup/optimization | Version: SVN
Component: contrib.admin | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/15220#comment:13>
Django
-------------------------------------+-------------------------------------
Reporter: slurms | Owner: dbunskoek
Type: | Status: new
Cleanup/optimization | Version: SVN
Component: contrib.admin | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 1
Needs tests: 0 | UI/UX: 1
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by julien):
We'll do this shortly after 1.4 gets released, based on the patch in
#13614.
--
Ticket URL: <https://code.djangoproject.com/ticket/15220#comment:14>
Django
-------------------------------------+-------------------------------------
Reporter: slurms | Owner: dbunskoek
Type: | Status: new
Component: contrib.admin | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 1
Needs tests: 0 | UI/UX: 1
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by timo):
I closed #3202 as a duplicate which points out the inability of the
current implementation to handle large lists. We should make sure new
solution improves this.
--
Ticket URL: <https://code.djangoproject.com/ticket/15220#comment:15>
Django
-------------------------------------+-------------------------------------
Reporter: slurms | Owner: dbunskoek
Type: | Status: new
Cleanup/optimization | Version: master
Component: contrib.admin | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 1
Needs tests: 0 | UI/UX: 1
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* cc: cmawebsite@… (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/15220#comment:16>
Django
-------------------------------------+-------------------------------------
Reporter: slurms | Owner: dbunskoek
Type: | Status: new
Cleanup/optimization |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by benkonrath):
* cc: ben@… (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/15220#comment:17>
Django
-------------------------------------+-------------------------------------
Reporter: slurms | Owner: dbunskoek
Type: | Status: new
Cleanup/optimization |
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Comment (by timgraham):
[https://github.com/django/django/pull/4701 PR 4701] is the latest effort
on this if someone is interested in updating it.
--
Ticket URL: <https://code.djangoproject.com/ticket/15220#comment:18>
Django
-------------------------------------+-------------------------------------
Type: | Status: new
Cleanup/optimization |
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Comment (by Collin Anderson):
This is basically fixed now that we can use select2 for many-to-many
fields. Once it's been around for a while we could try changing UserAdmin
to use select2 by default instead of SelectFilter2.js.
--
Ticket URL: <https://code.djangoproject.com/ticket/15220#comment:19>
Django
Reporter: Nick Sandford | Owner: (none)
Type: Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
Changes (by Mariusz Felisiak):
* owner: dbunskoek => (none)
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/15220#comment:20>
Django
--------------------------------------+------------------------------------
Reporter: Nick Sandford | Owner: (none)
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
--------------------------------------+------------------------------------
Changes (by Mariusz Felisiak):
* status: assigned => new
--
Ticket URL: <https://code.djangoproject.com/ticket/15220#comment:21>
Django
--------------------------------------+------------------------------------
Reporter: Nick Sandford | Owner: (none)
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
--------------------------------------+------------------------------------
* cc: Ülgen Sarıkavak (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/15220#comment:22>
Django
--------------------------------------+------------------------------------
Reporter: Nick Sandford | Owner: (none)
Component: contrib.admin | Version: dev
Severity: Normal | Resolution: wontfix
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
--------------------------------------+------------------------------------
* resolution: => wontfix
* status: new => closed
Comment:
These days (mid-2025) jQuery is not the direction admin is headed to.
Removing it has been the current trajectory for some time.
Digging a bit deeper jQuery was added to this file at some point as it was
later removed in
https://github.com/django/django/commit/c8503562e01a1eba8b227859bcf8965e2e9ea5f8
The underlying reason to rewrite in jQuery as explained on the mailing
list was performance but I'm not sure that's an issue now either. #26561,
for example, aimed to address the key performance issues.
--
Ticket URL: <https://code.djangoproject.com/ticket/15220#comment:23>