[Django] #26452: Remove lazy initialization of middleware

5 views
Skip to first unread message

Django

unread,
Apr 3, 2016, 9:43:07 AM4/3/16
to django-...@googlegroups.com
#26452: Remove lazy initialization of middleware
--------------------------------------+--------------------
Reporter: evansd | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Core (Other) | Version: 1.9
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+--------------------
This was discussed in more detail on
[https://groups.google.com/forum/#!topic/django-developers/iIm7M6aUJmU
django-dev] but, briefly, the reasons for needing lazily initialization of
middleware on first request no longer hold and it makes more sense to do
this on application start up.

The suggestion got +1s from at least two core devs (Aymeric and Florian).

Proposed patch to follow imminently.

--
Ticket URL: <https://code.djangoproject.com/ticket/26452>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Apr 3, 2016, 9:50:22 AM4/3/16
to django-...@googlegroups.com
#26452: Remove lazy initialization of middleware
-------------------------------------+-------------------------------------
Reporter: evansd | Owner: nobody
Type: | Status: new
Cleanup/optimization |

Component: Core (Other) | Version: 1.9
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by evansd):

* needs_docs: => 0
* has_patch: 0 => 1
* needs_tests: => 0
* needs_better_patch: => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/26452#comment:1>

Django

unread,
Apr 4, 2016, 8:20:26 AM4/4/16
to django-...@googlegroups.com
#26452: Load middleware on server start rather than on first request
--------------------------------------+------------------------------------

Reporter: evansd | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: HTTP handling | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by timgraham):

* needs_better_patch: 0 => 1
* component: Core (Other) => HTTP handling
* version: 1.9 => master
* stage: Unreviewed => Accepted


Comment:

Left a few comments for improvement on the
[https://github.com/django/django/pull/6400 PR].

--
Ticket URL: <https://code.djangoproject.com/ticket/26452#comment:2>

Django

unread,
Apr 4, 2016, 10:13:11 AM4/4/16
to django-...@googlegroups.com
#26452: Load middleware on server start rather than on first request
--------------------------------------+------------------------------------
Reporter: evansd | Owner: nobody
Type: Cleanup/optimization | Status: closed

Component: HTTP handling | Version: master
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"99bb7fcc1859615a7b8c2468e7b97d54853bfb10" 99bb7fcc]:
{{{
#!CommitTicketReference repository=""
revision="99bb7fcc1859615a7b8c2468e7b97d54853bfb10"
Fixed #26452 -- Loaded middleware on server start rather than on first
request.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26452#comment:3>

Reply all
Reply to author
Forward
0 new messages