Re: [Django] #13677: ModelFormSet may query wrong database backend
Django
-------------------------------------+-------------------------------------
Reporter: Pierre Chifflier | Owner: David
| Gouldin
Type: Bug | Status: closed
Component: Forms | Version: 1.2
Severity: Normal | Resolution:
| worksforme
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tobias Kunze):
* cc: rixx@… (added)
* needs_better_patch: 1 => 0
* has_patch: 1 => 0
* status: new => closed
* resolution: => worksforme
Comment:
I tried to build a ModelFormSet that uses the alternative database, and as
long as you specify for related objects to use the alternative database,
too, the validation is successful. (If you forget to specify the second
database, it throws a very explicit error stating that this model relation
is not possible).
My test case is avaliable here: https://github.com/rixx/django_ticket13667
- please provide a failing example if you want to reopen this ticket.
--
Ticket URL: <https://code.djangoproject.com/ticket/13677#comment:13>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: Pierre Chifflier | Owner: David
| Gouldin
Type: Bug | Status: closed
Component: Forms | Version: 1.2
Severity: Normal | Resolution:
| worksforme
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tim Graham):
Just to be sure, could you clarify what the mistake is in the test in the
patch attached to the ticket (13677.diff)?
--
Ticket URL: <https://code.djangoproject.com/ticket/13677#comment:14>
Django
-------------------------------------+-------------------------------------
Reporter: Pierre Chifflier | Owner: David
| Gouldin
Component: Forms | Version: 1.2
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: closed => new
* has_patch: 0 => 1
* resolution: worksforme =>
Comment:
I'm sorry: I made a mistake in reproducing the issue and porting the patch
to current Django. After porting the patch I can confirm that the
regression test is valid. I'm not quite sure the implementation is what we
want, but I'll push it and we can discuss the PR.
--
Ticket URL: <https://code.djangoproject.com/ticket/13677#comment:15>
Django
Reporter: Pierre Chifflier | Owner: Tobias Kunze
Type: Bug | Status: assigned
Component: Forms | Version: 1.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tobias Kunze):
* status: new => assigned
* owner: David Gouldin => Tobias Kunze
--
Ticket URL: <https://code.djangoproject.com/ticket/13677#comment:16>
Django
----------------------------------+----------------------------------------
Reporter: Pierre Chifflier | Owner: Tobias Kunze
Type: Bug | Status: assigned
Component: Forms | Version: 1.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+----------------------------------------
* needs_better_patch: 0 => 1
Comment:
I left some comments for improvement on the PR.
--
Ticket URL: <https://code.djangoproject.com/ticket/13677#comment:17>
Django
----------------------------------+----------------------------------------
Reporter: Pierre Chifflier | Owner: Tobias Kunze
Type: Bug | Status: assigned
Component: Forms | Version: 1.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+----------------------------------------
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/13677#comment:18>
Django
----------------------------------+----------------------------------------
Reporter: Pierre Chifflier | Owner: Tobias Kunze
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+----------------------------------------
Changes (by Tobias Kunze):
* version: 1.2 => master
--
Ticket URL: <https://code.djangoproject.com/ticket/13677#comment:19>
Django
----------------------------------+----------------------------------------
Reporter: Pierre Chifflier | Owner: Tobias Kunze
Type: Bug | Status: assigned
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+----------------------------------------
* needs_better_patch: 0 => 1
* needs_tests: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/13677#comment:20>