[Django] #28154: Infinite loop in collectstatic
Django
-----------------------------------------------+------------------------
Reporter: Matthew Somerville | Owner: nobody
Type: Bug | Status: new
Component: contrib.staticfiles | Version: 1.11
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------------+------------------------
If the static directory contains a broken symlink in place of a file that
collectstatic wishes to copy*, then the code gets stuck in an infinite
loop, because the os.open fails (O_CREAT | O_EXCL will fail if a symlink
exists, even if it's to a non-existent file), but then get_available_name
returns the same name (as it calls self.exists, which returns False for a
broken symlink).
I guess two possibilities are:
1. don't care about broken symlinks. Change the flags setting in
django/core/files/storage.py to not include O_EXCL if
`os.path.islink(full_path) and not os.path.exists(full_path)`.
2. do care, change os.path.exists in the `exists` function to use
os.path.lexists instead.
I'm not sure which would be preferable to prevent this infinite loop.
*I came across this issue because collectstatic had been run both inside
and outside a Vagrant box, so symlinks created inside the box did not
exist when collectstatic was then run outside.
--
Ticket URL: <https://code.djangoproject.com/ticket/28154>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+------------------------------------
Reporter: Matthew Somerville | Owner: nobody
Type: Bug | Status: new
Component: contrib.staticfiles | Version: 1.11
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham):
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/28154#comment:1>
Django
-------------------------------------+------------------------------------
Reporter: Matthew Somerville | Owner: nobody
Type: Bug | Status: new
Component: contrib.staticfiles | Version: 1.11
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by KwonHan Bae):
I think its fixed in master branch.
should we backport to 11.x ?
--
Ticket URL: <https://code.djangoproject.com/ticket/28154#comment:2>
Django
-------------------------------------+------------------------------------
Reporter: Matthew Somerville | Owner: nobody
Type: Bug | Status: new
Component: contrib.staticfiles | Version: 1.11
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham):
Which commit fixed it? Most likely a fix wouldn't qualify for a backport
based on our [https://docs.djangoproject.com/en/dev/internals/release-
process/#supported-versions supported versions policy].
--
Ticket URL: <https://code.djangoproject.com/ticket/28154#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: Matthew Somerville | Owner:
| ChillarAnand
Type: Bug | Status: assigned
Component: contrib.staticfiles | Version: 1.11
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by ChillarAnand):
* status: new => assigned
* owner: nobody => ChillarAnand
--
Ticket URL: <https://code.djangoproject.com/ticket/28154#comment:4>
Django
-------------------------------------+-------------------------------------
| Walls
Type: Bug | Status: assigned
Component: contrib.staticfiles | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Jacob Walls):
* owner: ChillarAnand => Jacob Walls
* version: 1.11 => dev
Comment:
Decided to reproduce this on main. Still can.
I'm preparing a tiny patch using the second possibility from the ticket
description: using `os.path.lexists()` in `FileSystemStorage.exists()`.
--
Ticket URL: <https://code.djangoproject.com/ticket/28154#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: Matthew Somerville | Owner: Jacob
| Walls
Type: Bug | Status: assigned
uploads/storage |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Jacob Walls):
* has_patch: 0 => 1
* component: contrib.staticfiles => File uploads/storage
Comment:
I reproduced this outside of contrib.staticfiles by just providing a
broken symlink to `FileSystemStorage.save()` and never exiting a `while`
loop. I'm hoping this is a welcome root cause to look at.
[https://github.com/django/django/pull/14474 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/28154#comment:6>
Django
-------------------------------------+-------------------------------------
Reporter: Matthew Somerville | Owner: Jacob
| Walls
Type: Bug | Status: assigned
Component: File | Version: dev
uploads/storage |
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/28154#comment:7>
Django
-------------------------------------+-------------------------------------
Reporter: Matthew Somerville | Owner: Jacob
| Walls
Component: File | Version: dev
uploads/storage |
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"ec2727efef605437eb572d51ca9afbb3a60eda40" ec2727ef]:
{{{
#!CommitTicketReference repository=""
revision="ec2727efef605437eb572d51ca9afbb3a60eda40"
Fixed #28154 -- Prevented infinite loop in FileSystemStorage.save() when a
broken symlink with the same name exists.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/28154#comment:8>