[Django] #26447: Remove USE_ETAGS setting
Django
--------------------------------------+--------------------
Reporter: syphar | Owner: syphar
Type: Cleanup/optimization | Status: new
Component: Uncategorized | Version: 1.9
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+--------------------
(with deprecation)
In my opinion this setting is not needed (any more)
- Conditional-Get handling can happen in the ConditionalGetMiddleware, not
in CommonMiddleware any more
- using or not using the middleware is (nearly) the same as setting
USE_ETAGS or not
- ETag Calculation can happen also in the middleware
this also will fix a problem when you use the GZipMiddleware in
combination with the Conditional-Get handling in CommonMiddleware.
Open questions for me:
- ConditionalGetMiddleware also handles Last-Modified/If-Modified-Since ,
which CommonMiddleware didn't. I don't see a problem in throwing them
together and activating/deactivating them together. You?
--
Ticket URL: <https://code.djangoproject.com/ticket/26447>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
--------------------------------------+------------------------------------
Reporter: syphar | Owner: syphar
Type: Cleanup/optimization | Status: new
Component: Uncategorized | Version: 1.9
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by syphar):
* needs_better_patch: => 0
* has_patch: 0 => 1
* needs_docs: => 0
* needs_tests: => 0
* stage: Unreviewed => Accepted
Comment:
(after some discussions here at the DjangoCon springs I've just set the
triage state :) )
--
Ticket URL: <https://code.djangoproject.com/ticket/26447#comment:1>
Django
--------------------------------------+------------------------------------
Type: Cleanup/optimization | Status: new
Component: Uncategorized | Version: 1.9
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: 0 => 1
Comment:
Left comments for improvement on the
[https://github.com/django/django/pull/6393 PR].
--
Ticket URL: <https://code.djangoproject.com/ticket/26447#comment:2>
Django
--------------------------------------+------------------------------------
Type: Cleanup/optimization | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Changes (by timgraham):
* component: Uncategorized => HTTP handling
--
Ticket URL: <https://code.djangoproject.com/ticket/26447#comment:3>
Django
unconditionally setting an ETag
--------------------------------------+------------------------------------
Reporter: syphar | Owner: syphar
Type: Cleanup/optimization | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: 1 => 0
Old description:
> (with deprecation)
>
> In my opinion this setting is not needed (any more)
>
> - Conditional-Get handling can happen in the ConditionalGetMiddleware,
> not in CommonMiddleware any more
> - using or not using the middleware is (nearly) the same as setting
> USE_ETAGS or not
> - ETag Calculation can happen also in the middleware
>
> this also will fix a problem when you use the GZipMiddleware in
> combination with the Conditional-Get handling in CommonMiddleware.
>
>
> Open questions for me:
> - ConditionalGetMiddleware also handles Last-Modified/If-Modified-Since ,
> which CommonMiddleware didn't. I don't see a problem in throwing them
> together and activating/deactivating them together. You?
New description:
In my opinion this setting is not needed (any more)
- Conditional-Get handling can happen in the ConditionalGetMiddleware, not
in CommonMiddleware any more
- using or not using the middleware is (nearly) the same as setting
USE_ETAGS or not
- ETag Calculation can happen also in the middleware
this also will fix a problem when you use the GZipMiddleware in
combination with the Conditional-Get handling in CommonMiddleware.
Open questions for me:
- ConditionalGetMiddleware also handles Last-Modified/If-Modified-Since ,
which CommonMiddleware didn't. I don't see a problem in throwing them
together and activating/deactivating them together. You?
--
Comment:
[https://github.com/django/django/pull/7256 Updated PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/26447#comment:4>
Django
unconditionally setting an ETag
Reporter: Denis Cornehl | Owner: Denis
Type: | Cornehl
Cleanup/optimization | Status: new
Component: HTTP handling | Version: 1.9
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Kevin Christopher Henry):
* cc: k@… (added)
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/26447#comment:5>
Django
unconditionally setting an ETag
-------------------------------------+-------------------------------------
Reporter: Denis Cornehl | Owner: Denis
Type: | Cornehl
Component: HTTP handling | Version: 1.9
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"a840710e1e38bc9e55412bb36eca92eff94ebd2c" a840710e]:
{{{
#!CommitTicketReference repository=""
revision="a840710e1e38bc9e55412bb36eca92eff94ebd2c"
Fixed #26447 -- Deprecated settings.USE_ETAGS in favor of
ConditionalGetMiddleware.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/26447#comment:6>
Django
unconditionally setting an ETag
-------------------------------------+-------------------------------------
Reporter: Denis Cornehl | Owner: Denis
Type: | Cornehl
Cleanup/optimization | Status: closed
Component: HTTP handling | Version: 1.9
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"48d57788ee56811fa77cd37b9edf40535f82d87e" 48d5778]:
{{{
#!CommitTicketReference repository=""
revision="48d57788ee56811fa77cd37b9edf40535f82d87e"
Refs #26447 -- Removed the USE_ETAGS setting per deprecation timeline.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/26447#comment:7>
Django
unconditionally setting an ETag
-------------------------------------+-------------------------------------
Reporter: Denis Cornehl | Owner: Denis
Type: | Cornehl
Cleanup/optimization | Status: closed
Component: HTTP handling | Version: 1.9
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"8f8a4d10d34c1fd6104b08efd16c5c377c142865" 8f8a4d1]:
{{{
#!CommitTicketReference repository=""
revision="8f8a4d10d34c1fd6104b08efd16c5c377c142865"
Refs #26447 -- Removed outdated ETag comment in CommonMiddleware.
Follow up to 48d57788ee56811fa77cd37b9edf40535f82d87e.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/26447#comment:8>