--
Ticket URL: <https://code.djangoproject.com/ticket/24672>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Comment:
Discussion
[https://github.com/django/django/commit/92b5341b19e9b35083ee671afc2afb2f252c662d#commitcomment-1936761
here]. I don't know if Django might add some features for it in the
future, but does the current note cause any harm?
--
Ticket URL: <https://code.djangoproject.com/ticket/24672#comment:1>
Comment (by int-ua):
Unnecessary action that takes time and causes confusion.
It's so obvious to me that I can't even find the words to explain it. Why
would you need a useless action in a tutorial? Adding the note
_afterwards_ just causes a "what." reaction.
--
Ticket URL: <https://code.djangoproject.com/ticket/24672#comment:2>
* type: Uncategorized => Cleanup/optimization
--
Ticket URL: <https://code.djangoproject.com/ticket/24672#comment:3>
Comment (by claudep):
What about this:
{{{
#!diff
diff --git a/docs/ref/contrib/gis/install/postgis.txt
b/docs/ref/contrib/gis/install/postgis.txt
index 74c688f..c31ac71 100644
--- a/docs/ref/contrib/gis/install/postgis.txt
+++ b/docs/ref/contrib/gis/install/postgis.txt
@@ -63,10 +63,13 @@ spatial functionality::
$ createdb <db name>
$ psql <db name>
> CREATE EXTENSION postgis;
- > CREATE EXTENSION postgis_topology;
-No PostGIS topology functionalities are yet available from GeoDjango, so
the
-creation of the ``postgis_topology`` extension is entirely optional.
+GeoDjango itself does currently not leverage any of the `PostGIS topology
+functionalities`__, but if you plan to use them at some point you can
also
+install the ``postgis_topology`` extension by issuing ``CREATE EXTENSION
+postgis_topology;``.
+
+__ http://postgis.net/docs/Topology.html
.. versionchanged:: 1.8
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24672#comment:4>
Comment (by int-ua):
Looks great to me.
--
Ticket URL: <https://code.djangoproject.com/ticket/24672#comment:5>
* stage: Unreviewed => Ready for checkin
Comment:
Suggestion to simplify the wording a bit: "GeoDjango does not currently
leverage any PostGIS topology functionality. If you plan to use those
features at some point, you can also ..."
--
Ticket URL: <https://code.djangoproject.com/ticket/24672#comment:6>
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"6e8cb75e3edef1ed440e29c31966c44cc1598339" 6e8cb75e]:
{{{
#!CommitTicketReference repository=""
revision="6e8cb75e3edef1ed440e29c31966c44cc1598339"
Fixed #24672 -- Clarified note about installing postgis_topology
Thanks Serhiy Zahoriya for the suggestion and Tim Graham for the
review.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24672#comment:7>
Comment (by Claude Paroz <claude@…>):
In [changeset:"99bf9085a3c3bc54152b49e1e2ebec077daf54cf" 99bf908]:
{{{
#!CommitTicketReference repository=""
revision="99bf9085a3c3bc54152b49e1e2ebec077daf54cf"
[1.8.x] Fixed #24672 -- Clarified note about installing postgis_topology
Thanks Serhiy Zahoriya for the suggestion and Tim Graham for the
review.
Backport of 6e8cb75e3e from master.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24672#comment:8>