[Django] #24672: Remove postgis_topology creation from PostGIS install page

22 views
Skip to first unread message

Django

unread,
Apr 20, 2015, 11:36:57 AM4/20/15
to django-...@googlegroups.com
#24672: Remove postgis_topology creation from PostGIS install page
-------------------------------+--------------------
Reporter: int-ua | Owner: nobody
Type: Uncategorized | Status: new
Component: Documentation | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------+--------------------
Why include "CREATE EXTENSION postgis_topology;" in
https://docs.djangoproject.com/en/dev/ref/contrib/gis/install/postgis/ if
it's useless for Django anyway?

--
Ticket URL: <https://code.djangoproject.com/ticket/24672>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Apr 20, 2015, 11:43:28 AM4/20/15
to django-...@googlegroups.com
#24672: Remove postgis_topology creation from PostGIS install page
-------------------------------+--------------------------------------

Reporter: int-ua | Owner: nobody
Type: Uncategorized | Status: new
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------+--------------------------------------
Changes (by timgraham):

* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0


Comment:

Discussion
[https://github.com/django/django/commit/92b5341b19e9b35083ee671afc2afb2f252c662d#commitcomment-1936761
here]. I don't know if Django might add some features for it in the
future, but does the current note cause any harm?

--
Ticket URL: <https://code.djangoproject.com/ticket/24672#comment:1>

Django

unread,
Apr 20, 2015, 3:36:32 PM4/20/15
to django-...@googlegroups.com
#24672: Remove postgis_topology creation from PostGIS install page
-------------------------------+--------------------------------------

Reporter: int-ua | Owner: nobody
Type: Uncategorized | Status: new
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------+--------------------------------------

Comment (by int-ua):

Unnecessary action that takes time and causes confusion.
It's so obvious to me that I can't even find the words to explain it. Why
would you need a useless action in a tutorial? Adding the note
_afterwards_ just causes a "what." reaction.

--
Ticket URL: <https://code.djangoproject.com/ticket/24672#comment:2>

Django

unread,
Apr 20, 2015, 3:37:53 PM4/20/15
to django-...@googlegroups.com
#24672: Remove postgis_topology creation from PostGIS install page
-------------------------------------+-------------------------------------
Reporter: int-ua | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by int-ua):

* type: Uncategorized => Cleanup/optimization


--
Ticket URL: <https://code.djangoproject.com/ticket/24672#comment:3>

Django

unread,
Apr 21, 2015, 3:19:22 AM4/21/15
to django-...@googlegroups.com
#24672: Remove postgis_topology creation from PostGIS install page
-------------------------------------+-------------------------------------
Reporter: int-ua | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by claudep):

What about this:
{{{
#!diff
diff --git a/docs/ref/contrib/gis/install/postgis.txt
b/docs/ref/contrib/gis/install/postgis.txt
index 74c688f..c31ac71 100644
--- a/docs/ref/contrib/gis/install/postgis.txt
+++ b/docs/ref/contrib/gis/install/postgis.txt
@@ -63,10 +63,13 @@ spatial functionality::
$ createdb <db name>
$ psql <db name>
> CREATE EXTENSION postgis;
- > CREATE EXTENSION postgis_topology;

-No PostGIS topology functionalities are yet available from GeoDjango, so
the
-creation of the ``postgis_topology`` extension is entirely optional.
+GeoDjango itself does currently not leverage any of the `PostGIS topology
+functionalities`__, but if you plan to use them at some point you can
also
+install the ``postgis_topology`` extension by issuing ``CREATE EXTENSION
+postgis_topology;``.
+
+__ http://postgis.net/docs/Topology.html

.. versionchanged:: 1.8

}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/24672#comment:4>

Django

unread,
Apr 21, 2015, 6:18:54 AM4/21/15
to django-...@googlegroups.com
#24672: Remove postgis_topology creation from PostGIS install page
-------------------------------------+-------------------------------------
Reporter: int-ua | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by int-ua):

Looks great to me.

--
Ticket URL: <https://code.djangoproject.com/ticket/24672#comment:5>

Django

unread,
Apr 21, 2015, 6:35:57 AM4/21/15
to django-...@googlegroups.com
#24672: Remove postgis_topology creation from PostGIS install page
-------------------------------------+-------------------------------------
Reporter: int-ua | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* stage: Unreviewed => Ready for checkin


Comment:

Suggestion to simplify the wording a bit: "GeoDjango does not currently
leverage any PostGIS topology functionality. If you plan to use those
features at some point, you can also ..."

--
Ticket URL: <https://code.djangoproject.com/ticket/24672#comment:6>

Django

unread,
Apr 21, 2015, 11:57:13 AM4/21/15
to django-...@googlegroups.com
#24672: Remove postgis_topology creation from PostGIS install page
-------------------------------------+-------------------------------------
Reporter: int-ua | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Documentation | Version: master
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Claude Paroz <claude@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"6e8cb75e3edef1ed440e29c31966c44cc1598339" 6e8cb75e]:
{{{
#!CommitTicketReference repository=""
revision="6e8cb75e3edef1ed440e29c31966c44cc1598339"
Fixed #24672 -- Clarified note about installing postgis_topology

Thanks Serhiy Zahoriya for the suggestion and Tim Graham for the
review.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/24672#comment:7>

Django

unread,
Apr 21, 2015, 11:58:03 AM4/21/15
to django-...@googlegroups.com
#24672: Remove postgis_topology creation from PostGIS install page
-------------------------------------+-------------------------------------
Reporter: int-ua | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Documentation | Version: master

Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Claude Paroz <claude@…>):

In [changeset:"99bf9085a3c3bc54152b49e1e2ebec077daf54cf" 99bf908]:
{{{
#!CommitTicketReference repository=""
revision="99bf9085a3c3bc54152b49e1e2ebec077daf54cf"
[1.8.x] Fixed #24672 -- Clarified note about installing postgis_topology

Thanks Serhiy Zahoriya for the suggestion and Tim Graham for the
review.

Backport of 6e8cb75e3e from master.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/24672#comment:8>

Reply all
Reply to author
Forward
0 new messages