[Django] #27952: core.validators.validate_slug doesn't mention that only latin letters are accepted.
Django
accepted.
------------------------------------------------+------------------------
Reporter: Serhiy Zahoriya | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Core (Other) | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 1 |
------------------------------------------------+------------------------
Just adding "latin" to
{{{
"Enter a valid 'slug' consisting of letters, numbers, underscores or
hyphens."
}}}
from
https://github.com/django/django/blob/66bbde6819586cc3a75630e12e569dc8ae72f211/django/core/validators.py#L237
will fix this.
--
Ticket URL: <https://code.djangoproject.com/ticket/27952>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
accepted.
Reporter: Serhiy Zahoriya | Owner: nobody
Cleanup/optimization |
Component: Core (Other) | Version: master
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Old description:
> Just adding "latin" to
>
> {{{
> "Enter a valid 'slug' consisting of letters, numbers, underscores or
> hyphens."
> }}}
> from
> https://github.com/django/django/blob/66bbde6819586cc3a75630e12e569dc8ae72f211/django/core/validators.py#L237
> will fix this.
New description:
Just adding "latin" to
{{{
"Enter a valid 'slug' consisting of letters, numbers, underscores or
hyphens."
}}}
from
https://github.com/django/django/blob/66bbde6819586cc3a75630e12e569dc8ae72f211/django/core/validators.py#L237
will fix this.
--
Comment (by Tim Graham):
I'm not sure about the suggested wording. At least for English speakers, I
think "letters" is less confusing than "latin letters".
--
Ticket URL: <https://code.djangoproject.com/ticket/27952#comment:1>
Django
accepted.
Reporter: Serhiy Zahoriya | Owner: nobody
Cleanup/optimization |
Component: Core (Other) | Version: master
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Comment (by Serhiy Zahoriya):
It could be fixed in translations only, yes. Maybe a note to translators?
In current state translators and users have no hint that it's only Latin
letters. Cyrillic and other completely different alphabets aside, I guess
this regex doesn't even include German umlauts, isn't it?
--
Ticket URL: <https://code.djangoproject.com/ticket/27952#comment:2>
Django
accepted.
Reporter: Serhiy Zahoriya | Owner: nobody
Cleanup/optimization |
Component: Core (Other) | Version: master
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Comment (by Paul Sajna):
What about ASCII letters?
--
Ticket URL: <https://code.djangoproject.com/ticket/27952#comment:3>
Django
accepted.
Reporter: Serhiy Zahoriya | Owner: Paul
Type: | Sajna
Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: master
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Changes (by Paul Sajna):
* owner: nobody => Paul Sajna
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/27952#comment:4>
Django
accepted.
Reporter: Serhiy Zahoriya | Owner: Paul
Type: | Sajna
Cleanup/optimization | Status: assigned
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Changes (by Paul Sajna):
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/27952#comment:5>
Django
accepted.
Reporter: Serhiy Zahoriya | Owner: Paul
Type: | Sajna
Cleanup/optimization | Status: assigned
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Comment (by Paul Sajna):
https://github.com/django/django/pull/8207
--
Ticket URL: <https://code.djangoproject.com/ticket/27952#comment:6>
Django
accepted.
Reporter: Serhiy Zahoriya | Owner: Paul
Type: | Sajna
Cleanup/optimization | Status: assigned
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Comment (by Tim Graham):
I doubt many non-technical users know what ASCII is.
--
Ticket URL: <https://code.djangoproject.com/ticket/27952#comment:7>
Django
accepted.
Reporter: Serhiy Zahoriya | Owner: Paul
Type: | Sajna
Cleanup/optimization | Status: assigned
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Changes (by Tim Graham):
* has_patch: 1 => 0
* stage: Unreviewed => Accepted
Comment:
A hint to translators may be best, but I'm not sure how that works.
Someone could start a thread on the DevelopersMailingList to propose
another solution.
--
Ticket URL: <https://code.djangoproject.com/ticket/27952#comment:8>
Django
accepted.
Reporter: Serhiy Zahoriya | Owner: Paul
Type: | Sajna
Cleanup/optimization | Status: assigned
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):
* easy: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/27952#comment:9>
Django
accepted.
Reporter: Serhiy Zahoriya | Owner: (none)
Type: Cleanup/optimization | Status: new
Component: Core (Other) | Version: master
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
--------------------------------------+------------------------------------
Changes (by Paul Sajna):
* owner: Paul Sajna => (none)
* status: assigned => new
--
Ticket URL: <https://code.djangoproject.com/ticket/27952#comment:10>
Django
accepted.
Reporter: Serhiy Zahoriya | Owner: (none)
Component: Core (Other) | Version: master
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
--------------------------------------+------------------------------------
Comment (by Serhiy Zahoriya):
Hinting translators with
https://docs.djangoproject.com/en/1.10/topics/i18n/translation/#comments-
for-translators looks best to me too. Paul, would you like to do it?
--
Ticket URL: <https://code.djangoproject.com/ticket/27952#comment:11>
Django
accepted.
Reporter: Serhiy Zahoriya | Owner: (none)
Component: Core (Other) | Version: master
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Changes (by Serhiy Zahoriya):
* easy: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/27952#comment:12>
Django
accepted.
Reporter: Serhiy Zahoriya | Owner: Doctor163
Type: | Status: assigned
Cleanup/optimization |
Component: Core (Other) | Version: master
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Changes (by Doctor163):
* status: new => assigned
* owner: (none) => Doctor163
--
Ticket URL: <https://code.djangoproject.com/ticket/27952#comment:12>
Django
accepted.
Reporter: Serhiy Zahoriya | Owner: (none)
Component: Core (Other) | Version: master
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Changes (by Doctor163):
* owner: Doctor163 => (none)
* status: assigned => new
--
Ticket URL: <https://code.djangoproject.com/ticket/27952#comment:13>
Django
accepted.
Reporter: Serhiy Zahoriya | Owner: Paul
Type: | Sajna
Cleanup/optimization | Status: assigned
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Changes (by Paul Sajna):
* status: new => assigned
* owner: (none) => Paul Sajna
--
Ticket URL: <https://code.djangoproject.com/ticket/27952#comment:14>
Django
accepted.
Reporter: Serhiy Zahoriya | Owner: Paul
Type: | Sajna
Cleanup/optimization | Status: assigned
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Changes (by Paul Sajna):
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/8236 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/27952#comment:15>
Django
accepted.
Reporter: Serhiy Zahoriya | Owner: Paul
Type: | Sajna
Component: Core (Other) | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"001cf53280f7e2b72199237f37c340d2639fe143" 001cf53]:
{{{
#!CommitTicketReference repository=""
revision="001cf53280f7e2b72199237f37c340d2639fe143"
Fixed #27952 -- Added translation hint for RegexValidator error message.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27952#comment:16>