[Django] #20678: Broken link for downloading docs as HTML
Django
-------------------------------------+--------------------
Reporter: jennyd | Owner: nobody
Type: Bug | Status: new
Component: *.djangoproject.com | Version: 1.5
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+--------------------
The link to download the full docs as HTML at the bottom of the sidebar on
many pages on docs.djangoproject.com is given as e.g.
https://docs.djangoproject.com/s/docs/django-docs-1.5-en.7b52b2b9085f.zip
but should be https://docs.djangoproject.com/s/docs/django-docs-1.5-en.zip
- this applies to the links for all versions of Django.
--
Ticket URL: <https://code.djangoproject.com/ticket/20678>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: jennyd | Owner: nobody
Type: Bug | Status: new
Component: *.djangoproject.com | Version: 1.5
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by bmispelon):
* needs_better_patch: => 0
* stage: Unreviewed => Accepted
* needs_tests: => 0
* needs_docs: => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/20678#comment:1>
Django
Reporter: jennyd | Owner: nobody
Type: Bug | Status: new
Component: *.djangoproject.com | Version: 1.5
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Comment (by claudep):
This is an artifact of the `static` template tag, introduced in
https://github.com/django/djangoproject.com/commit/89b5cc54cbd1ad4ea512428197d1b788bfc3547a
--
Ticket URL: <https://code.djangoproject.com/ticket/20678#comment:2>
Django
Reporter: jennyd | Owner: nobody
Type: Bug | Status: new
Component: *.djangoproject.com | Version: 1.5
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Comment (by bmispelon):
This issue was introduced with commit
https://github.com/django/djangoproject.com/commit/89b5cc54cbd1ad4ea512428197d1b788bfc3547a
that switched the site to using `CachedStaticFilesStorage`.
Unfortunately, the code that generates thoses zip files (the `update_docs`
command) is not using the staticfiles machinery, which broke the download
links.
I see two solutions:
1) Revert the download link to use `{{ STATIC_ROOT }}` instead of `{%
static %}`.
2) Change the `update_docs` command to make use of the staticfiles
infrastructure (or at least generate a compatible filename).
I think 2) might be the better option, but after looking into it a bit, I
found it tricky to implement.
--
Ticket URL: <https://code.djangoproject.com/ticket/20678#comment:3>
Django
Reporter: jennyd | Owner: nobody
Type: Bug | Status: new
Component: *.djangoproject.com | Version: 1.5
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Comment (by aaugustin):
It could be more appropriate to treat the docs zip archives as media
files.
There're a media attached to a DocumentRelease object.
--
Ticket URL: <https://code.djangoproject.com/ticket/20678#comment:4>
Django
Reporter: jennyd | Owner: jezdez
Type: Bug | Status: assigned
Component: *.djangoproject.com | Version: 1.5
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Changes (by jezdez):
* status: new => assigned
* owner: nobody => jezdez
--
Ticket URL: <https://code.djangoproject.com/ticket/20678#comment:5>
Django
Reporter: jennyd | Owner: jezdez
Component: *.djangoproject.com | Version: 1.5
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Jannis Leidel <jannis@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In
[changeset:"cbe6e5bf02563b0a9332361897f1ebd350a9fa11/djangoproject.com"]:
{{{
#!CommitTicketReference repository="djangoproject.com"
revision="cbe6e5bf02563b0a9332361897f1ebd350a9fa11"
Fixed #20678 - Refer to the zip file correctly. Fixes a regression
introduced in 89b5cc54cbd1ad4ea512428197d1b788bfc3547a and
89b5cc54cbd1ad4ea512428197d1b788bfc3547a.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/20678#comment:6>
Django
Reporter: jennyd | Owner: jezdez
Type: Bug | Status: closed
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Comment (by jezdez):
FTR I agree with aaugustin, the download is a "media" IMO.
--
Ticket URL: <https://code.djangoproject.com/ticket/20678#comment:7>