[Django] #24933: Make FormSet management forms optional

10 views
Skip to first unread message

Django

unread,
Jun 5, 2015, 6:44:00 AM6/5/15
to django-...@googlegroups.com
#24933: Make FormSet management forms optional
-------------------------------+--------------------
Reporter: patrys | Owner: nobody
Type: Uncategorized | Status: new
Component: Forms | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------
They are only required if the form class used consists of nothing but
checkbox fields. Dealing with management forms makes it unnecessarily hard
to dynamically alter the list of forms in front-end and forgetting to
render one will result in the `FormSet.__init__()` raising an exception.

I've submitted a discussion to the mailing list but I'm creating a ticket
here to provide a pull request for people to play with to make an informed
decision.

--
Ticket URL: <https://code.djangoproject.com/ticket/24933>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jun 5, 2015, 6:47:27 AM6/5/15
to django-...@googlegroups.com
#24933: Make FormSet management forms optional
-------------------------------+--------------------------------------

Reporter: patrys | Owner: nobody
Type: Uncategorized | Status: new
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------------------------
Changes (by patrys):

* needs_docs: => 0
* has_patch: 0 => 1
* needs_tests: => 0
* needs_better_patch: => 0


Comment:

Pull request: https://github.com/django/django/pull/4797

--
Ticket URL: <https://code.djangoproject.com/ticket/24933#comment:1>

Django

unread,
Jun 9, 2015, 2:28:59 PM6/9/15
to django-...@googlegroups.com
#24933: Make FormSet management forms optional
-------------------------------+--------------------------------------

Reporter: patrys | Owner: nobody
Type: Uncategorized | Status: new
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------------------------
Description changed by timgraham:

Old description:

> They are only required if the form class used consists of nothing but
> checkbox fields. Dealing with management forms makes it unnecessarily
> hard to dynamically alter the list of forms in front-end and forgetting
> to render one will result in the `FormSet.__init__()` raising an
> exception.
>
> I've submitted a discussion to the mailing list but I'm creating a ticket
> here to provide a pull request for people to play with to make an
> informed decision.

New description:

They are only required if the form class used consists of nothing but
checkbox fields. Dealing with management forms makes it unnecessarily hard
to dynamically alter the list of forms in front-end and forgetting to
render one will result in the `FormSet.__init__()` raising an exception.

I've [https://groups.google.com/d/topic/django-developers/skbT_7b-
uFY/discussion submitted a discussion to the mailing list] but I'm


creating a ticket here to provide a pull request for people to play with
to make an informed decision.

--

--
Ticket URL: <https://code.djangoproject.com/ticket/24933#comment:2>

Django

unread,
Jun 10, 2015, 11:26:03 AM6/10/15
to django-...@googlegroups.com
#24933: Make FormSet management forms optional
--------------------------------------+------------------------------------
Reporter: patrys | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by timgraham):

* needs_better_patch: 0 => 1
* type: Uncategorized => Cleanup/optimization
* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/24933#comment:3>

Reply all
Reply to author
Forward
0 new messages