[Django] #24935: refactor conditional GET handling
Django
--------------------------------------+--------------------
Reporter: syphar | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: HTTP handling | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+--------------------
Django has currently three different places where conditional GET is
handled
- `ConditionalGetMiddleware`
- `@condition` (and so `@etag` and `last_modified`) decorators
- `CommonMiddleware`
they all do it differently.
I want to refactor this into the same shared behavior.
This is a starting point to fix some related tickets and (most likely)
deprecate and remove `settings.USE_ETAGS`
--
Ticket URL: <https://code.djangoproject.com/ticket/24935>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: syphar | Owner: syphar
Type: | Status: assigned
Cleanup/optimization |
Component: HTTP handling | Version: master
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by syphar):
* status: new => assigned
* needs_better_patch: => 0
* needs_tests: => 0
* owner: nobody => syphar
* needs_docs: => 0
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/24935#comment:1>
Django
Reporter: syphar | Owner: syphar
Type: Cleanup/optimization | Status: assigned
Component: HTTP handling | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/24935#comment:2>
Django
Reporter: syphar | Owner: syphar
Type: Cleanup/optimization | Status: assigned
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: 0 => 1
Comment:
Feedback left on [https://github.com/django/django/pull/4804 the pull
request].
--
Ticket URL: <https://code.djangoproject.com/ticket/24935#comment:3>
Django
Reporter: syphar | Owner: syphar
Component: HTTP handling | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"7a40fef17ab7918cbb1ddc3ba080f42b420f7a48" 7a40fef]:
{{{
#!CommitTicketReference repository=""
revision="7a40fef17ab7918cbb1ddc3ba080f42b420f7a48"
Fixed #24935 -- Refactored common conditional GET handling.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24935#comment:4>