[Django] #25735: Add test tagging to Django test runner
Django
---------------------------------------------+------------------------
Reporter: carljm | Owner: nobody
Type: New feature | Status: new
Component: Testing framework | Version: 1.8
Severity: Normal | Keywords:
Triage Stage: Ready for checkin | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
---------------------------------------------+------------------------
This idea has come up multiple times in the last few years, most recently
in the discussion of #25653.
A pull request for it already exists:
https://github.com/django/django/pull/5585
--
Ticket URL: <https://code.djangoproject.com/ticket/25735>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: carljm | Owner: nobody
Type: New feature | Status: new
Component: Testing framework | Version: 1.8
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by carljm):
* stage: Ready for checkin => Accepted
Comment:
There is perhaps one other design decision we should at least consider
before this is merged. The current implementation filters out tests that
are de-selected by tags from the test suite, so it will be as if those
tests weren't discovered at all. Is that what we want, or would it be
better if de-selected tags were skipped using the unittest test-skipping
functionality?
I haven't investigated feasibility of the latter, but I think it should be
possible if we prefer it.
--
Ticket URL: <https://code.djangoproject.com/ticket/25735#comment:1>
Django
Reporter: carljm | Owner: nobody
Type: New feature | Status: new
Component: Testing framework | Version: 1.8
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by carljm):
* stage: Accepted => Ready for checkin
Comment:
I think we should go ahead with this as-is, and if it turns out in
practice skipping would be better, that can be done as a follow-up
improvement.
--
Ticket URL: <https://code.djangoproject.com/ticket/25735#comment:2>
Django
Reporter: carljm | Owner: mrbox
Type: New feature | Status: assigned
Component: Testing framework | Version: 1.8
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by mrbox):
* status: new => assigned
* owner: nobody => mrbox
* cc: jakub@… (added)
Comment:
And PR is here: https://github.com/django/django/pull/5585
--
Ticket URL: <https://code.djangoproject.com/ticket/25735#comment:3>
Django
Reporter: carljm | Owner: mrbox
Type: New feature | Status: assigned
Keywords: | Triage Stage: Accepted
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: 0 => 1
* stage: Ready for checkin => Accepted
Comment:
Left comments for improvement.
--
Ticket URL: <https://code.djangoproject.com/ticket/25735#comment:4>
Django
Reporter: carljm | Owner: mrbox
Type: New feature | Status: assigned
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: 1 => 0
Comment:
[https://github.com/django/django/pull/6138 Updated PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/25735#comment:5>
Django
Reporter: carljm | Owner: mrbox
Component: Testing framework | Version: 1.8
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"d4dc775620fc57e962165eab98a77264e3dd16b2" d4dc775]:
{{{
#!CommitTicketReference repository=""
revision="d4dc775620fc57e962165eab98a77264e3dd16b2"
Fixed #25735 -- Added support for test tags to DiscoverRunner.
Thanks Carl Meyer, Claude Paroz, and Simon Charette for review.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25735#comment:6>
Django
Reporter: carljm | Owner: mrbox
Type: New feature | Status: closed
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"032f5a789692d69ab206f902867ff2c3e05c5320" 032f5a78]:
{{{
#!CommitTicketReference repository=""
revision="032f5a789692d69ab206f902867ff2c3e05c5320"
Refs #25735 -- Made @tag decorator importable from django.test.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25735#comment:7>
Django
Reporter: Carl Meyer | Owner: Jakub
| Paczkowski
Type: New feature | Status: closed
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"37044817f9a57126d655f216019e8c8cca7c151b" 3704481]:
{{{
#!CommitTicketReference repository=""
revision="37044817f9a57126d655f216019e8c8cca7c151b"
Refs #25735 -- Added tags/exclude_tags arguments to DiscoverRunner docs.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25735#comment:8>
Django
Reporter: Carl Meyer | Owner: Jakub
| Paczkowski
Type: New feature | Status: closed
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"8298775dad2a9e4f7c48829b212b32e542f51c69" 8298775d]:
{{{
#!CommitTicketReference repository=""
revision="8298775dad2a9e4f7c48829b212b32e542f51c69"
[3.2.x] Refs #25735 -- Added tags/exclude_tags arguments to DiscoverRunner
docs.
Backport of 37044817f9a57126d655f216019e8c8cca7c151b from main
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25735#comment:9>
Django
Reporter: Carl Meyer | Owner: Jakub
| Paczkowski
Type: New feature | Status: closed
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"11d241dcf78842764fc3d0feac1a0b2bd78aa398" 11d241dc]:
{{{
#!CommitTicketReference repository=""
revision="11d241dcf78842764fc3d0feac1a0b2bd78aa398"
[3.1.x] Refs #25735 -- Added tags/exclude_tags arguments to DiscoverRunner
docs.
Backport of 37044817f9a57126d655f216019e8c8cca7c151b from main.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25735#comment:10>