--
Ticket URL: <https://code.djangoproject.com/ticket/25809>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Comment:
Do you have a proposed API?
--
Ticket URL: <https://code.djangoproject.com/ticket/25809#comment:1>
Comment (by auvipy):
Replying to [comment:1 timgraham]:
> Do you have a proposed API?
not till now, but should be based on Class based Index Dep?
--
Ticket URL: <https://code.djangoproject.com/ticket/25809#comment:2>
* stage: Unreviewed => Someday/Maybe
Comment:
I'd guess so.
--
Ticket URL: <https://code.djangoproject.com/ticket/25809#comment:3>
* stage: Someday/Maybe => Accepted
Comment:
This can likely move forward now that the framework for class-based
indexes is in master.
--
Ticket URL: <https://code.djangoproject.com/ticket/25809#comment:4>
Comment (by auvipy):
Replying to [comment:4 timgraham]:
> This can likely move forward now that the framework for class-based
indexes is in master.
exactly. will this be part of gsoc?
--
Ticket URL: <https://code.djangoproject.com/ticket/25809#comment:5>
* keywords: => postgres, index, BRIN
--
Ticket URL: <https://code.djangoproject.com/ticket/25809#comment:6>
* needs_better_patch: 0 => 1
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/25809#comment:7>
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/25809#comment:8>
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/25809#comment:9>
* owner: (none) => Mads Jensen
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/25809#comment:8>
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/25809#comment:9>
* needs_better_patch: 1 => 0
Comment:
Updated according to review by Tim Graham. It's tricky finding a good
```sql_create_index``` that suits all backends, as the current design
requires. My solution just introduces a new one, and uses this in the
```as_sql```-method.
--
Ticket URL: <https://code.djangoproject.com/ticket/25809#comment:9>
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/25809#comment:10>
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"e585c43be91fb3e5005ddb4191f64142c62a2ec3" e585c43b]:
{{{
#!CommitTicketReference repository=""
revision="e585c43be91fb3e5005ddb4191f64142c62a2ec3"
Fixed #25809 -- Added BrinIndex support in django.contrib.postgres.
Thanks Tim Graham and Markus Holtermann for review.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25809#comment:11>
* keywords: postgres, index, BRIN => postgres, index, BRIN, db-indexes
--
Ticket URL: <https://code.djangoproject.com/ticket/25809#comment:12>
Comment (by Markus Holtermann <info@…>):
In [changeset:"7e299c0e03a52052068db5108de97cf59174bfd9" 7e299c0]:
{{{
#!CommitTicketReference repository=""
revision="7e299c0e03a52052068db5108de97cf59174bfd9"
Refs #25809 -- Prefered imports from django.db.models.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25809#comment:13>
Comment (by Tim Graham <timograham@…>):
In [changeset:"65e321b78161d83db408504290edbfbace267233" 65e321b7]:
{{{
#!CommitTicketReference repository=""
revision="65e321b78161d83db408504290edbfbace267233"
Refs #25809 -- Made a few late review comments for BrinIndex.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25809#comment:14>
Comment (by GitHub <noreply@…>):
In [changeset:"d1d73480019fc3754b335878be07f00b5321a065" d1d7348]:
{{{
#!CommitTicketReference repository=""
revision="d1d73480019fc3754b335878be07f00b5321a065"
Refs #25809 -- Removed BrinIndex.__repr__().
In retrospect, implementing a __repr__() for index subclasses doesn't
seem worthwhile.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25809#comment:15>
Comment (by Tim Graham <timograham@…>):
In [changeset:"fb42d0247136249ea81962474e9a6a2faf1755f1" fb42d024]:
{{{
#!CommitTicketReference repository=""
revision="fb42d0247136249ea81962474e9a6a2faf1755f1"
Refs #25809 -- Omitted pages_per_range from BrinIndex.deconstruct() if
it's None.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25809#comment:16>
Comment (by Tim Graham <timograham@…>):
In [changeset:"c685b8f838f7f9411a2a65fba7e3893f15439e18" c685b8f8]:
{{{
#!CommitTicketReference repository=""
revision="c685b8f838f7f9411a2a65fba7e3893f15439e18"
[1.11.x] Refs #25809 -- Omitted pages_per_range from
BrinIndex.deconstruct() if it's None.
Backport of fb42d0247136249ea81962474e9a6a2faf1755f1 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25809#comment:17>
Comment (by Tim Graham <timograham@…>):
In [changeset:"ff9543b351e79de78e7867f255ad15e51555ba4a" ff9543b]:
{{{
#!CommitTicketReference repository=""
revision="ff9543b351e79de78e7867f255ad15e51555ba4a"
Refs #25809, #28990 -- Added PostgreSQL version check for BrinIndex
support.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25809#comment:18>