Re: [Django] #10190: Charset should be customizable with HttpResponse
Django
-------------------------------------+-------------------------------------
Reporter: Wonlay | Owner: aaugustin
Type: New feature | Status: new
Component: HTTP handling | Version: master
Severity: Normal | Resolution:
Keywords: HttpResponse, | Triage Stage: Fixed on
charset, runtime | a branch
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by aaugustin):
* owner: ccahoon => aaugustin
--
Ticket URL: <https://code.djangoproject.com/ticket/10190#comment:19>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: Wonlay | Owner: aaugustin
Component: HTTP handling | Version: master
Severity: Normal | Resolution:
Keywords: HttpResponse, | Triage Stage: Fixed on
charset, runtime | a branch
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by aaugustin):
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/10190#comment:20>
Django
-------------------------------------+-------------------------------------
Reporter: Wonlay | Owner:
Severity: Normal | Resolution:
Keywords: HttpResponse, | Triage Stage: Fixed on
charset, runtime | a branch
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by aaugustin):
* status: assigned => new
* owner: aaugustin =>
--
Ticket URL: <https://code.djangoproject.com/ticket/10190#comment:21>
Django
-------------------------------------+-------------------------------------
Reporter: Wonlay | Owner:
Component: HTTP handling | Status: assigned
Severity: Normal | Version: master
Keywords: HttpResponse, | Resolution:
charset, runtime | Triage Stage: Fixed on
Has patch: 1 | a branch
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by unaizalakain):
* owner: => unaizalakain
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/10190#comment:22>
Django
-------------------------------------+-------------------------------------
Reporter: Wonlay | Owner:
Type: New feature | unaizalakain
Component: HTTP handling | Status: assigned
Severity: Normal | Version: master
Keywords: HttpResponse, | Resolution:
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by unaizalakain):
* stage: Fixed on a branch => Accepted
Comment:
PR sent: https://github.com/django/django/pull/1928
``HttpResponse``s charset is now depending on its ``Content-Type`` header
key.
If no charset is found there, it falls back to the ``DEFAULT_CHARSET``
setting.
--
Ticket URL: <https://code.djangoproject.com/ticket/10190#comment:23>
Django
-------------------------------------+-------------------------------------
Reporter: Wonlay | Owner:
Type: New feature | unaizalakain
Component: HTTP handling | Status: assigned
Severity: Normal | Version: master
Keywords: HttpResponse, | Resolution:
charset, runtime | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
* needs_docs: 0 => 1
Comment:
This latest patch doesn't address the fact that Python charsets do not
match IANA-registered character sets. What's your take on this issue?
--
Ticket URL: <https://code.djangoproject.com/ticket/10190#comment:24>
Django
-------------------------------------+-------------------------------------
Reporter: Wonlay | Owner:
Type: New feature | unaizalakain
Component: HTTP handling | Status: assigned
Severity: Normal | Version: master
Keywords: HttpResponse, | Resolution:
charset, runtime | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 1 => 0
* needs_docs: 1 => 0
Comment:
For the sake of future readers, this is what we have spoken on IRC
(`#django-dev`):
There are two possible workarounds to this:
- Creating a dictionary between IANA registered charsets and Python
charsets. This would be great but it means having to regularly update and
maintain it.
- Adding a `charset` initialization parameter and property to
`HttpResponse`. If you have issues with the charset specification, just
pass on the charset argument or set the charset property. If not set,
it'll fall back to the extraction from the `Content-Type` response header
and if that isn't possible, to the `DEFAULT_CHARSET` setting.
Finally, we decided for the second solution.
We also spoke about parsing the `Accept-Charset` request header so that
the chain would be:
`[charset parameter/property] ---> [content-type extraction] ---> [accept-
charset extraction] ---> [default setting]`
The problem with it was that the `HttpResponse` object could not possibly
know what the request headers were. It's sad to have this limitation but
there isn't any easy workaround.
So, apart of making the changes suggested in the review, I only added the
charset parameter and property.
--
Ticket URL: <https://code.djangoproject.com/ticket/10190#comment:25>
Django
-------------------------------------+-------------------------------------
Type: New feature | Status: assigned
Severity: Normal | Resolution:
charset, runtime | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by aaugustin):
* owner: unaizalakain => aaugustin
Comment:
Tentatively assigning the ticket to myself to review the latest iteration
of the patch.
--
Ticket URL: <https://code.djangoproject.com/ticket/10190#comment:26>
Django
-------------------------------------+-------------------------------------
Reporter: Wonlay | Owner: aaugustin
Type: New feature | Status: assigned
Component: HTTP handling | Version: master
Severity: Normal | Resolution:
Keywords: HttpResponse, | Triage Stage: Accepted
charset, runtime | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by unaizalakain):
Any updates so far?
--
Ticket URL: <https://code.djangoproject.com/ticket/10190#comment:27>
Django
-------------------------------------+-------------------------------------
Reporter: Wonlay | Owner: aaugustin
Type: New feature | Status: assigned
Component: HTTP handling | Version: master
Severity: Normal | Resolution:
Keywords: HttpResponse, | Triage Stage: Accepted
charset, runtime | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* cc: unai@… (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/10190#comment:28>
Django
-------------------------------------+-------------------------------------
Reporter: Wonlay | Owner:
Severity: Normal | Resolution:
Keywords: HttpResponse, | Triage Stage: Accepted
charset, runtime | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* owner: aaugustin =>
* status: assigned => new
--
Ticket URL: <https://code.djangoproject.com/ticket/10190#comment:29>
Django
-------------------------------------+-------------------------------------
Reporter: Wonlay | Owner:
Type: New feature | Status: new
Component: HTTP handling | Version: master
Severity: Normal | Resolution:
Keywords: HttpResponse, | Triage Stage: Accepted
charset, runtime | Needs documentation: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
Comment:
I left comments for improvement on the PR. Please uncheck "Patch needs
improvement" when you update it, thanks.
--
Ticket URL: <https://code.djangoproject.com/ticket/10190#comment:30>
Django
-------------------------------------+-------------------------------------
Reporter: Wonlay | Owner:
Type: New feature | Status: new
Component: HTTP handling | Version: master
Severity: Normal | Resolution:
Keywords: HttpResponse, | Triage Stage: Accepted
charset, runtime | Needs documentation: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* needs_better_patch: 1 => 0
Comment:
Comments addressed and PR updated ;-)
--
Ticket URL: <https://code.djangoproject.com/ticket/10190#comment:31>
Django
-------------------------------------+-------------------------------------
Type: New feature | Graham <timograham@…>
Component: HTTP handling | Status: closed
Severity: Normal | Version: master
Keywords: HttpResponse, | Resolution: fixed
charset, runtime | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* owner: => Tim Graham <timograham@…>
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"5f2542f12a90cfcfb7be776424ef2f7b200df006"]:
{{{
#!CommitTicketReference repository=""
revision="5f2542f12a90cfcfb7be776424ef2f7b200df006"
Fixed #10190 -- Made HttpResponse charset customizable.
Thanks to Simon Charette, Aymeric Augustin, and Tim Graham
for reviews and contributions.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/10190#comment:32>