[Django] #23298: Makemessages --ignore option doesn't work for directories under Windows
Django
------------------------------------------------+------------------------
Reporter: ramiro | Owner: nobody
Type: Bug | Status: new
Component: Internationalization | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
When running the `i18n.test_extraction` tests under Windows, the following
failures happen:
{{{
======================================================================
FAIL: test_ignore_subdirectory
(i18n.test_extraction.IgnoredExtractorTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "D:\ramiro\django\upstream\tests\i18n\test_extraction.py", line
387, in test_ignore_subdirectory
self.assertTrue("ignoring directory subdir" in out)
AssertionError: False is not true
======================================================================
FAIL: test_media_static_dirs_ignored
(i18n.test_extraction.IgnoredExtractorTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "d:\ramiro\django\upstream\django\test\utils.py", line 281, in
inner
return test_func(*args, **kwargs)
File "D:\ramiro\django\upstream\tests\i18n\test_extraction.py", line
402, in test_media_static_dirs_ignored
self.assertIn("ignoring directory static_root", out)
AssertionError: u'ignoring directory static_root' not found in 'examining
files with the extensions: .html and .txt\nprocessing file __init__.py in
.\nprocessing file code.sample in .\nprocessing file ignored.html in
.\\ignore_dir\nprocessing file ja
vascript.js in .\nprocessing file media_ignored.html in
.\\media_root\nprocessing file not_utf8.sample in .\nprocessing file
static_ignored.html in .\\static_root\nprocessing file comments.thtml in
.\\templates\nprocessing file empty.html in .\\templ
ates\nprocessing file plural.djtpl in .\\templates\nprocessing file
ignored.html in .\\templates\\subdir\nprocessing file
template_with_error.tpl in .\\templates\nprocessing file test.html in
.\\templates\nprocessing file xxx_ignored.html in .\\templ
ates\nprocessing locale de\ncopying plural forms: "Plural-Forms:
nplurals=2; plural=(n != 1);\\n"\n'
----------------------------------------------------------------------
Ran 34 tests in 5.670s
FAILED (failures=2)
}}}
This is caused because code is trying to perform matching of dirs spec
matching a trailing `/*` but the path representation is uses at that point
is in native format.
Refs #20422
Refs #22336
--
Ticket URL: <https://code.djangoproject.com/ticket/23298>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: ramiro | Owner: nobody
Type: Bug | Status: new
Internationalization | Resolution:
Severity: Normal | Triage Stage:
Keywords: makemessages | Unreviewed
windows win32 --ignore ignore | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by ramiro):
* keywords: => makemessages windows win32 --ignore ignore
* has_patch: 0 => 1
Comment:
PR: https://github.com/django/django/pull/3075
--
Ticket URL: <https://code.djangoproject.com/ticket/23298#comment:1>
Django
Reporter: ramiro | Owner: nobody
Type: Bug | Status: new
Internationalization | Resolution:
Severity: Normal | Triage Stage:
Keywords: makemessages | Unreviewed
windows win32 --ignore ignore | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Old description:
New description:
FAILED (failures=2)
}}}
This is caused because code is trying to perform matching of dirs specs
with a trailing `'/*'` but the path representation it uses at that point
is in native format (using `'\'` path separators).
Refs #20422
Refs #22336
--
--
Ticket URL: <https://code.djangoproject.com/ticket/23298#comment:2>
Django
Reporter: ramiro | Owner: nobody
Type: Bug | Status: new
Internationalization | Resolution:
Severity: Normal | Triage Stage:
Keywords: makemessages | Unreviewed
windows win32 --ignore ignore | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by ramiro):
Note: To see the test failures, gettext needs to be installed. Otherwise
these tests are skipped.
--
Ticket URL: <https://code.djangoproject.com/ticket/23298#comment:3>
Django
Reporter: ramiro | Owner: nobody
Type: Bug | Status: new
Internationalization | Resolution:
Severity: Release blocker | Triage Stage: Ready for
Keywords: makemessages | checkin
windows win32 --ignore ignore | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* version: master => 1.7-rc-2
* severity: Normal => Release blocker
* stage: Unreviewed => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/23298#comment:4>
Django
Reporter: ramiro | Owner: nobody
Type: Bug | Status: closed
Component: | Version: 1.7-rc-2
Internationalization | Resolution: fixed
Severity: Release blocker | Triage Stage: Ready for
Keywords: makemessages | checkin
windows win32 --ignore ignore | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"b4dce7c37ab7666b023ac791d2c46dad6c8aa637"]:
{{{
#!CommitTicketReference repository=""
revision="b4dce7c37ab7666b023ac791d2c46dad6c8aa637"
Fixed #23298 -- Made makemessages actually ignore specified dirs on
Windows.
This was detected by two failures in the i18n.test_extraction of our
test suite.
Refs #20422, refs #22336
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/23298#comment:5>
Django
Reporter: ramiro | Owner: nobody
Type: Bug | Status: closed
Component: | Version: 1.7-rc-2
Internationalization | Resolution: fixed
Severity: Release blocker | Triage Stage: Ready for
Keywords: makemessages | checkin
windows win32 --ignore ignore | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by Ramiro Morales <ramiro@…>):
In [changeset:"152afadef12e3dcb9ce92567d2e58269749d63b9"]:
{{{
#!CommitTicketReference repository=""
revision="152afadef12e3dcb9ce92567d2e58269749d63b9"
Merge pull request #3075 from ramiro/makemessages-ignore-windows
Fixed #23298 -- Made makemessages actually ignore specified dirs on
Wind...
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/23298#comment:6>
Django
Reporter: ramiro | Owner: nobody
Type: Bug | Status: closed
Component: | Version: 1.7-rc-2
Internationalization | Resolution: fixed
Severity: Release blocker | Triage Stage: Ready for
Keywords: makemessages | checkin
windows win32 --ignore ignore | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"126606c5b8499830cd56cbe632f6af17bc7471ea"]:
{{{
#!CommitTicketReference repository=""
revision="126606c5b8499830cd56cbe632f6af17bc7471ea"
[1.7.x] Fixed #23298 -- Made makemessages actually ignore specified dirs
on Windows.
This was detected by two failures in the i18n.test_extraction of our
test suite.
Refs #20422, refs #22336
Backport of b4dce7c37a from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/23298#comment:7>