[Django] #29284: ImageField widget need 'accept' attribute

6 views
Skip to first unread message

Django

unread,
Apr 2, 2018, 11:03:04 PM4/2/18
to django-...@googlegroups.com
#29284: ImageField widget need 'accept' attribute
--------------------------------------+------------------------
Reporter: safu9 | Owner: nobody
Type: Bug | Status: new
Component: Forms | Version: 2.0
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 1 |
--------------------------------------+------------------------
I think ImageField widget need ' accept="image/*" ' attribute as default.
In some devices such as iPhone, input form doesn't work without this
attribute.

I'll write pr for this ticket.

--
Ticket URL: <https://code.djangoproject.com/ticket/29284>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Apr 2, 2018, 11:11:41 PM4/2/18
to django-...@googlegroups.com
#29284: ImageField widget need 'accept' attribute
------------------------+--------------------------------------

Reporter: safu9 | Owner: nobody
Type: Bug | Status: new
Component: Forms | Version: 2.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
------------------------+--------------------------------------
Changes (by safu9):

* has_patch: 0 => 1


Old description:

> I think ImageField widget need ' accept="image/*" ' attribute as default.
> In some devices such as iPhone, input form doesn't work without this
> attribute.
>
> I'll write pr for this ticket.

New description:

I think ImageField widget need ' accept="image/*" ' attribute as default.
In some devices such as iPhone, input form doesn't work without this
attribute.

This is pr for this ticket: https://github.com/django/django/pull/9850

--

--
Ticket URL: <https://code.djangoproject.com/ticket/29284#comment:1>

Django

unread,
Apr 3, 2018, 1:06:15 AM4/3/18
to django-...@googlegroups.com
#29284: ImageField widget need 'accept' attribute
------------------------+--------------------------------------
Reporter: safu9 | Owner: Junji Wei
Type: Bug | Status: assigned
Component: Forms | Version: 2.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
------------------------+--------------------------------------
Changes (by Junji Wei):

* status: new => assigned
* owner: nobody => Junji Wei


--
Ticket URL: <https://code.djangoproject.com/ticket/29284#comment:2>

Django

unread,
Apr 3, 2018, 1:10:23 AM4/3/18
to django-...@googlegroups.com
#29284: ImageField widget need 'accept' attribute
------------------------+--------------------------------------
Reporter: safu9 | Owner: (none)

Type: Bug | Status: new
Component: Forms | Version: 2.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
------------------------+--------------------------------------
Changes (by Junji Wei):

* owner: Junji Wei => (none)
* status: assigned => new


--
Ticket URL: <https://code.djangoproject.com/ticket/29284#comment:3>

Django

unread,
Apr 3, 2018, 3:41:33 AM4/3/18
to django-...@googlegroups.com
#29284: ImageField widget need 'accept' attribute
--------------------------------------+------------------------------------
Reporter: safu9 | Owner: (none)
Type: Cleanup/optimization | Status: new
Component: Forms | Version: 2.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 1
--------------------------------------+------------------------------------
Changes (by Claude Paroz):

* needs_docs: 0 => 1
* type: Bug => Cleanup/optimization
* needs_tests: 0 => 1
* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/29284#comment:4>

Django

unread,
Apr 4, 2018, 11:25:23 AM4/4/18
to django-...@googlegroups.com
#29284: ImageField widget need 'accept' attribute
--------------------------------------+------------------------------------
Reporter: safu9 | Owner: (none)
Type: Cleanup/optimization | Status: new
Component: Forms | Version: 2.0

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
--------------------------------------+------------------------------------
Changes (by Claude Paroz):

* needs_tests: 1 => 0


Comment:

I'm unsure about documentation or release note needs.

--
Ticket URL: <https://code.djangoproject.com/ticket/29284#comment:5>

Django

unread,
Apr 4, 2018, 2:01:49 PM4/4/18
to django-...@googlegroups.com
#29284: ImageField widget need 'accept' attribute
-------------------------------------+-------------------------------------
Reporter: safu9 | Owner: Tim
Type: | Graham <timograham@…>
Cleanup/optimization | Status: closed
Component: Forms | Version: 2.0
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* owner: (none) => Tim Graham <timograham@…>
* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"9fd9f8bbb23407254aa0ba851dbcc8e7f696c3de" 9fd9f8b]:
{{{
#!CommitTicketReference repository=""
revision="9fd9f8bbb23407254aa0ba851dbcc8e7f696c3de"
Fixed #29284 -- Made ImageField render with accept="image/*"' HTML
attribute.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/29284#comment:6>

Django

unread,
Apr 4, 2018, 2:02:43 PM4/4/18
to django-...@googlegroups.com
#29284: Make ImageField widget render with accept="image/*"' HTML attribute

-------------------------------------+-------------------------------------
Reporter: safu9 | Owner: Tim
Type: | Graham <timograham@…>
Cleanup/optimization | Status: closed
Component: Forms | Version: 2.0

Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

--
Ticket URL: <https://code.djangoproject.com/ticket/29284#comment:7>

Reply all
Reply to author
Forward
0 new messages