Re: [Django] #7361: newforms-admin delete page gives you no way out!

Django

unread,

Jul 10, 2011, 3:55:53 PM7/10/11

to django-...@googlegroups.com

#7361: newforms-admin delete page gives you no way out!
-------------------------------------+-------------------------------------
Reporter: simon | Owner: barbuza
Type: New | Status: assigned
feature | Component: contrib.admin
Milestone: | Severity: Normal
Version: newforms- | Keywords: usability nfa-
admin | someday feature
Resolution: | Has patch: 1
Triage Stage: Design | Needs tests: 1
decision needed | Easy pickings: 0
Needs documentation: 0 |
Patch needs improvement: 1 |
UI/UX: 1 |
-------------------------------------+-------------------------------------
Changes (by julien):

* needs_better_patch: 0 => 1
* needs_tests: 0 => 1
* easy: => 0

Comment:

The attached patch suggests having the cancel action as a link instead of
a button, since its purpose effectively is to navigate back to where you
were. The behaviour would probably also need to be the same as clicking
the browser's back button, that is, the link's `href` would be something
like `"javascript:history.back()"` -- although there could be an issue if
javascript was turned off. Patch still needs some tweaking and some tests.

--
Ticket URL: <https://code.djangoproject.com/ticket/7361#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,

Sep 11, 2011, 5:43:00 PM9/11/11

to django-...@googlegroups.com

#7361: newforms-admin delete page gives you no way out!
-------------------------------------+-------------------------------------
Reporter: simon | Owner: barbuza
Type: New | Status: assigned
feature | Component: contrib.admin
Milestone: | Severity: Normal
Version: newforms- | Keywords: usability nfa-
admin | someday feature
Resolution: | Has patch: 1

Triage Stage: Accepted | Needs tests: 1
Needs documentation: 0 | Easy pickings: 0

Patch needs improvement: 1 |
UI/UX: 1 |
-------------------------------------+-------------------------------------

Changes (by carljm):

* stage: Design decision needed => Accepted

--
Ticket URL: <https://code.djangoproject.com/ticket/7361#comment:8>

Django

unread,

May 27, 2014, 3:50:06 AM5/27/14

to django-...@googlegroups.com

#7361: newforms-admin delete page gives you no way out!
-------------------------------------+-------------------------------------
Reporter: simon | Owner: barbuza

Comment (by jli):

I would like to give this ticket some love, any advice on how to make it
go forward ?

--
Ticket URL: <https://code.djangoproject.com/ticket/7361#comment:9>

Django

unread,

May 27, 2014, 8:14:10 AM5/27/14

to django-...@googlegroups.com

#7361: newforms-admin delete page gives you no way out!
-------------------------------------+-------------------------------------
Reporter: simon | Owner: barbuza
Type: New feature | Status: assigned
Component: contrib.admin | Version: newforms-
Severity: Normal | admin
Keywords: usability nfa- | Resolution:
someday feature | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by timo):

@jli, improve the patch as noted in the comment above.

--
Ticket URL: <https://code.djangoproject.com/ticket/7361#comment:10>

Django

unread,

Jul 28, 2014, 12:38:38 PM7/28/14

to django-...@googlegroups.com

#7361: newforms-admin delete page gives you no way out!
-------------------------------------+-------------------------------------
Reporter: simon | Owner: barbuza
Type: New feature | Status: assigned
Component: contrib.admin | Version: newforms-
Severity: Normal | admin
Keywords: usability nfa- | Resolution:
someday feature | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by slurms):

* needs_better_patch: 1 => 0
* needs_tests: 1 => 0

Comment:

PR here: https://github.com/django/django/pull/2993

--
Ticket URL: <https://code.djangoproject.com/ticket/7361#comment:11>

Django

unread,

Aug 1, 2014, 3:06:28 PM8/1/14

to django-...@googlegroups.com

#7361: Add back button to admin delete page

-------------------------------------+-------------------------------------
Reporter: simon | Owner: barbuza
Type: New feature | Status: assigned

* needs_better_patch: 0 => 1

* version: newforms-admin => master

Comment:

Left comments for improvement on PR.

--
Ticket URL: <https://code.djangoproject.com/ticket/7361#comment:12>

Django

unread,

Sep 30, 2014, 8:46:31 AM9/30/14

to django-...@googlegroups.com

#7361: Add back button to admin delete page
-------------------------------------+-------------------------------------
Reporter: simon | Owner: barbuza

Type: New feature | Status: closed
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed

Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"f5cfd09c257e5a4ed6d01d32505c48b02e3860d5"]:
{{{
#!CommitTicketReference repository=""
revision="f5cfd09c257e5a4ed6d01d32505c48b02e3860d5"
Fixed #7361 -- Added cancel link to admin delete views.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/7361#comment:13>

Django

unread,

Dec 1, 2014, 3:49:59 PM12/1/14

to django-...@googlegroups.com

#7361: Add back button to admin delete page
-------------------------------------+-------------------------------------
Reporter: simon | Owner: barbuza
Type: New feature | Status: closed
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed
Keywords: usability nfa- | Triage Stage: Accepted
someday feature | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 1
Needs tests: 0 | UI/UX: 1
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"43fcf3505eb22228f551ab03122f99b3d40f38ed"]:
{{{
#!CommitTicketReference repository=""
revision="43fcf3505eb22228f551ab03122f99b3d40f38ed"
Fixed admin_views test from refs #7361 (name was too long).
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/7361#comment:14>

Django

unread,

Jan 8, 2015, 1:52:50 PM1/8/15

to django-...@googlegroups.com

#7361: Add back button to admin delete page
-------------------------------------+-------------------------------------
Reporter: simon | Owner: barbuza
Type: New feature | Status: closed
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed
Keywords: usability nfa- | Triage Stage: Accepted
someday feature |

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 1

-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"b8abfe141be17f20079f55b921dcaf7abe116c4b"]:
{{{
#!CommitTicketReference repository=""
revision="b8abfe141be17f20079f55b921dcaf7abe116c4b"
Fixed #24101 -- Fixed flaky admin_views selenium tests; refs #7361.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/7361#comment:15>

Reply all

Reply to author

Forward