[Django] #28529: Clean "VariableDoesNotExist" errors in admin templates
Django
------------------------------------------------+------------------------
Reporter: Vlastimil Zíma | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
In discussion about the template error logs
https://groups.google.com/d/msg/django-
developers/zdULZcmAWNw/YvzDwa5FCAAJ, Tim mentioned a ticket #28516 about
an errors in admin change_list. To provide a relevant feedback I tried to
fix admin templates in order to remove all `VariableDoesNotExist` errors.
I open this ticket, because the #28516 was closed without a solution and
as a response to Tim's comment in the discussion.
--
Ticket URL: <https://code.djangoproject.com/ticket/28529>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Vlastimil Zíma | Owner: Vlastimil
Type: | Zíma
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Vlastimil Zíma):
* owner: nobody => Vlastimil Zíma
* status: new => assigned
Comment:
PR: https://github.com/django/django/pull/8973
--
Ticket URL: <https://code.djangoproject.com/ticket/28529#comment:1>
Django
-------------------------------------+-------------------------------------
Reporter: Vlastimil Zíma | Owner: Vlastimil
Type: | Zíma
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham):
* stage: Unreviewed => Accepted
* needs_tests: 0 => 1
Old description:
> In discussion about the template error logs
> https://groups.google.com/d/msg/django-
> developers/zdULZcmAWNw/YvzDwa5FCAAJ, Tim mentioned a ticket #28516 about
> an errors in admin change_list. To provide a relevant feedback I tried to
> fix admin templates in order to remove all `VariableDoesNotExist` errors.
>
> I open this ticket, because the #28516 was closed without a solution and
> as a response to Tim's comment in the discussion.
New description:
In [https://groups.google.com/d/msg/django-
developers/zdULZcmAWNw/YvzDwa5FCAAJ discussion about the template error
logs], Tim mentioned #28516 about an errors in admin change_list. To
provide a relevant feedback, I tried to fix admin templates in order to
remove all `VariableDoesNotExist` errors.
I open this ticket, because #28516 was closed without a solution and as a
response to Tim's comment in the discussion.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/28529#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: Vlastimil Zíma | Owner: Vlastimil
Type: | Zíma
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham):
I'll reluctantly merge this without tests as it seems they are non-trivial
and a regression isn't serious.
--
Ticket URL: <https://code.djangoproject.com/ticket/28529#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: Vlastimil Zíma | Owner: Vlastimil
Type: | Zíma
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"a9f5652113f0721a7066e359ae28d14692ea3c47" a9f56521]:
{{{
#!CommitTicketReference repository=""
revision="a9f5652113f0721a7066e359ae28d14692ea3c47"
Fixed #28529 -- Fixed VariableDoesNotExist warnings in admin templates.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/28529#comment:4>