[Django] #27449: Make django.utils.translation.trans_real.get_supported_language_variant public API
Django
public API
------------------------------------------------+------------------------
Reporter: Iacopo Spalletti | Owner: nobody
Type: Uncategorized | Status: new
Component: Internationalization | Version: 1.10
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
How about making
django.utils.translation.trans_real.get_supported_language_variant part of
the public API?
A use case for this: Check if a given language is within the ones listed
in LANGUAGES, including the sublanguages, as stated in
https://docs.djangoproject.com/en/1.10/topics/i18n/translation/:
This example restricts languages that are available for automatic
selection to German and English (and any sublanguage, like de-ch or en-
us).
Example: https://github.com/django-parler/django-parler/issues/156
Making this public will involve:
* Adding documentation
* Exposing it in ``django.utils.translation``
--
Ticket URL: <https://code.djangoproject.com/ticket/27449>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
public API
Reporter: Iacopo Spalletti | Owner: nobody
Component: | Version: 1.10
Internationalization |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Ingo Klöcker):
* type: Uncategorized => New feature
--
Ticket URL: <https://code.djangoproject.com/ticket/27449#comment:1>
Django
public API
Reporter: Iacopo Spalletti | Owner: nobody
Component: Internationalization | Version: 1.10
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
--------------------------------------+------------------------------------
Changes (by Ingo Klöcker):
* easy: 0 => 1
* stage: Unreviewed => Accepted
Comment:
I think it makes sense to make it public API. It also seems to be fairly
easy to do.
--
Ticket URL: <https://code.djangoproject.com/ticket/27449#comment:2>
Django
public API
Reporter: Iacopo Spalletti | Owner: Iacopo
| Spalletti
Type: New feature | Status: assigned
Component: | Version: 1.10
Internationalization |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by Iacopo Spalletti):
* owner: nobody => Iacopo Spalletti
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/27449#comment:3>
Django
public API
Reporter: Iacopo Spalletti | Owner: Iacopo
| Spalletti
Type: New feature | Status: assigned
Component: | Version: 1.10
Internationalization |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Description changed by Iacopo Spalletti:
Old description:
> How about making
> django.utils.translation.trans_real.get_supported_language_variant part
> of the public API?
>
> A use case for this: Check if a given language is within the ones listed
> in LANGUAGES, including the sublanguages, as stated in
> https://docs.djangoproject.com/en/1.10/topics/i18n/translation/:
>
> This example restricts languages that are available for automatic
> selection to German and English (and any sublanguage, like de-ch or en-
> us).
>
> Example: https://github.com/django-parler/django-parler/issues/156
>
> Making this public will involve:
>
> * Adding documentation
> * Exposing it in ``django.utils.translation``
New description:
How about making
django.utils.translation.trans_real.get_supported_language_variant part of
the public API?
A use case for this: Check if a given language is within the ones listed
in LANGUAGES, including the sublanguages, as stated in
https://docs.djangoproject.com/en/1.10/topics/i18n/translation/:
This example restricts languages that are available for automatic
selection to German and English (and any sublanguage, like de-ch or en-
us).
Example: https://github.com/django-parler/django-parler/issues/156
Making this public will involve:
* Adding documentation
* Exposing it in `django.utils.translation`
--
--
Ticket URL: <https://code.djangoproject.com/ticket/27449#comment:4>
Django
public API
Reporter: Iacopo Spalletti | Owner: Iacopo
| Spalletti
Type: New feature | Status: assigned
Component: | Version: 1.10
Internationalization |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Comment (by Iacopo Spalletti):
I will work on a patch
--
Ticket URL: <https://code.djangoproject.com/ticket/27449#comment:5>
Django
public API
Reporter: Iacopo Spalletti | Owner: Iacopo
| Spalletti
Type: New feature | Status: assigned
Component: | Version: 1.10
Internationalization |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Comment (by Lee Cartwright):
It's been a while since this ticket was updated. Are there any objections
to me taking it on?
--
Ticket URL: <https://code.djangoproject.com/ticket/27449#comment:6>
Django
public API
Reporter: Iacopo Spalletti | Owner: Sebastian
| Sangervasi
Type: New feature | Status: assigned
Component: | Version: 1.10
Internationalization |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
* owner: Iacopo Spalletti => Sebastian Sangervasi
Comment:
This seems to have gone unattended for four months, so I worked on it as a
first contribution. I have a pull request ready to go, so I'm going to
claim this.
--
Ticket URL: <https://code.djangoproject.com/ticket/27449#comment:7>
Django
public API
Reporter: Iacopo Spalletti | Owner: Sebastian
| Sangervasi
Type: New feature | Status: assigned
Component: | Version: 1.10
Internationalization |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by Sebastian Sangervasi):
* has_patch: 0 => 1
Comment:
I have submitted a pull request:
[https://github.com/django/django/pull/8682]
I followed procedure for the creation of new tests and all tests pass.
However, I had some questions about how tests are being done for
translation. I'm going to ask these these questions on the pull request,
but I can move them here if that is preferred.
--
Ticket URL: <https://code.djangoproject.com/ticket/27449#comment:8>
Django
public API
Reporter: Iacopo Spalletti | Owner: Sebastian
| Sangervasi
Type: New feature | Status: assigned
Component: | Version: 1.10
Internationalization |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Comment (by Sebastian Sangervasi):
My patch has been reviewed and, after some documentation updates, should
be ready to merge into 2.1.
--
Ticket URL: <https://code.djangoproject.com/ticket/27449#comment:9>
Django
public API
Reporter: Iacopo Spalletti | Owner: Sebastian
| Sangervasi
Type: New feature | Status: assigned
Component: | Version: 1.10
Internationalization |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
* needs_docs: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/27449#comment:10>
Django
public API
Reporter: Iacopo Spalletti | Owner: Sebastian
| Sangervasi
Type: New feature | Status: assigned
Component: | Version: 1.10
Internationalization |
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):
* needs_docs: 1 => 0
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/27449#comment:11>
Django
public API
Reporter: Iacopo Spalletti | Owner: Sebastian
| Sangervasi
Component: | Version: 1.10
Internationalization |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"7905815510fb1eae99010ccc0039249d981a121c" 7905815]:
{{{
#!CommitTicketReference repository=""
revision="7905815510fb1eae99010ccc0039249d981a121c"
Fixed #27449 -- Added
django.utils.translation.get_supported_language_variant().
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27449#comment:12>