[Django] #27784: Custom Site model support for django.contrib.sites.

17 views
Skip to first unread message

Django

unread,
Jan 27, 2017, 7:58:28 AM1/27/17
to django-...@googlegroups.com
#27784: Custom Site model support for django.contrib.sites.
-------------------------------------+-------------------------------------
Reporter: Massimo | Owner: nobody
Scamarcia |
Type: New | Status: new
feature |
Component: | Version: master
contrib.sites | Keywords: sites swappable
Severity: Normal | models
Triage Stage: | Has patch: 1
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Support for custom Site model in django.contrib.sites to add model fields
and change default manager.

--
Ticket URL: <https://code.djangoproject.com/ticket/27784>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jan 27, 2017, 8:01:20 AM1/27/17
to django-...@googlegroups.com
#27784: Custom Site model support for django.contrib.sites.
-------------------------------------+-------------------------------------
Reporter: Massimo Scamarcia | Owner: nobody
Type: New feature | Status: new
Component: contrib.sites | Version: master
Severity: Normal | Resolution:
Keywords: sites swappable | Triage Stage:
models | Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Massimo Scamarcia):

Pull Request: https://github.com/django/django/pull/7961

Should I push to ticket_27784 instead?

--
Ticket URL: <https://code.djangoproject.com/ticket/27784#comment:1>

Django

unread,
Jan 27, 2017, 8:43:23 AM1/27/17
to django-...@googlegroups.com
#27784: Custom Site model support for django.contrib.sites.
-------------------------------------+-------------------------------------
Reporter: Massimo Scamarcia | Owner: nobody
Type: New feature | Status: closed
Component: contrib.sites | Version: master
Severity: Normal | Resolution: duplicate

Keywords: sites swappable | Triage Stage:
models | Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* status: new => closed
* resolution: => duplicate


Comment:

Duplicate of #22779. The latest [https://groups.google.com/d/topic/django-
developers/OGOf1TfSBBs/discussion discussion on the mailing list]
suggested replacing the model with settings may be a better approach.

--
Ticket URL: <https://code.djangoproject.com/ticket/27784#comment:2>

Django

unread,
Jan 27, 2017, 9:19:08 AM1/27/17
to django-...@googlegroups.com
#27784: Custom Site model support for django.contrib.sites.
-------------------------------------+-------------------------------------
Reporter: Massimo Scamarcia | Owner: nobody
Type: New feature | Status: closed
Component: contrib.sites | Version: master
Severity: Normal | Resolution: duplicate
Keywords: sites swappable | Triage Stage:
models | Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Massimo Scamarcia):

Replying to [comment:2 Tim Graham]:


> Duplicate of #22779. The latest [https://groups.google.com/d/topic

/django-developers/OGOf1TfSBBs/discussion discussion on the mailing list]


suggested replacing the model with settings may be a better approach.

I personally dislike the settings based solutions as there are many
pluggable apps and projects that are importing Site directly from
django.contrib.sites.models. imho this feature should work exactly like
the customization of django.contrib.auth.models.User.

--
Ticket URL: <https://code.djangoproject.com/ticket/27784#comment:3>

Django

unread,
Jan 27, 2017, 9:51:37 AM1/27/17
to django-...@googlegroups.com
#27784: Custom Site model support for django.contrib.sites.
-------------------------------------+-------------------------------------
Reporter: Massimo Scamarcia | Owner: nobody
Type: New feature | Status: closed
Component: contrib.sites | Version: master
Severity: Normal | Resolution: duplicate
Keywords: sites swappable | Triage Stage:
models | Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham):

You should continue the discussion on the mailing list. We won't make a
change either way without a consensus there.

--
Ticket URL: <https://code.djangoproject.com/ticket/27784#comment:4>

Django

unread,
Jan 30, 2017, 4:45:46 AM1/30/17
to django-...@googlegroups.com
#27784: Custom Site model support for django.contrib.sites.
-------------------------------------+-------------------------------------
Reporter: Massimo Scamarcia | Owner: nobody
Type: New feature | Status: closed
Component: contrib.sites | Version: master
Severity: Normal | Resolution: duplicate
Keywords: sites swappable | Triage Stage:
models | Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Massimo Scamarcia):

Replying to [comment:4 Tim Graham]:


> You should continue the discussion on the mailing list. We won't make a
change either way without a consensus there.

Ok thanks, I will do.

--
Ticket URL: <https://code.djangoproject.com/ticket/27784#comment:5>

Reply all
Reply to author
Forward
0 new messages