[Django] #28386: Operations within non-atomic migrations don't honor the operation's `atomic` flag when migrating backwards

5 views
Skip to first unread message

Django

unread,
Jul 11, 2017, 12:37:24 PM7/11/17
to django-...@googlegroups.com
#28386: Operations within non-atomic migrations don't honor the operation's
`atomic` flag when migrating backwards
--------------------------------------+---------------------------
Reporter: Evan Grim | Owner: Evan Grim
Type: Bug | Status: assigned
Component: Migrations | Version: 1.11
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
--------------------------------------+---------------------------
Non-atomic migrations added in #25833 allowed for individual operations to
be marked `atomic`. This works properly in the forward direction but
fails when moving backwards.

I'll open a pull request which augments the tests to catch this and
applies the necessary changes to make it work.

--
Ticket URL: <https://code.djangoproject.com/ticket/28386>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jul 11, 2017, 1:01:30 PM7/11/17
to django-...@googlegroups.com
#28386: Operations within non-atomic migrations don't honor the operation's
`atomic` flag when migrating backwards
----------------------------+-------------------------------------

Reporter: Evan Grim | Owner: Evan Grim
Type: Bug | Status: assigned
Component: Migrations | Version: 1.11
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
----------------------------+-------------------------------------
Changes (by Tim Graham):

* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/28386#comment:1>

Django

unread,
Jul 17, 2017, 1:01:09 PM7/17/17
to django-...@googlegroups.com
#28386: Operations within non-atomic migrations don't honor the operation's
`atomic` flag when migrating backwards
----------------------------+-------------------------------------

Reporter: Evan Grim | Owner: Evan Grim
Type: Bug | Status: assigned
Component: Migrations | Version: 1.11
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
----------------------------+-------------------------------------
Changes (by Tim Graham):

* needs_better_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/28386#comment:2>

Django

unread,
Aug 10, 2017, 8:18:15 PM8/10/17
to django-...@googlegroups.com
#28386: Operations within non-atomic migrations don't honor the operation's
`atomic` flag when migrating backwards
----------------------------+-------------------------------------

Reporter: Evan Grim | Owner: Evan Grim
Type: Bug | Status: closed
Component: Migrations | Version: 1.11
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
----------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"7937cc16f5fafb33a53b9a9ff286229fcc5ba67f" 7937cc1]:
{{{
#!CommitTicketReference repository=""
revision="7937cc16f5fafb33a53b9a9ff286229fcc5ba67f"
Fixed #28386 -- Made operations within non-atomic migrations honor the
operation's atomic flag when migrating backwards.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/28386#comment:3>

Reply all
Reply to author
Forward
0 new messages