[Django] #31577: The explanation ended in the middle.
Django
------------------------------------------------+------------------------
Reporter: Joon Hwan 김준환 | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 3.0
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
https://docs.djangoproject.com/en/3.0/ref/contrib/postgres/fields/#range-
fields
https://docs.djangoproject.com/en/3.0/ref/contrib/postgres/fields/#integerrangefield
https://docs.djangoproject.com/en/3.0/ref/contrib/postgres/fields/#bigintegerrangefield
https://docs.djangoproject.com/en/3.0/ref/contrib/postgres/fields/#daterangefield
You can see the sentence ends with "that is [)."
--
Ticket URL: <https://code.djangoproject.com/ticket/31577>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Joon Hwan 김준환 | Owner: nobody
Cleanup/optimization |
Component: Documentation | Version: 3.0
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Carlton Gibson):
This is how Postres ranges are specified. See
https://www.postgresql.org/docs/9.3/rangetypes.html#RANGETYPES-IO
Wonder if we can explain that better.
--
Ticket URL: <https://code.djangoproject.com/ticket/31577#comment:1>
Django
Reporter: Joon Hwan 김준환 | Owner: nobody
Cleanup/optimization |
Component: Documentation | Version: 3.0
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by felixxm):
Yes, see https://www.postgresql.org/docs/current/rangetypes.html
#RANGETYPES-INCLUSIVITY.
We can only add ref to the PostgreSQL documentation like in
[https://docs.djangoproject.com/en/3.0/ref/contrib/postgres/fields
/#rangeboundary-expressions RangeBoundary].
--
Ticket URL: <https://code.djangoproject.com/ticket/31577#comment:2>
Django
Reporter: Joon Hwan 김준환 | Owner: nobody
Cleanup/optimization |
Component: Documentation | Version: 3.0
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Carlton Gibson):
* status: new => closed
* resolution: => wontfix
Comment:
Hmmm. We already link to the psycopg docs here:
https://www.psycopg.org/docs/extras.html#adapt-range.
I'm going to say wontfix, as the `[)` is already marked out as a code
literal. But if anyone wants to suggest a concrete clarification I'm happy
to review.
--
Ticket URL: <https://code.djangoproject.com/ticket/31577#comment:3>
Django
Reporter: Joon Hwan 김준환 | Owner: nobody
Cleanup/optimization |
Component: Documentation | Version: 3.0
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Joon Hwan 김준환):
I had difficulty reading the document because I didn't have any background
knowledge of Range Boundary expression.
I carefully suggests putting the next link nearby `Range Fields`.
https://docs.djangoproject.com/en/3.0/ref/contrib/postgres/fields
/#rangeboundary-expressions
--
Ticket URL: <https://code.djangoproject.com/ticket/31577#comment:4>
Django
Reporter: Joon Hwan 김준환 | Owner: nobody
Cleanup/optimization |
Component: Documentation | Version: 3.0
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Carlton Gibson):
A PR clarifying would be very welcome. Please assign yourself and reopen
the ticket if you will provide one. Thanks!
--
Ticket URL: <https://code.djangoproject.com/ticket/31577#comment:5>
Django
Reporter: Joon Hwan 김준환 | Owner: nobody
Cleanup/optimization |
Component: Documentation | Version: 3.0
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Joon Hwan 김준환):
* status: closed => new
* resolution: wontfix =>
Comment:
Let me provide PR as soon as possible.
--
Ticket URL: <https://code.djangoproject.com/ticket/31577#comment:6>
Django
Reporter: Joon Hwan 김준환 | Owner: Joon Hwan
Type: | 김준환
Cleanup/optimization | Status: assigned
Component: Documentation | Version: 3.0
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Joon Hwan 김준환):
* owner: nobody => Joon Hwan 김준환
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/31577#comment:7>
Django
Reporter: Joon Hwan 김준환 | Owner: Joon Hwan
Type: | 김준환
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Carlton Gibson):
* stage: Unreviewed => Accepted
Comment:
OK, super. I shall Accept on that basis.
Thanks for the input! 🎉
--
Ticket URL: <https://code.djangoproject.com/ticket/31577#comment:8>
Django
Reporter: Joon Hwan 김준환 | Owner: Joon Hwan
Type: | 김준환
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Joon Hwan 김준환):
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/12927 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/31577#comment:9>
Django
Reporter: Joon Hwan 김준환 | Owner: Joon Hwan
Type: | 김준환
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by felixxm):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/31577#comment:10>
Django
Reporter: Joon Hwan 김준환 | Owner: Joon Hwan
Type: | 김준환
Component: Documentation | Version: 3.0
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"4029bcd6b20f75a78f9a5829d7826c79aeb20732" 4029bcd6]:
{{{
#!CommitTicketReference repository=""
revision="4029bcd6b20f75a78f9a5829d7826c79aeb20732"
Fixed #31577 -- Clarified docs about bounds of RangeFields.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/31577#comment:11>
Django
Reporter: Joon Hwan 김준환 | Owner: Joon Hwan
Type: | 김준환
Cleanup/optimization | Status: closed
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"03bfcbad88a1ab8a29504a7a0eb9d7c31745c9c5" 03bfcba]:
{{{
#!CommitTicketReference repository=""
revision="03bfcbad88a1ab8a29504a7a0eb9d7c31745c9c5"
[3.1.x] Fixed #31577 -- Clarified docs about bounds of RangeFields.
Backport of 4029bcd6b20f75a78f9a5829d7826c79aeb20732 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/31577#comment:12>