[Django] #32166: test_expression_on_aggregation has an additional "class Greatest" definition
Django
definition
------------------------------------------------+------------------------
Reporter: Sicong | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Testing framework | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
Function greatest now supported in **db.models.functions.comparison**,
propose to remove `class Greatest` in the unit test.
Refer to comment on
Github:[https://github.com/django/django/commit/f59fd15c4928caf3dfcbd50f6ab47be409a43b01
#diff-
7406fc41610281c9ff732230a859d1eb1406875841d9a5a81ab4c7090b37b6d0R920]
--
Ticket URL: <https://code.djangoproject.com/ticket/32166>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
definition
Reporter: Sicong | Owner: Sicong
Type: | Status: assigned
Cleanup/optimization |
Component: Testing framework | Version: master
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Sicong):
* owner: nobody => Sicong
* status: new => assigned
Comment:
I have a patch ready.
--
Ticket URL: <https://code.djangoproject.com/ticket/32166#comment:1>
Django
definition
Reporter: Sicong | Owner: Sicong
Type: Cleanup/optimization | Status: assigned
Component: Core (Other) | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* component: Testing framework => Core (Other)
* stage: Unreviewed => Accepted
Comment:
Thanks. Please send PR via GitHub.
Ticket is not required for such a small cleanups, by the way.
--
Ticket URL: <https://code.djangoproject.com/ticket/32166#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: Sicong | Owner: Sicong
Type: | Status: assigned
Cleanup/optimization |
Component: Core (Other) | Version: master
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham):
* has_patch: 0 => 1
* stage: Accepted => Ready for checkin
Comment:
[https://github.com/django/django/pull/13634 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/32166#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: Sicong | Owner: Sicong
Cleanup/optimization |
Component: Core (Other) | Version: master
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by GitHub <noreply@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"09e1ec71dfd1e43ae422f5f9bf4525936832e0ce" 09e1ec7]:
{{{
#!CommitTicketReference repository=""
revision="09e1ec71dfd1e43ae422f5f9bf4525936832e0ce"
Fixed #32166 -- Removed redundant definition of Greatest in
test_expression_on_aggregation.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/32166#comment:4>