Three times now I've had need to modify the ORM serializers for project
use. In every case I've had to replicate large parts (if not all) of
`django.core.serializers.base` in order to change 1 or 2 lines because
certain calls to functions in `django.core.serializers.base` form the
serializers are hardcoded.
* Changing JSON serialization to output in alphabetical order (so that
`dumpdata` doesn't reorder every field each time you run it)
* Changing deserialization to use `_base_manager` instead of
`_default_manager` (due to extra constraints on a custom manager)
* Implementing fixes for #7202, #7350 before they were merged
**Proposal**
I propose that instead of calling the following functions directly, the
serializer classes are modified to call an instance method of the same
name that then calls the existing module-level functions. This would allow
the ability to more easily override just one aspect of serializer
functionality without having to replicate large swathes of code.
I am not proposing to move these functions into the python serializer
class directly because this may break compatibility with existing code
that depends on the existing functions.
* `django.core.serializers.base.build_instance`
* `django.core.serializers.base.deserializer_m2m_values`
* `django.core.serializers.base.deserializer_fk_values`
* `django.core.serializers.python._get_model` (given that this is already
an internal function, implementation can be pushed into the class
directly)
(It might also be nice if the `json` and `pyyaml` classes could also have
`PythonDeserializer` be made a class attribute but that would involve
turning the `Deserializer` function into a class and is not nearly as much
code to override these as the functions above)
If this sounds acceptable, I will submit a patch.
--
Ticket URL: <https://code.djangoproject.com/ticket/29522>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Old description:
New description:
**Use case**
Three times now I've had need to modify the ORM serializers for project
use. In every case I've had to replicate large parts (if not all) of
`django.core.serializers.base` in order to change 1 or 2 lines because
certain calls to functions in `django.core.serializers.base` from the
serializers are hardcoded.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/29522#comment:1>
Old description:
> **Use case**
>
> Three times now I've had need to modify the ORM serializers for project
> use. In every case I've had to replicate large parts (if not all) of
> `django.core.serializers.base` in order to change 1 or 2 lines because
> certain calls to functions in `django.core.serializers.base` from the
New description:
**Use case**
Three times now I've had need to modify the ORM serializers for project
use. In some cases I've had to replicate large parts (if not most) of
`django.core.serializers.base` in order to change 1 or 2 lines because
certain calls to functions in `django.core.serializers.base` from the
serializers are hardcoded.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/29522#comment:2>
Old description:
> **Use case**
>
> Three times now I've had need to modify the ORM serializers for project
> use. In some cases I've had to replicate large parts (if not most) of
> `django.core.serializers.base` in order to change 1 or 2 lines because
> certain calls to functions in `django.core.serializers.base` from the
New description:
**Use case**
Three times now I've had need to modify the ORM serializers for project
use. In some cases I've had to replicate large parts (if not most) of
`django.core.serializers.python` in order to change 1 or 2 lines because
certain calls to functions in `django.core.serializers.base` from the
serializers are hardcoded.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/29522#comment:3>
* stage: Unreviewed => Accepted
Comment:
This sounds reasonable to me. My main thought would be to make sure the
new hooks a properly documented etc. But yes, good idea.
--
Ticket URL: <https://code.djangoproject.com/ticket/29522#comment:4>
--
Ticket URL: <https://code.djangoproject.com/ticket/29522#comment:5>
* cc: Herbert Fortes (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/29522#comment:6>
* owner: nobody => Emad Mokhtar
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/29522#comment:7>
* cc: Ian Foote (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/29522#comment:8>
Comment (by Emad Mokhtar):
[PR created](https://github.com/EmadMokhtar/django/tree/ticket_29522)
--
Ticket URL: <https://code.djangoproject.com/ticket/29522#comment:9>
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/29522#comment:10>
* needs_better_patch: 0 => 1
* needs_tests: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/29522#comment:11>