[Django] #27349: Docs: "Costomizing error views" does not mention CSRF_FAILURE_VIEW

4 views
Skip to first unread message

Django

unread,
Oct 14, 2016, 6:16:31 AM10/14/16
to django-...@googlegroups.com
#27349: Docs: "Costomizing error views" does not mention CSRF_FAILURE_VIEW
-------------------------------+--------------------
Reporter: David D Lowe | Owner: nobody
Type: Uncategorized | Status: new
Component: Documentation | Version: 1.10
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------+--------------------
Have a look at the section "Customizing error views" in this documentation
page:

https://docs.djangoproject.com/en/1.10/topics/http/views/#customizing-
error-views

It does not mention the highly relevant CSRF_FAILURE_VIEW setting. I think
it should.

--
Ticket URL: <https://code.djangoproject.com/ticket/27349>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Oct 14, 2016, 6:19:43 AM10/14/16
to django-...@googlegroups.com
#27349: Docs: "Costomizing error views" does not mention CSRF_FAILURE_VIEW
-------------------------------+--------------------------------------

Reporter: David D Lowe | Owner: nobody
Type: Uncategorized | Status: new
Component: Documentation | Version: 1.10
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------+--------------------------------------
Changes (by David D Lowe):

* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0


Comment:

I created a pull request, fixing this issue:

https://github.com/django/django/pull/7391

--
Ticket URL: <https://code.djangoproject.com/ticket/27349#comment:1>

Django

unread,
Oct 14, 2016, 6:20:42 AM10/14/16
to django-...@googlegroups.com
#27349: Docs: "Costomizing error views" does not mention CSRF_FAILURE_VIEW
-------------------------------+--------------------------------------

Reporter: David D Lowe | Owner: nobody
Type: Uncategorized | Status: new
Component: Documentation | Version: 1.10
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------+--------------------------------------
Changes (by David D Lowe):

* has_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/27349#comment:2>

Django

unread,
Oct 14, 2016, 8:05:58 AM10/14/16
to django-...@googlegroups.com
#27349: Docs: "Customizing error views" does not mention CSRF_FAILURE_VIEW
--------------------------------------+------------------------------------

Reporter: David D Lowe | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 1.10
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Tim Graham):

* type: Uncategorized => Cleanup/optimization
* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/27349#comment:3>

Django

unread,
Oct 14, 2016, 1:52:06 PM10/14/16
to django-...@googlegroups.com
#27349: Docs: "Customizing error views" does not mention CSRF_FAILURE_VIEW
--------------------------------------+------------------------------------

Reporter: David D Lowe | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: Documentation | Version: 1.10
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"223393a9e3d5131e1701b05df4b995d2774902b3" 223393a]:
{{{
#!CommitTicketReference repository=""
revision="223393a9e3d5131e1701b05df4b995d2774902b3"
[1.10.x] Fixed #27349 -- Doc'd the CSRF_FAILURE_VIEW setting in view topic
guide.

Backport of 424187ec4be73a36d5430901382a27c8523f446a from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27349#comment:5>

Django

unread,
Oct 14, 2016, 1:52:08 PM10/14/16
to django-...@googlegroups.com
#27349: Docs: "Customizing error views" does not mention CSRF_FAILURE_VIEW
--------------------------------------+------------------------------------

Reporter: David D Lowe | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: Documentation | Version: 1.10

Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"424187ec4be73a36d5430901382a27c8523f446a" 424187ec]:
{{{
#!CommitTicketReference repository=""
revision="424187ec4be73a36d5430901382a27c8523f446a"


Fixed #27349 -- Doc'd the CSRF_FAILURE_VIEW setting in view topic guide.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27349#comment:4>

Reply all
Reply to author
Forward
0 new messages