[Django] #31354: When I am using a reverse proxy on a non-standard port request.get_host() does not include the port
Django
does not include the port
-------------------------------------+-------------------------------------
Reporter: dgcgh | Owner: nobody
Type: Bug | Status: new
Component: | Version: 3.0
Uncategorized | Keywords: request get_host
Severity: Normal | build_absolute_uri
Triage Stage: | Has patch: 1
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
-------------------------------------+-------------------------------------
request.get_port() should include the port of the authority if it is not
80 for http or 443 for https. Currently this does not happen when
HTTP_X_FORWARDED_HOST is present in request.META.
This causes issues for e.g. request.build_absolute_uri() if the django app
is running behind a reverse proxy on a non-standard port.
Example would be: nginx is listening on port 8443 and forwarding to a
django server listening on port 8001:
{{{
server {
listen 8443 ssl;
server_name localhost.example.com
location / {
proxy_pass http://localhost:8001;
# include /etc/nginx/uwsgi_params;
proxy_cache_bypass $http_upgrade;
proxy_set_header Upgrade $http_upgrade;
proxy_set_header Connection "upgrade";
proxy_set_header Host $host;
proxy_set_header X-Real-IP $remote_addr;
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
proxy_set_header X-Forwarded-Proto $scheme;
proxy_set_header X-Forwarded-Host $host;
proxy_set_header X-Forwarded-Port $server_port;
}
}
}}}
In this case URIs built with request.build_absolute_uri() in a django app
will exclude the port, i.e.:
{{{request.build_django_uri("/") == "https://localhost.example.com/"}}}
where it should return "https://localhost.example.com:8443/"
--
Ticket URL: <https://code.djangoproject.com/ticket/31354>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
does not include the port
-------------------------------------+-------------------------------------
Reporter: dgcgh | Owner: nobody
Type: Bug | Status: new
Severity: Normal | Resolution:
Keywords: request get_host | Triage Stage:
build_absolute_uri | Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by dgcgh):
PR: https://github.com/django/django/pull/12550
--
Ticket URL: <https://code.djangoproject.com/ticket/31354#comment:1>
Django
does not include the port
-------------------------------------+-------------------------------------
Type: Bug | Status: assigned
Component: Uncategorized | Version: 3.0
Severity: Normal | Resolution:
Keywords: request get_host | Triage Stage:
build_absolute_uri | Unreviewed
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* owner: nobody => dgcgh
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/31354#comment:2>
Django
does not include the port
-------------------------------------+-------------------------------------
Type: Bug | Status: assigned
Component: Uncategorized | Version: 3.0
Severity: Normal | Resolution:
Keywords: request get_host | Triage Stage:
build_absolute_uri | Unreviewed
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by dgcgh):
I think the problem here might be that django assumes X-Forwarded-Host
will include the port number, as opposed to putting the port number in X
-Forwarded-Port.
I can get the correct behavior by setting the nginx header as:
{{{
proxy_set_header X-Forwarded-Host $host:$server_port;
}}}
and disabling `USE_X_FORWARDED_PORT` .
I take it that `X-Forwarded-Port` is not popular, so maybe this bug is not
worth fixing, but I will update my PR with a more explicit solution.
--
Ticket URL: <https://code.djangoproject.com/ticket/31354#comment:3>
Django
does not include the port
-------------------------------------+-------------------------------------
Type: Bug | Status: assigned
Component: Uncategorized | Version: 3.0
Severity: Normal | Resolution:
Keywords: request get_host | Triage Stage:
build_absolute_uri | Unreviewed
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Florian Apolloner):
LGTM, ses my comment on the PR for a small change.
--
Ticket URL: <https://code.djangoproject.com/ticket/31354#comment:4>
Django
META['HTTP_X_FORWARDED_PORT'].
-------------------------------------+-------------------------------------
Reporter: dgcgh | Owner: dgcgh
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: request get_host | Triage Stage: Accepted
build_absolute_uri |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* component: Uncategorized => HTTP handling
* version: 3.0 => master
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/31354#comment:5>
Django
META['HTTP_X_FORWARDED_PORT'].
-------------------------------------+-------------------------------------
Reporter: dgcgh | Owner: dgcgh
Type: Bug | Status: assigned
Component: HTTP handling | Version: master
Severity: Normal | Resolution:
Keywords: request get_host | Triage Stage: Accepted
build_absolute_uri |
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/31354#comment:6>
Django
META['HTTP_X_FORWARDED_PORT'].
-------------------------------------+-------------------------------------
Reporter: dgcgh | Owner: dgcgh
Type: Bug | Status: assigned
Component: HTTP handling | Version: master
Severity: Normal | Resolution:
Keywords: request get_host | Triage Stage: Accepted
build_absolute_uri |
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_docs: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/31354#comment:7>
Django
META['HTTP_X_FORWARDED_PORT'].
-------------------------------------+-------------------------------------
Reporter: dgcgh | Owner: dgcgh
Type: Bug | Status: assigned
Component: HTTP handling | Version: master
Severity: Normal | Resolution:
Keywords: request get_host | Triage Stage: Accepted
build_absolute_uri |
Has patch: 1 | Needs documentation: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by felixxm):
[https://github.com/django/django/pull/12844 New PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/31354#comment:8>
Django
META['HTTP_X_FORWARDED_PORT'].
-------------------------------------+-------------------------------------
Type: Bug | Status: new
Component: HTTP handling | Version: dev
Severity: Normal | Resolution:
Keywords: request get_host | Triage Stage: Accepted
build_absolute_uri |
Has patch: 1 | Needs documentation: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* owner: dgcgh => (none)
* status: assigned => new
--
Ticket URL: <https://code.djangoproject.com/ticket/31354#comment:9>
Django
META['HTTP_X_FORWARDED_PORT'].
-------------------------------------+-------------------------------------
Reporter: dgcgh | Owner:
Type: Bug | Status: assigned
Component: HTTP handling | Version: dev
Severity: Normal | Resolution:
Keywords: request get_host | Triage Stage: Accepted
build_absolute_uri |
Has patch: 1 | Needs documentation: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* owner: (none) => LightChain09
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/31354#comment:10>
Django
META['HTTP_X_FORWARDED_PORT'].
-------------------------------------+-------------------------------------
Type: Bug | Status: new
Component: HTTP handling | Version: dev
Severity: Normal | Resolution:
Keywords: request get_host | Triage Stage: Accepted
build_absolute_uri |
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* owner: LightChain09 => (none)
* needs_docs: 1 => 0
* status: assigned => new
--
Ticket URL: <https://code.djangoproject.com/ticket/31354#comment:11>
Django
META['HTTP_X_FORWARDED_PORT'].
-------------------------------------+-------------------------------------
Reporter: dgcgh | Owner: (none)
Component: HTTP handling | Version: dev
Severity: Normal | Resolution:
Keywords: request get_host | Triage Stage: Accepted
build_absolute_uri |
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by LightChain09):
As far as I can see, there already is documentation about the patch, so I
changed the "Needs documentation" tag.
--
Ticket URL: <https://code.djangoproject.com/ticket/31354#comment:12>
Django
META['HTTP_X_FORWARDED_PORT'].
-------------------------------------+-------------------------------------
| K.V
Type: Bug | Status: assigned
Component: HTTP handling | Version: dev
Severity: Normal | Resolution:
Keywords: request get_host | Triage Stage: Accepted
build_absolute_uri |
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* owner: (none) => SREEHARI K.V
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/31354#comment:13>
Django
META['HTTP_X_FORWARDED_PORT'].
-------------------------------------+-------------------------------------
Reporter: dgcgh | Owner: SREEHARI
| K.V
Type: Bug | Status: assigned
Component: HTTP handling | Version: dev
Severity: Normal | Resolution:
Keywords: request get_host | Triage Stage: Accepted
build_absolute_uri |
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):
* easy: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/31354#comment:14>
Django
META['HTTP_X_FORWARDED_PORT'].
-------------------------------------+-------------------------------------
Reporter: dgcgh | Owner: SREEHARI
| K.V
Type: Bug | Status: assigned
Component: HTTP handling | Version: dev
Severity: Normal | Resolution:
Keywords: request get_host | Triage Stage: Accepted
build_absolute_uri |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by SREEHARI K.V):
I'd like to work on this bug.
I notice that https://github.com/django/django/pull/12844 has been closed
due to inactivity.
Can I pick up where Apollo13 left off or start from scratch?
--
Ticket URL: <https://code.djangoproject.com/ticket/31354#comment:15>
Django
META['HTTP_X_FORWARDED_PORT'].
-------------------------------------+-------------------------------------
Reporter: dgcgh | Owner: SREEHARI
| K.V
Type: Bug | Status: assigned
Component: HTTP handling | Version: dev
Severity: Normal | Resolution:
Keywords: request get_host | Triage Stage: Accepted
build_absolute_uri |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Jacob Walls):
Ordinarily yes, you can start from a previous attempt and credit the prior
author as a [https://docs.github.com/en/github/committing-changes-to-your-
project/creating-and-editing-commits/creating-a-commit-with-multiple-
authors co-author] in the commit message.
--
Ticket URL: <https://code.djangoproject.com/ticket/31354#comment:16>
Django
META['HTTP_X_FORWARDED_PORT'].
-------------------------------------+-------------------------------------
Type: Bug | Status: new
Component: HTTP handling | Version: dev
Severity: Normal | Resolution:
Keywords: request get_host | Triage Stage: Accepted
build_absolute_uri |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* owner: SREEHARI K.V => (none)
* status: assigned => new
--
Ticket URL: <https://code.djangoproject.com/ticket/31354#comment:17>
Django
META['HTTP_X_FORWARDED_PORT'].
-------------------------------------+-------------------------------------
Reporter: dgcgh | Owner: (none)
Component: HTTP handling | Version: dev
Severity: Normal | Resolution:
Keywords: request get_host | Triage Stage: Accepted
build_absolute_uri |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mateusz Kurowski):
Hello, i seen multiple pull requests that have their origin in this issue
- when it comes to host and port with proxy protocol - does it need some
big rewrite in the django source?
--
Ticket URL: <https://code.djangoproject.com/ticket/31354#comment:18>
Django
META['HTTP_X_FORWARDED_PORT'].
-------------------------------------+-------------------------------------
Reporter: dgcgh | Owner: (none)
Severity: Normal | Resolution:
Keywords: request get_host | Triage Stage: Accepted
build_absolute_uri |
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* cc: Ülgen Sarıkavak (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/31354#comment:19>
Django
META['HTTP_X_FORWARDED_PORT'].
-------------------------------------+-------------------------------------
Reporter: dgcgh | Owner: (none)
Severity: Normal | Resolution:
Keywords: request get_host | Triage Stage: Accepted
build_absolute_uri |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* cc: Calvin Vu (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/31354#comment:20>
Django
META['HTTP_X_FORWARDED_PORT'].
-------------------------------------+-------------------------------------
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: request get_host | Triage Stage: Accepted
build_absolute_uri |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Calvin Vu):
Ticket URL: <https://code.djangoproject.com/ticket/31354#comment:21>
Django
META['HTTP_X_FORWARDED_PORT'].
-------------------------------------+-------------------------------------
Reporter: dgcgh | Owner: Calvin Vu
Type: Bug | Status: assigned
Component: HTTP handling | Version: dev
Severity: Normal | Resolution:
Keywords: request get_host | Triage Stage: Accepted
build_absolute_uri |
-------------------------------------+-------------------------------------
* needs_better_patch: 1 => 0
Comment:
[https://github.com/django/django/pull/18835 New PR] is available, and
looks like it hasn't been reviewed so I'm removing the "patch needs
improvement" flag.
--
Ticket URL: <https://code.djangoproject.com/ticket/31354#comment:22>
Django
META['HTTP_X_FORWARDED_PORT'].
-------------------------------------+-------------------------------------
Reporter: dgcgh | Owner: Calvin Vu
Type: Bug | Status: assigned
Component: HTTP handling | Version: dev
Severity: Normal | Resolution:
Keywords: request get_host | Triage Stage: Accepted
build_absolute_uri |
Needs tests: 0 | Patch needs improvement: 1
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
Ticket URL: <https://code.djangoproject.com/ticket/31354#comment:23>