[Django] #30693: Refatoring django.core.management.templates

8 views
Skip to first unread message

Django

unread,
Aug 9, 2019, 8:01:08 AM8/9/19
to django-...@googlegroups.com
#30693: Refatoring django.core.management.templates
-------------------------------------+-------------------------------------
Reporter: Diaga | Owner: Diaga
Type: | Status: assigned
Cleanup/optimization |
Component: Core | Version: 2.2
(Management commands) | Keywords: core management
Severity: Normal | templates
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
-------------------------------------+-------------------------------------
'path' module is being used as an absolute import as well as relative
import.
Proposing to remove the relative import and refactor all relative imports
to absolute imports.
e.g from 'path.join(some_path)' to 'os.path.join(some_path)'

--
Ticket URL: <https://code.djangoproject.com/ticket/30693>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Aug 9, 2019, 8:52:38 AM8/9/19
to django-...@googlegroups.com
#30693: Refatoring django.core.management.templates
-------------------------------------+-------------------------------------
Reporter: Maaz Bin Tahir | Owner: Maaz Bin
Saeed | Tahir Saeed
Type: | Status: assigned
Cleanup/optimization |
Component: Core (Management | Version: 2.2
commands) |
Severity: Normal | Resolution:
Keywords: core management | Triage Stage:
templates | Unreviewed
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Description changed by Maaz Bin Tahir Saeed:

Old description:

> 'path' module is being used as an absolute import as well as relative
> import.
> Proposing to remove the relative import and refactor all relative imports
> to absolute imports.
> e.g from 'path.join(some_path)' to 'os.path.join(some_path)'

New description:

'path' module is being used as an absolute import as well as relative
import.
Proposing to remove the relative import and refactor all relative imports
to absolute imports.
e.g from 'path.join(some_path)' to 'os.path.join(some_path)'

Proposed changes: https://github.com/Diaga/django/tree/ticket_30693

--

--
Ticket URL: <https://code.djangoproject.com/ticket/30693#comment:1>

Django

unread,
Aug 10, 2019, 6:16:40 AM8/10/19
to django-...@googlegroups.com
#30693: Refatoring django.core.management.templates
-------------------------------------+-------------------------------------

Reporter: Maaz Bin Tahir | Owner: Maaz Bin
Saeed | Tahir Saeed
Type: | Status: assigned
Cleanup/optimization |
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Keywords: core management | Triage Stage: Accepted
templates |
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):

* version: 2.2 => master
* stage: Unreviewed => Accepted


Comment:

Hiya, yes this seems reasonable enough to me. Thanks.

--
Ticket URL: <https://code.djangoproject.com/ticket/30693#comment:2>

Django

unread,
Aug 10, 2019, 6:20:06 AM8/10/19
to django-...@googlegroups.com
#30693: Refatoring django.core.management.templates
-------------------------------------+-------------------------------------

Reporter: Maaz Bin Tahir | Owner: Maaz Bin
Saeed | Tahir Saeed
Type: | Status: assigned
Cleanup/optimization |

Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Keywords: core management | Triage Stage: Ready for
templates | checkin
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):

* stage: Accepted => Ready for checkin


Comment:

Looks good. Just needs a squash and a final look before merging.

--
Ticket URL: <https://code.djangoproject.com/ticket/30693#comment:3>

Django

unread,
Aug 19, 2019, 7:28:03 AM8/19/19
to django-...@googlegroups.com
#30693: Refatoring django.core.management.templates
-------------------------------------+-------------------------------------

Reporter: Maaz Bin Tahir | Owner: Maaz Bin
Saeed | Tahir Saeed
Type: | Status: closed

Cleanup/optimization |
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution: fixed

Keywords: core management | Triage Stage: Ready for
templates | checkin
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson <carlton.gibson@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"e9f74f53ccbf897ed69a484f35d616e1914d2c90" e9f74f5]:
{{{
#!CommitTicketReference repository=""
revision="e9f74f53ccbf897ed69a484f35d616e1914d2c90"
Fixed #30693 -- Removed separate import of os.path in
django.core.management.templates.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/30693#comment:4>

Reply all
Reply to author
Forward
0 new messages