Re: [Django] #5437: Make GDAL optional for GIS test runner
Django
-------------------------+--------------------------------------
Reporter: rcoup | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: testing | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------+--------------------------------------
Changes (by shai):
* status: closed => new
* severity: => Normal
* type: => Bug
* version: gis => master
* easy: => 0
* keywords: sprint => testing
* ui_ux: => 0
* resolution: fixed =>
Comment:
This has apparently made a comeback; when running the tests without GDAL
on master now, I get:
{{{#!python
Importing application geoadmin
Traceback (most recent call last):
File "runtests.py", line 379, in <module>
options.failfast, args)
File "runtests.py", line 198, in django_tests
state = setup(verbosity, test_labels)
File "runtests.py", line 172, in setup
app_config.import_models(apps.all_models[app_config.label])
File ".../django/apps/base.py", line 160, in import_models
self.models_module = import_module(models_module_name)
File "/usr/lib/python2.7/importlib/__init__.py", line 37, in
import_module
__import__(name)
File ".../django/contrib/gis/tests/geoadmin/models.py", line 19, in
<module>
admin.site.register(City, admin.OSMGeoAdmin)
AttributeError: 'module' object has no attribute 'OSMGeoAdmin'
}}}
OSMGeoAdmin requires GDAL, and it is used unconditionally in a test.
As far as I could see, this goes back to the introduction of the
`geoadmin/models.py` file, back in September 2011, so although it is a
regression, it has probably been this way since 1.4. On one hand, this
means it is not a release blocker; on the other hand, this probably
justifies backporting the fix to all the live versions.
--
Ticket URL: <https://code.djangoproject.com/ticket/5437#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------+------------------------------------
Type: Bug | Status: new
Component: GIS | Version: master
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------+------------------------------------
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/5437#comment:4>
Django
-------------------------+------------------------------------
Reporter: rcoup | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: testing | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------+------------------------------------
Comment (by vlal):
Issued [https://github.com/django/django/pull/2516 Pull Request #5437].
Verified tests either pass or skip when necessary.
--
Ticket URL: <https://code.djangoproject.com/ticket/5437#comment:5>
Django
-------------------------+------------------------------------
Type: Bug | Status: assigned
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: testing | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------+------------------------------------
* owner: nobody => vlal
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/5437#comment:6>
Django
-------------------------+------------------------------------
Reporter: rcoup | Owner: vlal
Type: Bug | Status: assigned
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: testing | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------+------------------------------------
Comment (by claudep):
Thanks for the patch. But frankly, when I see that, I'm really tempted to
make GDAL a required part of our GIS infrastructure. I think that in the
past, GDAL was not so easily installable, but that limitation may be moot
now. It might be worth debating this on django-dev mailing list.
--
Ticket URL: <https://code.djangoproject.com/ticket/5437#comment:7>
Django
-------------------------+------------------------------------
Reporter: rcoup | Owner: vlal
Type: Bug | Status: assigned
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: testing | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------+------------------------------------
* cc: vlal (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/5437#comment:8>
Django
-------------------------+------------------------------------
Reporter: rcoup | Owner: vlal
Type: Bug | Status: assigned
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: testing | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------+------------------------------------
Comment (by vlal):
Posted on django-dev mailing list [https://groups.google.com/forum/#!topic
/django-developers/jr6WQ94JRoQ here]
--
Ticket URL: <https://code.djangoproject.com/ticket/5437#comment:9>
Django
-------------------------+------------------------------------
Reporter: rcoup | Owner: vlal
Component: GIS | Version: master
Severity: Normal | Resolution: wontfix
Keywords: testing | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------+------------------------------------
* status: assigned => closed
* resolution: => wontfix
Comment:
Given the lack of interest, I'm going to close this as "won't fix."
--
Ticket URL: <https://code.djangoproject.com/ticket/5437#comment:10>