Re: [Django] #15318: A possibility to configure the language's cookie domain and expires.

[Django]

#15318: A possibility to configure the language's cookie domain and expires.
-------------------------------------+-------------------------------------
Reporter: sahid | Owner:
Type: New feature | sergeykolosov
Component: | Status: assigned
Internationalization | Version: 1.2
Severity: Normal | Resolution:
Keywords: cookie, domain, | Triage Stage: Accepted
language, settings | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 1
Needs tests: 1 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by sergeykolosov):

* status: new => assigned
* owner: nobody => sergeykolosov

--
Ticket URL: <https://code.djangoproject.com/ticket/15318#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#15318: A possibility to configure the language's cookie domain and expires.
-------------------------------------+-------------------------------------
Reporter: sahid | Owner:
Type: New feature | sergeykolosov
Component: | Status: assigned
Internationalization | Version: 1.2
Severity: Normal | Resolution:
Keywords: cookie, domain, | Triage Stage: Accepted
language, settings | Needs documentation: 0

Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0

Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by sergeykolosov):

* needs_better_patch: 1 => 0
* needs_tests: 1 => 0

Comment:

Pull request: https://github.com/django/django/pull/1150

For the sake of consistency I've added the following settings:
LANGUAGE_COOKIE_AGE, LANGUAGE_COOKIE_PATH and LANGUAGE_COOKIE_DOMAIN.

--
Ticket URL: <https://code.djangoproject.com/ticket/15318#comment:7>

[Django]

#15318: A possibility to configure the language's cookie domain and expires.
-------------------------------------+-------------------------------------
Reporter: sahid | Owner:
Type: New feature | sergeykolosov
Component: | Status: assigned
Internationalization | Version: 1.2
Severity: Normal | Resolution:
Keywords: cookie, domain, | Triage Stage: Accepted
language, settings | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Comment (by ramiro):

This could be solved without introducing additional top-level settings
if/after #21051 lands.

--
Ticket URL: <https://code.djangoproject.com/ticket/15318#comment:8>

[Django]

#15318: A possibility to configure the language's cookie domain and expires.
-------------------------------------+-------------------------------------
Reporter: sahid | Owner:
Type: New feature | sergeykolosov
Component: | Status: assigned
Internationalization | Version: 1.2
Severity: Normal | Resolution:
Keywords: cookie, domain, | Triage Stage: Accepted
language, settings | Needs documentation: 0

Has patch: 1 | Patch needs improvement: 1

Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Changes (by timo):

* needs_better_patch: 0 => 1

Comment:

I've left comments for improvement on the PR. Please uncheck "Patch needs
improvement" when it's updated.

--
Ticket URL: <https://code.djangoproject.com/ticket/15318#comment:9>

[Django]

#15318: A possibility to configure the language's cookie domain and expires.
-------------------------------------+-------------------------------------
Reporter: sahid | Owner:
Type: New feature | sergeykolosov
Component: | Status: assigned
Internationalization | Version: 1.2
Severity: Normal | Resolution:
Keywords: cookie, domain, | Triage Stage: Accepted
language, settings | Needs documentation: 0

Has patch: 1 | Patch needs improvement: 0

Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Changes (by sergeykolosov):

* needs_better_patch: 1 => 0

Comment:

Pull request is updated: https://github.com/django/django/pull/1150

--
Ticket URL: <https://code.djangoproject.com/ticket/15318#comment:10>

[Django]

#15318: A possibility to configure the language's cookie domain and expires.
-------------------------------------+-------------------------------------
Reporter: sahid | Owner:
Type: New feature | sergeykolosov

Component: | Status: closed
Internationalization | Version: 1.2
Severity: Normal | Resolution: fixed

Keywords: cookie, domain, | Triage Stage: Accepted
language, settings | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"8c98f39624a60c63a16e097b64e5f71ecc27271f"]:
{{{
#!CommitTicketReference repository=""
revision="8c98f39624a60c63a16e097b64e5f71ecc27271f"
Fixed #15318 -- Added settings for language cookie max-age, path, domain

Introduced a number of settings to configure max-age, path, and domain
for the language cookie: LANGUAGE_COOKIE_AGE, LANGUAGE_COOKIE_PATH and
LANGUAGE_COOKIE_DOMAIN.

Thanks sahid for the suggestion.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/15318#comment:11>