[Django] #24621: request.session.pop's second param is not documented
Django
-------------------------------+--------------------
Reporter: gabor | Owner: nobody
Type: Uncategorized | Status: new
Component: Documentation | Version: 1.8
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------
python dictionaries support the pop method's second parameter, for example
`{}.pop('key','default')` .
the django session seems to support this second parameter too, but the
documentation does not mention it, so i'm not sure if i can use it or not.
--
Ticket URL: <https://code.djangoproject.com/ticket/24621>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: gabor | Owner: nobody
Type: Bug | Status: new
Component: Documentation | Version: 1.8
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------+------------------------------------
Changes (by timgraham):
* needs_better_patch: => 0
* needs_tests: => 0
* easy: 0 => 1
* needs_docs: => 0
* type: Uncategorized => Bug
* stage: Unreviewed => Accepted
Comment:
I think it's just an oversite in the docs as the behavior is tested.
--
Ticket URL: <https://code.djangoproject.com/ticket/24621#comment:1>
Django
Reporter: gabor | Owner: adamzap
Type: Bug | Status: assigned
Component: Documentation | Version: 1.8
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------+------------------------------------
* status: new => assigned
* owner: nobody => adamzap
--
Ticket URL: <https://code.djangoproject.com/ticket/24621#comment:2>
Django
Reporter: gabor | Owner: adamzap
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------+------------------------------------
Changes (by adamzap):
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/24621#comment:3>
Django
Reporter: gabor | Owner: priidukull
Type: Bug | Status: assigned
Component: Documentation | Version: 1.8
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by priidukull):
* owner: adamzap => priidukull
--
Ticket URL: <https://code.djangoproject.com/ticket/24621#comment:4>
Django
Reporter: gabor | Owner: adamzap
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by adamzap):
* owner: priidukull => adamzap
Comment:
I've got this one, priidukull. I'll remove myself as owner if I'm not able
to close it. Thanks!
Discussion is happening here: https://github.com/django/django/pull/4480
--
Ticket URL: <https://code.djangoproject.com/ticket/24621#comment:5>
Django
Reporter: gabor | Owner: adamzap
Component: Documentation | Version: 1.8
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------+------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"872eb26f542caead338d6456b345ca2f5c0684e2" 872eb26]:
{{{
#!CommitTicketReference repository=""
revision="872eb26f542caead338d6456b345ca2f5c0684e2"
Fixed #24621 -- Fixed and documented SessionBase.pop's second argument
Changed SessionBase.pop's second argument to explicitly be default=None
rather than *args since _session is always a dict. Thanks gabor for the
report and Tim Graham for the review.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24621#comment:6>
Django
Reporter: gabor | Owner: adamzap
Type: Bug | Status: closed
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------+------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"973f393761253f5fbf031f435d103545f1927041" 973f3937]:
{{{
#!CommitTicketReference repository=""
revision="973f393761253f5fbf031f435d103545f1927041"
Refs #24621 -- Added a test for SessionBase.pop()'s 'default' argument.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24621#comment:7>
Django
Reporter: gabor | Owner: adamzap
Type: Bug | Status: closed
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------+------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"ebb55a247c0f060f3e2cf0e363137106385bda0f" ebb55a24]:
{{{
#!CommitTicketReference repository=""
revision="ebb55a247c0f060f3e2cf0e363137106385bda0f"
[1.9.x] Refs #24621 -- Added a test for SessionBase.pop()'s 'default'
argument.
Backport of 973f393761253f5fbf031f435d103545f1927041 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24621#comment:8>