[Django] #27533: inspectdb command crashes when generate model classes from postgres db

51 views
Skip to first unread message

Django

unread,
Nov 24, 2016, 7:15:42 PM11/24/16
to django-...@googlegroups.com
#27533: inspectdb command crashes when generate model classes from postgres db
----------------------------------------+------------------------
Reporter: Wei Ma | Owner: nobody
Type: Bug | Status: new
Component: Core (Other) | Version: 1.10
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
----------------------------------------+------------------------
inspectdb command crashes when I try to generate model classes from
postgres db.

the command I used was
python manage.py inspectdb > all_models.py

the error I got was:

File "/xxx/env/lib/python3.5/site-
packages/django/core/management/commands/inspectdb.py", line 278, in
<genexpr>
tup = '(' + ', '.join("'%s'" % column_to_field_name[c] for c in
columns) + ')'
KeyError: None

--
Ticket URL: <https://code.djangoproject.com/ticket/27533>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Nov 24, 2016, 7:17:49 PM11/24/16
to django-...@googlegroups.com
#27533: inspectdb command crashes when generate model classes from postgres db
------------------------------+--------------------------------------

Reporter: Wei Ma | Owner: nobody
Type: Bug | Status: new
Component: Core (Other) | Version: 1.10
Severity: Normal | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
------------------------------+--------------------------------------

Comment (by Wei Ma):

I created a PR https://github.com/django/django/pull/7618 for this bug.

--
Ticket URL: <https://code.djangoproject.com/ticket/27533#comment:1>

Django

unread,
Nov 27, 2016, 11:17:12 PM11/27/16
to django-...@googlegroups.com
#27533: inspectdb command crashes when generate model classes from postgres db
------------------------------+--------------------------------------

Reporter: Wei Ma | Owner: nobody
Type: Bug | Status: new
Component: Core (Other) | Version: 1.10
Severity: Normal | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
------------------------------+--------------------------------------

Comment (by Max Resnick):

Adding "Needs Tests" flag per PR
Comment[https://github.com/django/django/pull/7618#issuecomment-263023058]

--
Ticket URL: <https://code.djangoproject.com/ticket/27533#comment:2>

Django

unread,
Nov 28, 2016, 7:09:43 AM11/28/16
to django-...@googlegroups.com
#27533: inspectdb crashes on unsupported unique_together constraints in PostgreSQL
-------------------------------------+-------------------------------------

Reporter: Wei Ma | Owner: nobody
Type: Bug | Status: new
Component: Database layer | Version: 1.10
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* stage: Unreviewed => Accepted
* component: Core (Other) => Database layer (models, ORM)
* needs_tests: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/27533#comment:3>

Django

unread,
Nov 29, 2016, 2:15:44 PM11/29/16
to django-...@googlegroups.com
#27533: inspectdb crashes on unsupported unique_together constraints in PostgreSQL
-------------------------------------+-------------------------------------
Reporter: Wei Ma | Owner: nobody
Type: Bug | Status: new
Component: Database layer | Version: 1.10
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Wei Ma):

I have closed my PR https://github.com/django/django/pull/7618 due to not
able to create test cases. If anyone want to help, please fork my repo
and add needed tests.

--
Ticket URL: <https://code.djangoproject.com/ticket/27533#comment:4>

Django

unread,
Dec 13, 2016, 9:59:49 AM12/13/16
to django-...@googlegroups.com
#27533: inspectdb crashes on unsupported unique_together constraints in PostgreSQL
-------------------------------------+-------------------------------------
Reporter: Wei Ma | Owner: Michael
| Sinov
Type: Bug | Status: assigned

Component: Database layer | Version: 1.10
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Michael Sinov):

* owner: nobody => Michael Sinov
* status: new => assigned
* needs_tests: 1 => 0


Comment:

[https://github.com/django/django/pull/7683 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/27533#comment:5>

Django

unread,
Mar 1, 2017, 3:25:40 PM3/1/17
to django-...@googlegroups.com
#27533: inspectdb crashes on unsupported unique_together constraints in PostgreSQL
-------------------------------------+-------------------------------------
Reporter: Wei Ma | Owner: Michael
| Sinov
Type: Bug | Status: assigned
Component: Database layer | Version: 1.10
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):

* needs_better_patch: 0 => 1
* has_patch: 1 => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/27533#comment:6>

Django

unread,
Mar 1, 2017, 3:26:13 PM3/1/17
to django-...@googlegroups.com
#27533: inspectdb crashes on unsupported unique_together constraints in PostgreSQL
-------------------------------------+-------------------------------------
Reporter: Wei Ma | Owner: Michael
| Sinov
Type: Bug | Status: assigned
Component: Database layer | Version: 1.10
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):

* has_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/27533#comment:7>

Django

unread,
Mar 21, 2018, 1:36:20 PM3/21/18
to django-...@googlegroups.com
#27533: inspectdb crashes on unsupported unique_together constraints in PostgreSQL
-------------------------------------+-------------------------------------
Reporter: Wei Ma | Owner: Michael
| Sinov
Type: Bug | Status: closed

Component: Database layer | Version: 1.10
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"9aca67bea8d42e6c1889f16e5ce297cfc23b91a2" 9aca67be]:
{{{
#!CommitTicketReference repository=""
revision="9aca67bea8d42e6c1889f16e5ce297cfc23b91a2"
Fixed #27533 -- Fixed inspectdb crash if a unique constraint uses an
unsupported type.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27533#comment:8>

Reply all
Reply to author
Forward
0 new messages