[Django] #21382: stacked inlines should add class "has_original" to existing fields
Django
-------------------------------+--------------------
Reporter: jrief | Owner: nobody
Type: Uncategorized | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------
In tabular inlines one can distinguish between new and existing fields,
because existing fields add the class {{{has_original}}} to their form
row.
In stacked inlines this is not possible, there no such class is added to
{{{div.inline-related}}}. This is inconsistent with tabular inlines and
makes it impossible to distinguish between new and existing fields.
This PR: https://github.com/django/django/pull/1865 fixes it.
--
Ticket URL: <https://code.djangoproject.com/ticket/21382>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: jrief | Owner: nobody
Type: Uncategorized | Status: new
Component: contrib.admin | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by akaariai):
* needs_better_patch: => 0
* needs_docs: => 0
* needs_tests: => 0
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/21382#comment:1>
Django
Reporter: jrief | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Changes (by carljm):
* type: Uncategorized => New feature
--
Ticket URL: <https://code.djangoproject.com/ticket/21382#comment:2>
Django
Reporter: jrief | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timo):
* needs_tests: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/21382#comment:3>
Django
Reporter: jrief | Owner: ryankask
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Changes (by ryankask):
* owner: nobody => ryankask
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/21382#comment:4>
Django
Reporter: jrief | Owner: ryankask
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Changes (by ryankask):
* needs_tests: 1 => 0
Comment:
I've created a new pull request with a test for the fix:
https://github.com/django/django/pull/2249 (the original pull request is
here: https://github.com/django/django/pull/1865)
--
Ticket URL: <https://code.djangoproject.com/ticket/21382#comment:5>
Django
Reporter: jrief | Owner: ryankask
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"d25622000ac8a591101ade28708d3b4b8ae4b24f"]:
{{{
#!CommitTicketReference repository=""
revision="d25622000ac8a591101ade28708d3b4b8ae4b24f"
Fixed #21382 - Added "has_original" to stacked inlines.
Report and original patch from jrief.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/21382#comment:6>