[Django] #25308: Initial migrations not created if no app provided and MIGRATION_MODULES[app] overridden
Django
MIGRATION_MODULES[app] overridden
----------------------------+--------------------
Reporter: jsatt | Owner: nobody
Type: Bug | Status: new
Component: Migrations | Version: 1.8
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
----------------------------+--------------------
The makemigrations command will falsely return 'No changed detected.' if
all of the following criteria are met:
* No initial migration exists for the app in question, but models are
defined
* settings.MIGRATION_MODULES is used to change to location of the
migrations for the app in question
* No app is explicitly provided when running the makemigrations management
command
This issue stems from the MigrationQuestioner.ask_initial not respecting
the MIGRATION_MODULES setting.
--
Ticket URL: <https://code.djangoproject.com/ticket/25308>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
MIGRATION_MODULES[app] overridden
Reporter: jsatt | Owner: jsatt
Type: Bug | Status: assigned
Component: Migrations | Version: 1.8
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by jsatt):
* owner: nobody => jsatt
* needs_better_patch: => 0
* status: new => assigned
* needs_tests: => 0
* needs_docs: => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/25308#comment:1>
Django
MIGRATION_MODULES[app] overridden
Reporter: jsatt | Owner: jsatt
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by jsatt):
* has_patch: 0 => 1
* version: 1.8 => master
* stage: Unreviewed => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/25308#comment:2>
Django
MIGRATION_MODULES[app] overridden
Reporter: jsatt | Owner: jsatt
Type: Bug | Status: assigned
Component: Migrations | Version: master
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by charettes):
* stage: Ready for checkin => Accepted
Comment:
Hi jsatt, thanks for the report and patch.
Please don't mark your own patch as RFC. Someone else has to review it and
mark it so.
--
Ticket URL: <https://code.djangoproject.com/ticket/25308#comment:3>
Django
MIGRATION_MODULES[app] overridden
Reporter: jsatt | Owner: jsatt
Component: Migrations | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"1175027641f512d33909cb766563328c6b171578" 1175027]:
{{{
#!CommitTicketReference repository=""
revision="1175027641f512d33909cb766563328c6b171578"
Fixed #25308 -- Made MigrationQuestioner respect MIGRATION_MODULES
setting.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25308#comment:4>