Re: [Django] #14492: Model proxy instance does not equal the respective model instance

12 views
Skip to first unread message

Django

unread,
Sep 27, 2011, 12:26:46 PM9/27/11
to django-...@googlegroups.com
#14492: Model proxy instance does not equal the respective model instance
-------------------------------------+-------------------------------------
Reporter: bruth | Owner: bruth
Type: Bug | Status: assigned
Milestone: 1.3 | Component: Database layer
Version: SVN | (models, ORM)
Resolution: | Severity: Normal
Triage Stage: Design | Keywords:
decision needed | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Changes (by thepapermen):

* cc: thepapermen (added)
* ui_ux: => 0
* easy: => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/14492#comment:13>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Apr 7, 2013, 1:22:02 PM4/7/13
to django-...@googlegroups.com
#14492: Model proxy instance does not equal the respective model instance
-------------------------------------+-------------------------------------
Reporter: bruth | Owner: bruth
Type: Bug | Status: assigned
Component: Database layer | Version: master
(models, ORM) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by Alex):

* stage: Design decision needed => Accepted


Comment:

I'm not sure this solution is correct, but the current situation
definitely is not, marking this as accepted.

--
Ticket URL: <https://code.djangoproject.com/ticket/14492#comment:15>

Django

unread,
Aug 16, 2013, 10:01:45 AM8/16/13
to django-...@googlegroups.com
#14492: Model proxy instance does not equal the respective model instance
-------------------------------------+-------------------------------------
Reporter: bruth | Owner: bruth
Type: Bug | Status: assigned
Component: Database layer | Version: master
(models, ORM) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Comment (by ryankask):

Since this ticket has been accepted again, I've added a new patch:
https://github.com/ryankask/django/compare/proxy-equality-14492

It would be great to get some feedback on the approach and how to handle
backwards compatibility.

--
Ticket URL: <https://code.djangoproject.com/ticket/14492#comment:16>

Django

unread,
Aug 16, 2013, 10:26:18 AM8/16/13
to django-...@googlegroups.com
#14492: Model proxy instance does not equal the respective model instance
-------------------------------------+-------------------------------------
Reporter: bruth | Owner: bruth
Type: Bug | Status: assigned
Component: Database layer | Version: master
(models, ORM) | Resolution:
Severity: Normal | Triage Stage: Ready for
Keywords: | checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timo):

* stage: Accepted => Ready for checkin


Comment:

Actually, there's already another
[https://github.com/django/django/pull/1478 pull request] open which
addresses this ticket.

--
Ticket URL: <https://code.djangoproject.com/ticket/14492#comment:17>

Django

unread,
Aug 16, 2013, 10:31:21 AM8/16/13
to django-...@googlegroups.com
#14492: Model proxy instance does not equal the respective model instance
-------------------------------------+-------------------------------------
Reporter: bruth | Owner: bruth
Type: Bug | Status: assigned
Component: Database layer | Version: master
(models, ORM) | Resolution:
Severity: Normal | Triage Stage: Ready for
Keywords: | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by bruth):

Great to see this finally ready to go in.

--
Ticket URL: <https://code.djangoproject.com/ticket/14492#comment:18>

Django

unread,
Aug 19, 2013, 2:59:01 AM8/19/13
to django-...@googlegroups.com
#14492: Model proxy instance does not equal the respective model instance
-------------------------------------+-------------------------------------
Reporter: bruth | Owner: bruth
Type: Bug | Status: closed

Component: Database layer | Version: master
(models, ORM) | Resolution: fixed

Severity: Normal | Triage Stage: Ready for
Keywords: | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by akaariai):

* status: assigned => closed
* resolution: => fixed


Comment:

Fixed in 4668c142dce77c6f29fb75532c1acfa1b2d322ff

--
Ticket URL: <https://code.djangoproject.com/ticket/14492#comment:19>

Reply all
Reply to author
Forward
0 new messages