[Django] #26326: Admin related object pop-ups not working

7 views
Skip to first unread message

Django

unread,
Mar 4, 2016, 1:45:40 PM3/4/16
to django-...@googlegroups.com
#26326: Admin related object pop-ups not working
-------------------------------+--------------------
Reporter: maceo | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.9
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------+--------------------
Instead of opening in a pop-up the related object change form opens in a
new window. After some investigation, the modification below has fixed
it. One of you lovely Django peoples please verify/patch. Thank you.

{{{

+++ b/contrib/admin/templates/admin/related_widget_wrapper.html
@@ -10,7 +10,7 @@
</a>
{% endif %}
{% if can_add_related %}
- <a class="related-widget-wrapper-link add-related" id="add_id_{{
name }}"
+ <a class="related-widget-wrapper-link add-another" id="add_id_{{
name }}"
href="{{ add_related_url }}?{{ url_params }}"
title="{% blocktrans %}Add another {{ model }}{%
endblocktrans %}">
<img src="{% static 'admin/img/icon-addlink.svg' %}" alt="{%
trans 'Add' %}"/>
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26326>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Mar 4, 2016, 2:16:08 PM3/4/16
to django-...@googlegroups.com
#26326: Admin related object pop-ups not working
-------------------------------+--------------------------------------

Reporter: maceo | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.9
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------+--------------------------------------
Changes (by timgraham):

* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0


Comment:

On which page are you opening the popup?

Are you running Django 1.9.3? A similar report was fixed in Django 1.9.1
(#25903).

--
Ticket URL: <https://code.djangoproject.com/ticket/26326#comment:1>

Django

unread,
Mar 5, 2016, 1:57:32 PM3/5/16
to django-...@googlegroups.com
#26326: Admin related object pop-ups not working
-------------------------------+--------------------------------------

Reporter: maceo | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.9
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------+--------------------------------------

Comment (by maceo):

Change user > Permissions > Groups

The style of the link to add a new group is also affected by the fix. I
will add a screenshot.

The version is 1.9.3 installed yesterday via pip. The project has nothing
on it except what was created by `startproject`

--
Ticket URL: <https://code.djangoproject.com/ticket/26326#comment:2>

Django

unread,
Mar 5, 2016, 1:59:09 PM3/5/16
to django-...@googlegroups.com
#26326: Admin related object pop-ups not working
-------------------------------+--------------------------------------

Reporter: maceo | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.9
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------+--------------------------------------
Changes (by maceo):

* Attachment "Screenshot-Change user | Django site admin - Mozilla
Firefox.png" added.

Django

unread,
Mar 5, 2016, 2:12:05 PM3/5/16
to django-...@googlegroups.com
#26326: Admin related object pop-ups not working
-------------------------------+--------------------------------------

Reporter: maceo | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.9
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------+--------------------------------------

Comment (by timgraham):

Have you tried a different browser? I cannot reproduce a problem in
Firefox or Chrome.

--
Ticket URL: <https://code.djangoproject.com/ticket/26326#comment:3>

Django

unread,
Mar 7, 2016, 7:10:22 AM3/7/16
to django-...@googlegroups.com
#26326: Admin related object pop-ups not working
-------------------------------+--------------------------------------
Reporter: maceo | Owner: nobody
Type: Bug | Status: closed
Component: contrib.admin | Version: 1.9
Severity: Normal | Resolution: worksforme
Keywords: | Triage Stage: Unreviewed

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------------------------
Changes (by timgraham):

* status: new => closed
* resolution: => worksforme
* easy: 1 => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/26326#comment:4>

Reply all
Reply to author
Forward
0 new messages