[Django] #24983: "domain" in sites framework should clarify if it is a fully-qualified domain name
Django
domain name
--------------------------------------+--------------------
Reporter: mandm | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 1.8
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+--------------------
The documents on sites framework should clarify that the
[https://docs.djangoproject.com/en/1.8/ref/contrib/sites/#django.contrib.sites.models.Site.domain
"domain"] should be a "fully qualified domain name" or just the "domain
name".
An example where things can be confusing:
I have a setup where all requests to non-www domain i.e.
`http://example.com` are redirected (with status 301) to
`http://www.example.com` by the webserver. Hence I've set my preferred
site in google webmasters tool as `www.example.com` (as opposed to
`example.com`). When I use the sitemap framework, the urls generated are
`http://example.com/abc` which is incorrect in my case. This makes me
think that the domain in sites framework should have been
`www.example.com` (instead of `example.com`). This is not evident from the
documentation.
--
Ticket URL: <https://code.djangoproject.com/ticket/24983>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
domain name
Reporter: mandm | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 1.8
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by timgraham):
* needs_better_patch: => 0
* needs_docs: => 0
* needs_tests: => 0
* easy: 0 => 1
* stage: Unreviewed => Accepted
Comment:
Yes, I believe it should be fully-qualified. On djangoproject.com, for
example, we have the domains docs.djangoproject.com and
www.djangoproject.com.
--
Ticket URL: <https://code.djangoproject.com/ticket/24983#comment:1>
Django
domain name
Reporter: mandm | Owner:
Type: | bipsandbytes
Cleanup/optimization | Status: assigned
Component: Documentation | Version: 1.8
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by bipsandbytes):
* status: new => assigned
* owner: nobody => bipsandbytes
--
Ticket URL: <https://code.djangoproject.com/ticket/24983#comment:2>
Django
domain name
Reporter: mandm | Owner:
Type: | bipsandbytes
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by bipsandbytes):
Fixed in [https://github.com/bipsandbytes/django/tree/ticket_24983]
--
Ticket URL: <https://code.djangoproject.com/ticket/24983#comment:3>
Django
domain name
Reporter: mandm | Owner:
Type: | bipsandbytes
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by bipsandbytes):
Pull request here: https://github.com/django/django/pull/4903
--
Ticket URL: <https://code.djangoproject.com/ticket/24983#comment:4>
Django
domain name
Reporter: mandm | Owner:
Type: | bipsandbytes
Component: Documentation | Version: 1.8
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"34047b23e284fd3459903294a5776b67c3e33ed9" 34047b2]:
{{{
#!CommitTicketReference repository=""
revision="34047b23e284fd3459903294a5776b67c3e33ed9"
Fixed #24983 -- Clarified contrib.sites Site.domain is fully qualified.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24983#comment:5>
Django
domain name
Reporter: mandm | Owner:
Type: | bipsandbytes
Cleanup/optimization | Status: closed
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"6aa618bae35d7f7f8b9b270a4da7afa97512c40d" 6aa618ba]:
{{{
#!CommitTicketReference repository=""
revision="6aa618bae35d7f7f8b9b270a4da7afa97512c40d"
[1.8.x] Fixed #24983 -- Clarified contrib.sites Site.domain is fully
qualified.
Backport of 34047b23e284fd3459903294a5776b67c3e33ed9 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24983#comment:6>