[Django] #23260: unordered_list filter doesn't work with generators
Django
---------------------------------+--------------------
Reporter: jaap3 | Owner: nobody
Type: Bug | Status: new
Component: Template system | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+--------------------
Using the `unorderd_list` template filter on a generator raises
`TypeError: object of type 'generator' has no len()`
--
Ticket URL: <https://code.djangoproject.com/ticket/23260>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: jaap3 | Owner: jaap3
Type: Bug | Status: assigned
Component: Template system | Version: master
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by jaap3):
* status: new => assigned
* needs_better_patch: => 0
* needs_tests: => 0
* owner: nobody => jaap3
* needs_docs: => 0
* has_patch: 0 => 1
Old description:
> Using the `unorderd_list` template filter on a generator raises
> `TypeError: object of type 'generator' has no len()`
New description:
Created a pull request:
https://github.com/django/django/pull/3034
--
--
Ticket URL: <https://code.djangoproject.com/ticket/23260#comment:1>
Django
Reporter: jaap3 | Owner: jaap3
Type: Bug | Status: assigned
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Description changed by jaap3:
Old description:
> Created a pull request:
> https://github.com/django/django/pull/3034
New description:
Using the `unorderd_list` template filter on a generator raises
`TypeError: object of type 'generator' has no len()`
Created a pull request:
https://github.com/django/django/pull/3034
--
--
Ticket URL: <https://code.djangoproject.com/ticket/23260#comment:2>
Django
Reporter: jaap3 | Owner: jaap3
Type: Bug | Status: assigned
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/23260#comment:3>
Django
Reporter: jaap3 | Owner: jaap3
Type: Bug | Status: assigned
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: 0 => 1
Comment:
There are some test failures on Python 3.
--
Ticket URL: <https://code.djangoproject.com/ticket/23260#comment:4>
Django
Reporter: jaap3 | Owner: jaap3
Type: Bug | Status: assigned
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by jaap3):
* needs_better_patch: 1 => 0
Comment:
Forgot to test in Python 3, pushed a new patch that fixes the tests.
--
Ticket URL: <https://code.djangoproject.com/ticket/23260#comment:5>
Django
Reporter: jaap3 | Owner: jaap3
Component: Template system | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"b3660d28f3422a33a84de7a7ccad404b3135a1a8"]:
{{{
#!CommitTicketReference repository=""
revision="b3660d28f3422a33a84de7a7ccad404b3135a1a8"
Fixed #23260: Added generator support to defaultfilters.unordered_list.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/23260#comment:6>
Django
Reporter: Jaap Roes | Owner: Jaap Roes
Type: Bug | Status: closed
Component: Template system | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"b21b1b10af0bbe0498193881520efb02897bd444" b21b1b10]:
{{{
#!CommitTicketReference repository=""
revision="b21b1b10af0bbe0498193881520efb02897bd444"
Refs #23260 -- Tested nested generator input to unordered_list template
filter.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/23260#comment:7>
Django
Reporter: Jaap Roes | Owner: Jaap Roes
Type: Bug | Status: closed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"673427d3fca2a6635d067d01c01fd42fc1a1ab76" 673427d3]:
{{{
#!CommitTicketReference repository=""
revision="673427d3fca2a6635d067d01c01fd42fc1a1ab76"
[2.0.x] Refs #23260 -- Tested nested generator input to unordered_list
template filter.
Backport of b21b1b10af0bbe0498193881520efb02897bd444 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/23260#comment:8>