Re: [Django] #14722: @last_modified should ignore lack of etag method when USE_ETAGS is enabled

[Django]

#14722: @last_modified should ignore lack of etag method when USE_ETAGS is enabled
------------------------------+------------------------------------
Reporter: lamby | Owner: nobody
Type: Bug | Status: new
Component: Core (Other) | Version: 1.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
------------------------------+------------------------------------
Changes (by claudep):

* needs_better_patch: 1 => 0
* needs_tests: 1 => 0

Comment:

They were several issues related with condition decorator and the
USE_ETAGS setting. Just run tests (especially conditional_processing) with
USE_ETAGS=True in your settings to reveal errors.

My patch is solving these issues and also factorizes ETag generation at
the response object level.

--
Ticket URL: <https://code.djangoproject.com/ticket/14722#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#14722: @last_modified should ignore lack of etag method when USE_ETAGS is enabled

-------------------------------+------------------------------------

Reporter: lamby | Owner: nobody
Type: Bug | Status: new

Component: HTTP handling | Version: 1.2

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------+------------------------------------
Changes (by aaugustin):

* component: Core (Other) => HTTP handling

--
Ticket URL: <https://code.djangoproject.com/ticket/14722#comment:7>

[Django]

#14722: @last_modified should ignore lack of etag method when USE_ETAGS is enabled
-------------------------------+------------------------------------
Reporter: lamby | Owner: nobody
Type: Bug | Status: new
Component: HTTP handling | Version: 1.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------

Changes (by timo):

* needs_better_patch: 0 => 1

Comment:

Patch needs to be updated.

--
Ticket URL: <https://code.djangoproject.com/ticket/14722#comment:8>

[Django]

#14722: @last_modified should ignore lack of etag method when USE_ETAGS is enabled
-------------------------------+------------------------------------

Reporter: Chris Lamb | Owner: nobody

Type: Bug | Status: new
Component: HTTP handling | Version: 1.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------

Comment (by felixxm):

Claude, Can you check is this still valid? `settings.USE_ETAGS` was
removed in Django 2.1.

--
Ticket URL: <https://code.djangoproject.com/ticket/14722#comment:9>

[Django]

#14722: @last_modified should ignore lack of etag method when USE_ETAGS is enabled
-------------------------------+------------------------------------
Reporter: Chris Lamb | Owner: nobody
Type: Bug | Status: new
Component: HTTP handling | Version: 1.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------

Comment (by Claude Paroz):

Wow, long time ago...

Looks like https://tools.ietf.org/html/rfc7232#section-6 specifies that
Etag checking has precedence over the last modified header. I'd vote for
won't fixing this. Chris, any renewed opinion?

--
Ticket URL: <https://code.djangoproject.com/ticket/14722#comment:10>